From 8ffd7b68d63ac79ac401543d7db90302d746ca27 Mon Sep 17 00:00:00 2001
From: Scott Ullrich <sullrich@pfsense.org>
Date: Mon, 24 Oct 2005 21:01:22 +0000
Subject: [PATCH] MFC 7126 Correctly define port rule.

---
 etc/inc/filter.inc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/etc/inc/filter.inc b/etc/inc/filter.inc
index d13261e263..a7ae3c404e 100644
--- a/etc/inc/filter.inc
+++ b/etc/inc/filter.inc
@@ -370,9 +370,11 @@ function filter_nat_rules_generate_if($if, $src, $srcport, $dst, $natport, $targ
 
 	/* set the source port the world sees */
 	if ($srcport)
-		$second_half_of_rule .= " port {$srcport}";
+		$srcport_rule .= " port {$srcport}";
+	else
+		$srcport_rule = "";
 
-        $natrule = "{$nat} on {$if} from {$src} to {$dst} {$second_half_of_rule}\n";
+        $natrule = "{$nat} on {$if} from {$src}{$srcport_rule} to {$dst} {$second_half_of_rule}\n";
 
 	return $natrule;
 }