From 87f2868788bf7254945650cf58a6230d7bcddd99 Mon Sep 17 00:00:00 2001 From: Ermal Date: Wed, 31 Mar 2010 21:16:14 +0000 Subject: [PATCH] Micro-optimization, no need to fork here just to get the file contents. --- etc/inc/filter.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/etc/inc/filter.inc b/etc/inc/filter.inc index a4b4eeaa87..40b28e1331 100644 --- a/etc/inc/filter.inc +++ b/etc/inc/filter.inc @@ -289,8 +289,7 @@ function filter_configure_sync() { $rules_error = exec_command("/sbin/pfctl -f {$g['tmp_path']}/rules.debug"); $line_error = split("\:", $rules_error); $line_number = $line_error[1]; - $rules_file = `/bin/cat {$g['tmp_path']}/rules.debug`; - $line_split = split("\n", $rules_file); + $line_split = file("{$g['tmp_path']}/rules.debug"); if(is_array($line_split)) $line_error = "The line in question reads [{$line_number}]: {$line_split[$line_number-1]}"; if($line_error and $line_number) {