Merge remote-tracking branch 'upstream/master'

This commit is contained in:
jim-p 2011-06-26 15:03:35 -04:00
commit 84296ca3f7
7 changed files with 197 additions and 23 deletions

View File

@ -167,16 +167,62 @@ function ca_create(& $ca, $keylen, $lifetime, $dn) {
// generate a new key pair
$res_key = openssl_pkey_new($args);
if (!$res_key) return false;
// generate a certificate signing request
$res_csr = openssl_csr_new($dn, $res_key, $args);
if (!$res_csr) return false;
// self sign the certificate
$res_crt = openssl_csr_sign($res_csr, null, $res_key, $lifetime, $args);
if (!$res_crt) return false;
// export our certificate data
openssl_pkey_export($res_key, $str_key);
openssl_x509_export($res_crt, $str_crt);
if (!openssl_pkey_export($res_key, $str_key) ||
!openssl_x509_export($res_crt, $str_crt))
return false;
// return our ca information
$ca['crt'] = base64_encode($str_crt);
$ca['prv'] = base64_encode($str_key);
$ca['serial'] = 0;
return true;
}
function ca_inter_create(& $ca, $keylen, $lifetime, $dn, $caref) {
// Create Intermediate Certificate Authority
$signing_ca =& lookup_ca($caref);
if (!$signing_ca)
return false;
$signing_ca_res_crt = openssl_x509_read(base64_decode($signing_ca['crt']));
$signing_ca_res_key = openssl_pkey_get_private(array(0 => base64_decode($signing_ca['prv']) , 1 => ""));
if (!$signing_ca_res_crt || !$signing_ca_res_key) return false;
$signing_ca_serial = ++$signing_ca['serial'];
$args = array(
"digest_alg" => "sha1",
"private_key_bits" => (int)$keylen,
"private_key_type" => OPENSSL_KEYTYPE_RSA,
"encrypt_key" => false);
// generate a new key pair
$res_key = openssl_pkey_new($args);
if (!$res_key) return false;
// generate a certificate signing request
$res_csr = openssl_csr_new($dn, $res_key, $args);
if (!$res_csr) return false;
// Sign the certificate
$res_crt = openssl_csr_sign($res_csr, $signing_ca_res_crt, $signing_ca_res_key, $lifetime, $args, $signing_ca_serial);
if (!$res_crt) return false;
// export our certificate data
if (!openssl_pkey_export($res_key, $str_key) ||
!openssl_x509_export($res_crt, $str_crt))
return false;
// return our ca information
$ca['crt'] = base64_encode($str_crt);
@ -213,6 +259,7 @@ function cert_create(& $cert, $caref, $keylen, $lifetime, $dn) {
$ca_str_key = base64_decode($ca['prv']);
$ca_res_crt = openssl_x509_read($ca_str_crt);
$ca_res_key = openssl_pkey_get_private(array(0 => $ca_str_key, 1 => ""));
if(!$ca_res_key) return false;
$ca_serial = ++$ca['serial'];
$args = array(
@ -223,17 +270,21 @@ function cert_create(& $cert, $caref, $keylen, $lifetime, $dn) {
// generate a new key pair
$res_key = openssl_pkey_new($args);
if(!$res_key) return false;
// generate a certificate signing request
$res_csr = openssl_csr_new($dn, $res_key, $args);
if(!$res_csr) return false;
// self sign the certificate
$res_crt = openssl_csr_sign($res_csr, $ca_res_crt, $ca_res_key, $lifetime,
$args, $ca_serial);
if(!$res_crt) return false;
// export our certificate data
openssl_pkey_export($res_key, $str_key);
openssl_x509_export($res_crt, $str_crt);
if (!openssl_pkey_export($res_key, $str_key) ||
!openssl_x509_export($res_crt, $str_crt))
return false;
// return our certificate information
$cert['caref'] = $caref;
@ -253,13 +304,16 @@ function csr_generate(& $cert, $keylen, $dn) {
// generate a new key pair
$res_key = openssl_pkey_new($args);
if(!$res_key) return false;
// generate a certificate signing request
$res_csr = openssl_csr_new($dn, $res_key, $args);
if(!$res_csr) return false;
// export our request data
openssl_pkey_export($res_key, $str_key);
openssl_csr_export($res_csr, $str_csr);
if (!openssl_pkey_export($res_key, $str_key) ||
!openssl_csr_export($res_csr, $str_csr))
return false;
// return our request information
$cert['csr'] = base64_encode($str_csr);
@ -284,7 +338,7 @@ function csr_get_subject($str_crt, $decode = true) {
$components = openssl_csr_get_subject($str_crt);
if (!is_array($components))
if (empty($components) || !is_array($components))
return "unknown";
ksort($components);
@ -306,7 +360,7 @@ function cert_get_subject($str_crt, $decode = true) {
$inf_crt = openssl_x509_parse($str_crt);
$components = $inf_crt['subject'];
if (!is_array($components))
if (empty($components) || !is_array($components))
return "unknown";
ksort($components);
@ -356,9 +410,10 @@ function cert_get_issuer($str_crt, $decode = true) {
$inf_crt = openssl_x509_parse($str_crt);
$components = $inf_crt['issuer'];
ksort($components);
if (!is_array($components))
if (empty($components) || !is_array($components))
return "unknown";
ksort($components);
foreach ($components as $a => $v) {
if (!strlen($issuer))
$issuer = "{$a}={$v}";

View File

@ -161,7 +161,7 @@ function openvpn_port_next($prot) {
function openvpn_get_cipherlist() {
$ciphers = array();
$cipher_out = shell_exec('openvpn --show-ciphers | grep "default key" | awk \'{print $1, "(" $2 "-" $3 ")";}\'');
$cipher_out = shell_exec('/usr/local/sbin/openvpn --show-ciphers | /usr/bin/grep "default key" | /usr/bin/awk \'{print $1, "(" $2 "-" $3 ")";}\'');
$cipher_lines = explode("\n", trim($cipher_out));
sort($cipher_lines);
foreach ($cipher_lines as $line) {
@ -627,7 +627,7 @@ function openvpn_restart($mode, $settings) {
/* start the new process */
$fpath = $g['varetc_path']."/openvpn/{$mode_id}.conf";
mwexec_bg("nohup openvpn --config {$fpath}");
mwexec_bg("/usr/local/sbin/openvpn --config {$fpath}");
if (!$g['booting'])
send_event("filter reload");

View File

@ -842,6 +842,46 @@ function upgrade_044_to_045() {
function upgrade_045_to_046() {
global $config;
/* Load up monitors that are in the default config for 2.0 but not in 1.2.3
thus wouldn't be in an upgraded config. */
$config['load_balancer']['monitor_type'] = array (
array ( 'name' => 'ICMP',
'type' => 'icmp',
'descr' => 'ICMP',
'options' => '',
),
array ( 'name' => 'TCP',
'type' => 'tcp',
'descr' => 'Generic TCP',
'options' => '',
),
array ( 'name' => 'HTTP',
'type' => 'http',
'descr' => 'Generic HTTP',
'options' =>
array ( 'path' => '/',
'host' => '',
'code' => '200',
),
),
array ( 'name' => 'HTTPS',
'type' => 'https',
'descr' => 'Generic HTTPS',
'options' =>
array ( 'path' => '/',
'host' => '',
'code' => '200',
),
),
array ( 'name' => 'SMTP',
'type' => 'send',
'descr' => 'Generic SMTP',
'options' =>
array ( 'send' => 'EHLO nosuchhost',
'expect' => '250-',
),
),
);
/* Upgrade load balancer from slb to relayd */
if (is_array($config['load_balancer']['virtual_server']) && count($config['load_balancer']['virtual_server'])) {
$vs_a = &$config['load_balancer']['virtual_server'];

2
etc/rc
View File

@ -365,7 +365,7 @@ if [ -f /etc/rc.custom_boot_early ]; then
echo "Done"
fi
nohup /usr/bin/nice -n20 /usr/local/sbin/check_reload_status
/usr/bin/nice -n20 /usr/local/sbin/check_reload_status
# let the PHP-based configuration subsystem set up the system now
echo -n "Launching the init system..."

View File

@ -607,7 +607,7 @@ function get_dates($curperiod, $graph) {
}
/* generate update events utilizing prototype $('') feature */
echo "\n";
echo "\t\t\$('{$graph}-{$curoption}-{$curdatabase}').src='status_rrd_graph_img.php?start={$start}&end={$end}&graph={$graph}&database={$curdatabase}&style={$curstyle}&tmp=' + randomid;\n";
echo "\t\t\$('{$graph}-{$curoption}-{$curdatabase}').src='status_rrd_graph_img.php?start={$start}&graph={$graph}&database={$curdatabase}&style={$curstyle}&tmp=' + randomid;\n";
}
}
?>

View File

@ -42,7 +42,8 @@ require_once("certs.inc");
$ca_methods = array(
"existing" => gettext("Import an existing Certificate Authority"),
"internal" => gettext("Create an internal Certificate Authority"));
"internal" => gettext("Create an internal Certificate Authority"),
"intermediate" => gettext("Create an intermediate Certificate Authority"));
$ca_keylens = array( "512", "1024", "2048", "4096");
@ -154,7 +155,7 @@ if ($act == "expkey") {
if ($_POST) {
$input_errors = array();
unset($input_errors);
$pconfig = $_POST;
/* input validation */
@ -183,6 +184,22 @@ if ($_POST) {
gettext("Distinguished name Email Address"),
gettext("Distinguished name Common Name"));
}
if ($pconfig['method'] == "intermediate") {
$reqdfields = explode(" ",
"descr caref keylen lifetime dn_country dn_state dn_city ".
"dn_organization dn_email dn_commonname");
$reqdfieldsn = array(
gettext("Descriptive name"),
gettext("Signing Certificate Authority"),
gettext("Key length"),
gettext("Lifetime"),
gettext("Distinguished name Country Code"),
gettext("Distinguished name State or Province"),
gettext("Distinguished name City"),
gettext("Distinguished name Organization"),
gettext("Distinguished name Email Address"),
gettext("Distinguished name Common Name"));
}
do_input_validation($_POST, $reqdfields, $reqdfieldsn, &$input_errors);
if ($pconfig['method'] != "existing")
@ -226,10 +243,11 @@ if ($_POST) {
if (!empty($pconfig['key']))
$ca['prv'] = base64_encode($pconfig['key']);
} else {
$old_err_level = error_reporting(0); /* otherwise openssl_ functions throw warings directly to a page screwing menu tab */
if ($pconfig['method'] == "existing")
ca_import($ca, $pconfig['cert'], $pconfig['key'], $pconfig['serial']);
if ($pconfig['method'] == "internal") {
else if ($pconfig['method'] == "internal") {
$dn = array(
'countryName' => $pconfig['dn_country'],
'stateOrProvinceName' => $pconfig['dn_state'],
@ -237,8 +255,29 @@ if ($_POST) {
'organizationName' => $pconfig['dn_organization'],
'emailAddress' => $pconfig['dn_email'],
'commonName' => $pconfig['dn_commonname']);
ca_create($ca, $pconfig['keylen'], $pconfig['lifetime'], $dn);
if (!ca_create($ca, $pconfig['keylen'], $pconfig['lifetime'], $dn)){
while($ssl_err = openssl_error_string()){
$input_errors = array();
array_push($input_errors, "openssl library returns: " . $ssl_err);
}
}
}
else if ($pconfig['method'] == "intermediate") {
$dn = array(
'countryName' => $pconfig['dn_country'],
'stateOrProvinceName' => $pconfig['dn_state'],
'localityName' => $pconfig['dn_city'],
'organizationName' => $pconfig['dn_organization'],
'emailAddress' => $pconfig['dn_email'],
'commonName' => $pconfig['dn_commonname']);
if (!ca_inter_create($ca, $pconfig['keylen'], $pconfig['lifetime'], $dn, $pconfig['caref'])){
while($ssl_err = openssl_error_string()){
$input_errors = array();
array_push($input_errors, "openssl library returns: " . $ssl_err);
}
}
}
error_reporting($old_err_level);
}
if (isset($id) && $a_ca[$id])
@ -246,7 +285,8 @@ if ($_POST) {
else
$a_ca[] = $ca;
write_config();
if (!$input_errors)
write_config();
// pfSenseHeader("system_camanager.php");
}
@ -268,10 +308,17 @@ function method_change() {
case 0:
document.getElementById("existing").style.display="";
document.getElementById("internal").style.display="none";
document.getElementById("intermediate").style.display="none";
break;
case 1:
document.getElementById("existing").style.display="none";
document.getElementById("internal").style.display="";
document.getElementById("intermediate").style.display="none";
break;
case 2:
document.getElementById("existing").style.display="none";
document.getElementById("internal").style.display="";
document.getElementById("intermediate").style.display="";
break;
}
}
@ -385,6 +432,23 @@ function method_change() {
<tr>
<td colspan="2" valign="top" class="listtopic"><?=gettext("Internal Certificate Authority");?></td>
</tr>
<tr id='intermediate'>
<td width="22%" valign="top" class="vncellreq"><?=gettext("Signing Certificate Authority");?></td>
<td width="78%" class="vtable">
<select name='caref' id='caref' class="formselect" onChange='internalca_change()'>
<?php
foreach( $a_ca as $ca):
if (!$ca['prv'])
continue;
$selected = "";
if ($pconfig['caref'] == $ca['refid'])
$selected = "selected";
?>
<option value="<?=$ca['refid'];?>"<?=$selected;?>><?=$ca['descr'];?></option>
<?php endforeach; ?>
</select>
</td>
</tr>
<tr>
<td width="22%" valign="top" class="vncellreq"><?=gettext("Key length");?></td>
<td width="78%" class="vtable">

View File

@ -240,6 +240,8 @@ if ($_POST) {
$cert['descr'] = $pconfig['descr'];
$old_err_level = error_reporting(0); /* otherwise openssl_ functions throw warings directly to a page screwing menu tab */
if ($pconfig['method'] == "import")
cert_import($cert, $pconfig['cert'], $pconfig['key']);
@ -252,8 +254,13 @@ if ($_POST) {
'emailAddress' => $pconfig['dn_email'],
'commonName' => $pconfig['dn_commonname']);
cert_create($cert, $pconfig['caref'], $pconfig['keylen'],
$pconfig['lifetime'], $dn);
if (!cert_create($cert, $pconfig['caref'], $pconfig['keylen'],
$pconfig['lifetime'], $dn)){
while($ssl_err = openssl_error_string()){
$input_errors = array();
array_push($input_errors, "openssl library returns: " . $ssl_err);
}
}
}
if ($pconfig['method'] == "external") {
@ -265,8 +272,15 @@ if ($_POST) {
'emailAddress' => $pconfig['csr_dn_email'],
'commonName' => $pconfig['csr_dn_commonname']);
csr_generate($cert, $pconfig['csr_keylen'], $dn);
if(!csr_generate($cert, $pconfig['csr_keylen'], $dn)){
while($ssl_err = openssl_error_string()){
$input_errors = array();
array_push($input_errors, "openssl library returns: " . $ssl_err);
}
}
}
error_reporting($old_err_level);
if (isset($id) && $a_cert[$id])
$a_cert[$id] = $cert;
else
@ -275,7 +289,8 @@ if ($_POST) {
$a_user[$userid]['cert'][] = $cert['refid'];
}
write_config();
if (!$input_errors)
write_config();
if ($userid)
pfSenseHeader("system_usermanager.php?act=edit&id={$userid}");