mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

MFC 11967

Browse Source 
Do not allow user to shoot themselves in the foot (and the kernel, apparently) by adding a CARP ip to the system if a real ip on a real interface doesnt exist to match.
Tickets:
This commit is contained in:
Scott Ullrich 2006-04-25 20:48:41 +00:00
parent 3e32a807b1
commit 83b8554f2d
1 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
usr/local/www/firewall_virtual_ip_edit.php
View File

@ -49,6 +49,11 @@ if (isset($_POST['id']))
else
$id = $_GET['id'];
function return_first_three_octets($ip) {
$ip_split = split("\.", $ip);
return $ip_split[0] . "." . $ip_split[1] . "." . $ip_split[2];
}
if (isset($id) && $a_vip[$id]) {
$pconfig['mode'] = $a_vip[$id]['mode'];
$pconfig['vhid'] = $a_vip[$id]['vhid'];
@ -103,6 +108,31 @@ if ($_POST) {
}
}
/* make sure new ip is within the subnet of a valid ip
* on one of our interfaces (wan, lan optX)
*/
if ($_POST['mode'] === "carp") {
$can_post = true;
$found = false;
$subnet_ip = return_first_three_octets($_POST['subnet']);
$iflist = array("lan", "wan");
for ($i = 1; isset($config['interfaces']['opt' . $i]); $i++)
$iflist['opt' . $i] = 'opt' . $i;
foreach($iflist as $if) {
$ww_subnet_ip = return_first_three_octets($config['interfaces'][$if]['ipaddr']);
if($ww_subnet_ip == $subnet_ip) {
$found = true;
break;
}
}
if($found == false) {
$cannot_find = $_POST['subnet'];
$can_post = false;
}
if($can_post == false)
$input_error[] = "Sorry, we could not locate an interface with a matching subnet for {$cannot_find}.<p>Please add an ip in this subnet on a real interface.";
}
if (!$input_errors) {
$vipent = array();