From 8022eaaafc67d39da423393c2ee16be878d509db Mon Sep 17 00:00:00 2001 From: Scott Ullrich Date: Thu, 22 Dec 2005 18:27:57 +0000 Subject: [PATCH] Avoid a Warning:Invalid argument supplied for foreach() in /etc/inc/pfsense-utils.inc on line 177 --- etc/inc/pfsense-utils.inc | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/etc/inc/pfsense-utils.inc b/etc/inc/pfsense-utils.inc index 019374ef62..7ad9978210 100644 --- a/etc/inc/pfsense-utils.inc +++ b/etc/inc/pfsense-utils.inc @@ -167,17 +167,21 @@ function is_alias_inuse($alias) { if($alias == "") return false; /* loop through firewall rules looking for alias in use */ foreach($config['filter']['rule'] as $rule) { - if($rule['source']['address'] == $alias) - return true; - if($rule['destination']['address'] == $alias) - return true; + if(isset($rule['source'])) + if($rule['source']['address'] == $alias) + return true; + if(isset($rule['destination'])) + if($rule['destination']['address'] == $alias) + return true; } /* loop through nat rules looking for alias in use */ foreach($config['nat']['rule'] as $rule) { - if($rule['source']['address'] == $alias) - return true; - if($rule['destination']['address'] == $alias) - return true; + if(isset($rule['source'])) + if($rule['source']['address'] == $alias) + return true; + if(isset($rule['destination'])) + if($rule['destination']['address'] == $alias) + return true; } return false; }