mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not process dhcpd implementation if input errors

Browse Source 
If I go to Service->DHCP Server, make some edits that are invalid (e.g. change range start or end to some invalid string) and press Save then the page comes back displaying the input error(s). But it also says:
"The changes have been applied successfully."
Actually, the changes (which were invalid) have not been applied to the config - all is well there - but dhcpd has been stopped and started and dnsmasq or unbound has been kicked... which is all unnecessary processing since the user has not yet provided valid values to save.
This commit is contained in:
Phil Davis 2015-04-23 20:10:30 +05:45 committed by Renato Botelho
parent 1fa1a40b84
commit 73bbcaed4d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
usr/local/www/services_dhcp.php
View File

@ -490,7 +490,7 @@ if (isset($_POST['submit'])) {
}
}
if (isset($_POST['submit']) || isset($_POST['apply'])) {
if ((isset($_POST['submit']) || isset($_POST['apply'])) && (!$input_errors)) {
$retval = 0;
$retvaldhcp = 0;
$retvaldns = 0;