From 70ed5a6af5e2bdbfcb1f35e2fba9b748043f1260 Mon Sep 17 00:00:00 2001
From: Scott Ullrich <sullrich@pfsense.org>
Date: Tue, 14 Dec 2010 15:59:39 -0500
Subject: [PATCH] Use file_put_contents()

---
 usr/local/www/pkg_mgr_install.php | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/usr/local/www/pkg_mgr_install.php b/usr/local/www/pkg_mgr_install.php
index e4e25e72be..029517207b 100755
--- a/usr/local/www/pkg_mgr_install.php
+++ b/usr/local/www/pkg_mgr_install.php
@@ -153,7 +153,7 @@ switch($_GET['mode']) {
 			update_output_window($static_output);
 			filter_configure();
 		}
-		file_put_contents("/tmp/" . $_GET['pkg']  . ".info", $static_output);
+		file_put_contents("/tmp/" . escapeshellcmd($_GET['pkg'])  . ".info", $static_output);
 		echo "<script type='text/javascript'>document.location=\"pkg_mgr_install.php?mode=installedinfo&pkg={$_GET['pkg']}\";</script>";
 		break;
 	case "installedinfo":
@@ -193,8 +193,6 @@ switch($_GET['mode']) {
 			$static_output .= "\n" . gettext("Installation halted.");
 			update_output_window($static_output);
 		} else {
-			$filename = escapeshellcmd("/tmp/" . $_GET['id']  . ".info");
-			$fd = fopen($filename, "w");
 			$status_a = gettext("Installation of") . " " . htmlspecialchars($_GET['id']) . " " . gettext("completed.");
 			update_status($status_a);
 			$status = get_after_install_info($_GET['id']);
@@ -202,9 +200,8 @@ switch($_GET['mode']) {
 				$static_output .= "\n" . gettext("Installation completed.") . "\n{$_GET['id']} " . gettext("setup instructions") . ":\n{$status}";
 			else
 				$static_output .= "\n" . gettext("Installation completed.   Please check to make sure that the package is configured from the respective menu then start the package.");
-			fwrite($fd, $status_a . "\n". $static_output);
-			fclose($fd);
-			echo "<script type='text/javascript'>document.location=\"pkg_mgr_install.php?mode=installedinfo&pkg={$_GET['id']}\";</script>";
+		file_put_contents("/tmp/" . escapeshellcmd($_GET['id'])  . ".info", $static_output);
+		echo "<script type='text/javascript'>document.location=\"pkg_mgr_install.php?mode=installedinfo&pkg={$_GET['id']}\";</script>";
 		}
 		filter_configure();
 		break;