From 6b86258045007bdceeb4bb5522b160c01dd9071e Mon Sep 17 00:00:00 2001
From: Scott Ullrich <sullrich@pfsense.org>
Date: Mon, 6 Jun 2005 23:07:49 +0000
Subject: [PATCH] Corretly enable checked rules and only turn on rules for
 checked items

---
 .../www/wizards/traffic_shaper_wizard.xml     | 56 ++++++++++---------
 1 file changed, 29 insertions(+), 27 deletions(-)

diff --git a/usr/local/www/wizards/traffic_shaper_wizard.xml b/usr/local/www/wizards/traffic_shaper_wizard.xml
index 51ca539f55..b183665173 100644
--- a/usr/local/www/wizards/traffic_shaper_wizard.xml
+++ b/usr/local/www/wizards/traffic_shaper_wizard.xml
@@ -256,6 +256,7 @@
                         <name>Bandwidth</name>
                         <type>select</type>
 			<typehint>Bandwidth guarantee for VOIP phone</typehint>
+			<default>128</default>
 			<options>
 				<option>
 					<name>1500Kbits/sec</name>
@@ -377,7 +378,8 @@
 		}
                 
                 /* setup vonage rule */
-                $voiplist[] = array('Vonage','udp','5060','5060','both');
+		if( _POST['vonage'] != "") 
+		    $voiplist[] = array('Vonage','udp','5060','5060','both');
                 
 		/* Set up/down games as higher weight */
 		/* loop through voiplist[] */
@@ -548,45 +550,45 @@
 		$p2plist = array();
 
 		/* To add p2p clients, push Descr,Protocol,Start,End,src/dest/both onto p2plist */
-		if($_POST['Aimster'] != "") 
+		if($_POST['aimster'] != "") 
 		    $p2plist[] = array('Aimster','tcp','7668','7668','both');
-		if($_POST['BitTorrent'] != "") 		    
+		if($_POST['bittorrent'] != "") 		    
 		    $p2plist[] = array('BitTorrent','tcp','6881','6999','both');
-		if($_POST['BuddyShare'] != "") 		
+		if($_POST['buddyshare'] != "") 		
 		    $p2plist[] = array('BuddyShare','tcp','7788','7788','both');
-		if($_POST['CuteMX'] != "") 		
+		if($_POST['cutemx'] != "") 		
 		    $p2plist[] = array('CuteMX','tcp','2340','2340','both');
-		if($_POST['DC++'] != "") 		
+		if($_POST['dc++'] != "") 		
 		    $p2plist[] = array('DC++','tcp','1412','1412','both');
 		if($_POST['dcc'] != "") 		
 		    $p2plist[] = array('dcc','tcp','6666','6668','both');
-		if($_POST['DirectConnect'] != "") 		
+		if($_POST['directconnect'] != "") 		
 		    $p2plist[] = array('DirectConnect','tcp','412','412','both');
-		if($_POST['DirectFileExpress'] != "") 		
+		if($_POST['directfileexpress'] != "") 		
 		    $p2plist[] = array('DirectFileExpress','tcp','1044','1045','both');
-		if($_POST['EDonkey2000'] != "") 		
+		if($_POST['edonkey2000'] != "") 		
 		    $p2plist[] = array('EDonkey2000','tcp','4661','4665','both');
-		if($_POST['FastTrack'] != "") 		
+		if($_POST['fastTrack'] != "") 		
 		    $p2plist[] = array('FastTrack','tcp','1214','1214','both');
-		if($_POST['Gnutella'] != "") 		
+		if($_POST['gnutella'] != "") 		
 		    $p2plist[] = array('Gnutella','tcp','6346','6346','both');
 		if($_POST['grouper'] != "") 		
 		    $p2plist[] = array('grouper','tcp','8038','8039','both');
-		if($_POST['hotComm'] != "") 		
+		if($_POST['hotcomm'] != "") 		
 		    $p2plist[] = array('hotComm','tcp','28864','28865','both');
-		if($_POST['HotlineConnect'] != "") 		
+		if($_POST['hotlineconnect'] != "") 		
 		    $p2plist[] = array('HotlineConnect','tcp','5500','5503','both');
-		if($_POST['iMesh'] != "") 		
+		if($_POST['imesh'] != "") 		
 		    $p2plist[] = array('iMesh','tcp','4329','4329','both');
-		if($_POST['Napster'] != "") 		
+		if($_POST['napster'] != "") 		
 		    $p2plist[] = array('Napster','tcp','6699','6701','both');
-		if($_POST['OpenNap'] != "") 		
+		if($_POST['opennap'] != "") 		
 		    $p2plist[] = array('OpenNap','tcp','8888','8889','both');
-		if($_POST['Scour'] != "") 		
+		if($_POST['scour'] != "") 		
 		    $p2plist[] = array('Scour','tcp','8311','8311','both');
-		if($_POST['SongSpy'] != "") 		
+		if($_POST['songspy'] != "") 		
 		    $p2plist[] = array('SongSpy','tcp','5190','5190','both');
-		if($_POST['WinMX'] != "") 		
+		if($_POST['winmx'] != "") 		
 		    $p2plist[] = array('WinMX','tcp','6699','6699','both');
 
 		/* Set up/down p2p as lowest weight */
@@ -772,7 +774,7 @@
 
 		$gamesplist = array();
 
-		if($_POST['Counterstrike'] != "") {
+		if($_POST['counterstrike'] != "") {
 		    /* counter strike */
 		    $gamesplist[] = array('Titan','udp','6003','6003','both');
 		    $gamesplist[] = array('Authentication','udp','7002','7002','both');
@@ -783,24 +785,24 @@
 		    $gamesplist[] = array('HL-Serverport ','udp','27015','27015','both');
 		}
 
-		if($_POST['DeltaForce'] != "") {
+		if($_POST['deltaforce'] != "") {
 		    /* delta force */
 		    $gamesplist[] = array('Delta1','udp','17478','17488','both');
 		}
 
-		if($_POST['QuakeIII'] != "") {
+		if($_POST['quakeiii'] != "") {
 		    /* quake3 */
 		    $gamesplist[] = array('Delta1','udp','27910','27919','both');
 		}
 
-		if($_POST['TigerWoods2004PS2'] != "") {
+		if($_POST['tigerwoods2004ps2'] != "") {
 		    /* tiger woods 2004 ps2 */
 		    $gamesplist[] = array('Outbound2Player','udp','3658','3658','both');
 		    $gamesplist[] = array('Outbound2Player2','udp','6000','6000','both');	    
 		    $gamesplist[] = array('Outbound2EA','tcp','10300','10301','both');
 		}
 
-		if($_POST['CallOfDuty'] != "") {
+		if($_POST['callofduty'] != "") {
 		    /* Call of Duty (United Offensive) */
 		    $gamesplist[] = array('CallOfDuty1','tcp','28960','28960','both');
 		    $gamesplist[] = array('CallOfDuty2','udp','28960','28960','both');
@@ -931,18 +933,18 @@
                 
 		$othersplist = array();
 		
-		if($_POST['MSRDP'] != "") {
+		if($_POST['msrdp'] != "") {
 		    /* MSRDP */
 		    $othersplist[] = array('MSRDP','tcp','3389','3389','both');
 		}
 		
-		if($_POST['PPTP'] != "") {
+		if($_POST['pptp'] != "") {
 		    /* PPTP */
 		    $othersplist[] = array('PPTP','tcp','1723','1723','both');
 		    $othersplist[] = array('PPTPGRE','gre','','','both');
                 }
 
-		if($_POST['IPSEC'] != "") {
+		if($_POST['ipsec'] != "") {
 		    /* IPSEC */
 		    $othersplist[] = array('IPSEC','tcp','500','500','both');
 		}