mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use php_check_syntax on code before eval()

Browse Source
This commit is contained in:
Scott Ullrich 2005-03-13 21:54:28 +00:00
parent a1f1ebb44a
commit 677e088005
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
etc/inc/filter.inc
View File

@ -105,7 +105,7 @@ function filter_configure() {
$maximumstates = $config['system']['maximumstates'];
$rules.= "set limit states " . $maximumstates . "\n";
}
$rules.= "\n";
$rules.= "scrub on {$wanif} reassemble tcp random-id " . $mssclamp ."\n"; // reassemble all directions
$rules.= $altq_ints . "\n";
@ -160,7 +160,8 @@ function filter_configure() {
if($file <> "") {
$text = return_filename_as_string("/usr/local/pkg/pf/" . $file);
if($text != "")
eval($text);
if(php_check_syntax($toeval, $error_message) == false)
eval($text);
}
}
}

14
usr/local/www/pkg_mgr_install.php
View File

@ -383,11 +383,14 @@ foreach ($packages_to_install as $id) {
if($menu['url'] <> "") {
// override $myurl for script.
$toeval = "\$myurl = \"" . getenv("HTTP_HOST") . "\"; \n";
eval($toeval);
$error_message = "";
if(php_check_syntax($toeval, $error_message) == false)
eval($toeval);
// eval url so that above $myurl item can be processed if need be.
$urltmp = $menu['url'];
$toeval = "\$url = \"" . $urltmp . "\"; \n";
eval($toeval);
if(php_check_syntax($toeval, $error_message) == false)
eval($toeval);
fwrite($fd, $url . "\n");
} else {
$xml = "";
@ -419,11 +422,14 @@ foreach ($packages_to_install as $id) {
if($package_conf['custom_php_install_command']) {
update_status("Executing post install commands...\n");
fwrite($fd_log, "Executing post install commands...\n");
$error_message = "";
if($package_conf['custom_php_command_before_form'] <> "")
eval($package_conf['custom_php_command_before_form']);
if(php_check_syntax($package_conf['custom_php_command_before_form'], $error_message) == false)
eval($package_conf['custom_php_command_before_form']);
$pb_percent += 50;
update_progress_bar(50);
eval($package_conf['custom_php_install_command']);
if(php_check_syntax($package_conf['custom_php_install_command'], $error_message) == false)
eval($package_conf['custom_php_install_command']);
}
$pb_percent += 10;