mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

diag_nanobsd do not show reference count 0

Browse Source 
When the user has selected "Keep media mounted read/write at all times." then the value of $refcount will be zero even though is_writable() is true. That is a normal condition.
We only want to display the (Reference count n) text when the reference count is abnormal.
This is a "bug" in 2.2.* also, not a regression in 2.3-ALPHA. But it might as well just be changed in master 2.3. Not much point back-porting little crud like this to RELENG_2_2 nowadays.
This commit is contained in:
Phil Davis 2015-11-06 09:55:45 +05:45
parent 9da2cf1c6e
commit 612d0fb365
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/usr/local/www/diag_nanobsd.php
View File

@ -168,7 +168,9 @@ $section->addInput(new Form_StaticText(
if (is_writable("/")) {
$refcount = refcount_read(1000);
/* refcount_read returns -1 when shared memory section does not exist */
if ($refcount == 1 || $refcount == -1) {
/* refcount can be zero here when the user has set nanobsd_force_rw */
/* refcount 1 is normal, so only display the count for abnormal values */
if ($refcount == 1 || $refcount == 0 || $refcount == -1) {
$refdisplay = "";
} else {
$refdisplay = " (Reference count " . $refcount . ")";