mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not allow an alias to be deleted if its currently referenced ina rule.

Browse Source 
Ticket #914
This commit is contained in:
Scott Ullrich 2006-04-19 01:45:25 +00:00
parent 9440aff3a0
commit 58c32a28e6
1 changed files with 44 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
usr/local/www/firewall_aliases.php
View File

@ -64,11 +64,50 @@ if ($_POST) {
if ($_GET['act'] == "del") {
if ($a_aliases[$_GET['id']]) {
unset($a_aliases[$_GET['id']]);
write_config();
touch($d_aliasesdirty_path);
header("Location: firewall_aliases.php");
exit;
/* make sure rule is not being referenced by any nat or filter rules */
$is_alias_referenced = false;
$referenced_by = false;
$alias_name = $a_aliases[$_GET['id']]['name'];
foreach($config['nat']['rule'] as $rule) {
if($rule['localip'] == $alias_name) {
$is_alias_referenced = true;
$referenced_by = $rule['descr'];
break;
}
}
if($is_alias_referenced == false) {
foreach($config['filter']['rule'] as $rule) {
if($rule['source']['address'] == $alias_name) {
$is_alias_referenced = true;
$referenced_by = $rule['descr'];
break;
}
if($rule['source']['address'] == $alias_name) {
$is_alias_referenced = true;
$referenced_by = $rule['descr'];
break;
}
if($rule['source']['port'] == $alias_name) {
$is_alias_referenced = true;
$referenced_by = $rule['descr'];
break;
}
if($rule['destination']['port'] == $alias_name) {
$is_alias_referenced = true;
$referenced_by = $rule['descr'];
break;
}
}
}
if($is_alias_referenced == true) {
$savemsg = "Cannot delete rule. Currently in use by {$referenced_by}";
} else {
unset($a_aliases[$_GET['id']]);
write_config();
touch($d_aliasesdirty_path);
header("Location: firewall_aliases.php");
exit;
}
}
}