From 587c2d557612ccfa856b2ca47799429cab0fce88 Mon Sep 17 00:00:00 2001 From: jim-p Date: Tue, 29 Jan 2019 11:11:13 -0500 Subject: [PATCH] Validate submitted interfaces. Issue #9294 (cherry picked from commit 5cc7d21dc08be6c65a2bf7f8f4481dc13f4ae115) --- src/usr/local/www/interfaces_assign.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/usr/local/www/interfaces_assign.php b/src/usr/local/www/interfaces_assign.php index 5d42b95e16..fd44048ab2 100644 --- a/src/usr/local/www/interfaces_assign.php +++ b/src/usr/local/www/interfaces_assign.php @@ -251,7 +251,11 @@ if (isset($_REQUEST['add']) && isset($_REQUEST['if_add'])) { build a list of port-to-interface mappings in portifmap */ foreach ($_POST as $ifname => $ifport) { if (($ifname == 'lan') || ($ifname == 'wan') || (substr($ifname, 0, 3) == 'opt')) { - $portifmap[$ifport][] = strtoupper($ifname); + if (array_key_exists($ifport, $portlist)) { + $portifmap[$ifport][] = strtoupper($ifname); + } else { + $input_errors[] = sprintf(gettext('Cannot set port %1$s because the submitted interface does not exist.'), $ifname); + } } }