From 475d6311dff3f4d5ea3f1fe74d74ba2c598c355c Mon Sep 17 00:00:00 2001
From: Phil Davis <phil.davis@inf.org>
Date: Tue, 3 Nov 2015 08:38:35 +0545
Subject: [PATCH] diag_logs_filter reduce duplicated icon code

Almost all the code in old lines 457 and 462 was the same. Make the logic a bit clearer about exactly what is the difference and hopefully reduce future code maintenance issues.
---
 src/usr/local/www/diag_logs_filter.php | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/usr/local/www/diag_logs_filter.php b/src/usr/local/www/diag_logs_filter.php
index 9f6bb27afd..9e1cb59180 100644
--- a/src/usr/local/www/diag_logs_filter.php
+++ b/src/usr/local/www/diag_logs_filter.php
@@ -453,16 +453,12 @@ if (!isset($config['syslog']['rawfilter'])) {
 				<td>
 <?php
 		if ($filterent['act'] == "block") {
-?>
-					<i  class="fa fa-times icon-danger icon-pointer" title="<?php echo $filterent['act'] .'/'. $filterent['tracker'];?>" onclick="javascript:getURL('diag_logs_filter.php?getrulenum=<?="{$filterent['rulenum']},{$filterent['tracker']},{$filterent['act']}"; ?>', outputrule);"></i>
-<?php
-		 }
-		 else {
-?>
-					<i class="fa fa-check icon-success icon-pointer" title="<?php echo $filterent['act'] .'/'. $filterent['tracker'];?>" onclick="javascript:getURL('diag_logs_filter.php?getrulenum=<?="{$filterent['rulenum']},{$filterent['tracker']},{$filterent['act']}"; ?>', outputrule);"></i>
-<?php
+			$icon_act = "fa-times icon-danger";
+		} else {
+			$icon_act = "fa-check icon-success";
 		}
 ?>
+					<i class="fa <?php echo $icon_act;?> icon-pointer" title="<?php echo $filterent['act'] .'/'. $filterent['tracker'];?>" onclick="javascript:getURL('diag_logs_filter.php?getrulenum=<?="{$filterent['rulenum']},{$filterent['tracker']},{$filterent['act']}"; ?>', outputrule);"></i>
 <?php
 		if ($filterent['count'])
 			echo $filterent['count'];