mirror of
https://github.com/pfsense/pfsense.git
synced 2025-10-26 11:38:35 +00:00
Merge pull request #749 from phil-davis/master
Reorder reverse lookup overrides so user-specified ones are effective
This commit is contained in:
commit
3cc77e15f0
@ -1669,16 +1669,9 @@ function services_dnsmasq_configure() {
|
||||
}
|
||||
}
|
||||
|
||||
/* Setup forwarded domains */
|
||||
if (isset($config['dnsmasq']['domainoverrides']) && is_array($config['dnsmasq']['domainoverrides'])) {
|
||||
foreach($config['dnsmasq']['domainoverrides'] as $override) {
|
||||
if ($override['ip'] == "!")
|
||||
$override[ip] = "";
|
||||
$args .= ' --server=/' . $override['domain'] . '/' . $override['ip'];
|
||||
}
|
||||
}
|
||||
|
||||
/* If selected, then forward reverse lookups for private IPv4 addresses to nowhere. */
|
||||
/* If selected, then first forward reverse lookups for private IPv4 addresses to nowhere. */
|
||||
/* If any of these are duplicated by a user-specified domain override (e.g. 10.in-addr.arpa) then */
|
||||
/* the user-specified entry made later on the command line below will be the one that is effective. */
|
||||
if (isset($config['dnsmasq']['no_private_reverse'])) {
|
||||
/* Note: Carrier Grade NAT (CGN) addresses 100.64.0.0/10 are intentionally not here. */
|
||||
/* End-users should not be aware of CGN addresses, so reverse lookups for these should not happen. */
|
||||
@ -1691,6 +1684,15 @@ function services_dnsmasq_configure() {
|
||||
}
|
||||
}
|
||||
|
||||
/* Setup forwarded domains */
|
||||
if (isset($config['dnsmasq']['domainoverrides']) && is_array($config['dnsmasq']['domainoverrides'])) {
|
||||
foreach($config['dnsmasq']['domainoverrides'] as $override) {
|
||||
if ($override['ip'] == "!")
|
||||
$override[ip] = "";
|
||||
$args .= ' --server=/' . $override['domain'] . '/' . $override['ip'];
|
||||
}
|
||||
}
|
||||
|
||||
/* Allow DNS Rebind for forwarded domains */
|
||||
if (isset($config['dnsmasq']['domainoverrides']) && is_array($config['dnsmasq']['domainoverrides'])) {
|
||||
if(!isset($config['system']['webgui']['nodnsrebindcheck'])) {
|
||||
|
||||
Loading…
Reference in New Issue
Block a user