diff --git a/usr/local/www/vpn_openvpn_client.php b/usr/local/www/vpn_openvpn_client.php index 2f46ca62bd..faf89f9812 100644 --- a/usr/local/www/vpn_openvpn_client.php +++ b/usr/local/www/vpn_openvpn_client.php @@ -1171,7 +1171,7 @@ if ($savemsg) $i++; endforeach; ?> - + diff --git a/usr/local/www/vpn_openvpn_server.php b/usr/local/www/vpn_openvpn_server.php index fea1531d9f..b049c817f9 100644 --- a/usr/local/www/vpn_openvpn_server.php +++ b/usr/local/www/vpn_openvpn_server.php @@ -89,7 +89,7 @@ if ($_GET['act'] == "del") { $savemsg = gettext("Server successfully deleted")."
"; } -if($_GET['act']=="new"){ +if($_GET['act']=="new") { $pconfig['autokey_enable'] = "yes"; $pconfig['tlsauth_enable'] = "yes"; $pconfig['autotls_enable'] = "yes"; @@ -104,7 +104,7 @@ if($_GET['act']=="new"){ $pconfig['digest'] = "SHA1"; } -if($_GET['act']=="edit"){ +if($_GET['act']=="edit") { if (isset($id) && $a_server[$id]) { $pconfig['disable'] = isset($a_server[$id]['disable']); @@ -370,7 +370,7 @@ if ($_POST) { if ($_POST['disable'] == "yes") $server['disable'] = true; $server['mode'] = $pconfig['mode']; - if (!empty($pconfig['authmode'])) + if (!empty($pconfig['authmode']) && (($pconfig['mode'] == "server_user") || ($pconfig['mode'] == "server_tls_user"))) $server['authmode'] = implode(",", $pconfig['authmode']); $server['protocol'] = $pconfig['protocol']; $server['dev_mode'] = $pconfig['dev_mode']; @@ -547,7 +547,7 @@ function mode_change() { document.getElementById("inter_client_communication").style.display="none"; break; case "server_user": - case "server_tls_user": + case "server_tls_user": document.getElementById("authmodetr").style.display=""; document.getElementById("client_opts").style.display=""; document.getElementById("remote_optsv4").style.display="none"; @@ -795,22 +795,26 @@ if ($savemsg) - - - + $auth_server): - $selected = ""; - if (in_array($auth_server_key, $authmodes)) - $selected = "selected=\"selected\""; - ?> - - - - - + // If no authmodes set then default to selecting the first entry in auth_servers + if (empty($authmodes[0]) && !empty(key($auth_servers))) + $authmodes[0] = key($auth_servers); + + foreach ($auth_servers as $auth_server_key => $auth_server): + $selected = ""; + if (in_array($auth_server_key, $authmodes)) + $selected = "selected=\"selected\""; + ?> + + + + + @@ -824,28 +828,28 @@ if ($savemsg) - + - - + + + + + + @@ -994,20 +998,20 @@ if ($savemsg) @@ -1089,13 +1093,13 @@ if ($savemsg) $desc): - $selected = ""; - if ($name == $pconfig['digest']) - $selected = " selected=\"selected\""; + $selected = ""; + if ($name == $pconfig['digest']) + $selected = " selected=\"selected\""; ?> - +
@@ -1108,13 +1112,13 @@ if ($savemsg) $desc): - $selected = ""; - if ($name == $pconfig['engine']) - $selected = " selected=\"selected\""; + $selected = ""; + if ($name == $pconfig['engine']) + $selected = " selected=\"selected\""; ?> - + @@ -1128,11 +1132,11 @@ if ($savemsg) $depthdesc): - $selected = ""; - if ($depth == $pconfig['cert_depth']) - $selected = " selected=\"selected\""; + $selected = ""; + if ($depth == $pconfig['cert_depth']) + $selected = " selected=\"selected\""; ?> - + @@ -1177,7 +1181,7 @@ if ($savemsg) "communications between this server and client " . "hosts expressed using CIDR (eg. 10.0.8.0/24). " . "The first network address will be assigned to " . - "the server virtual interface. The remaining " . + "the server virtual interface. The remaining " . "network addresses can optionally be assigned " . "to connecting clients. (see Address Pool)"); ?> @@ -1351,11 +1355,11 @@ if ($savemsg)
@@ -1690,7 +1694,7 @@ if ($savemsg)
. @@ -1785,8 +1789,8 @@ if ($savemsg) - - + +