From 796713168488a551ecfe0736bc1ef86487e64056 Mon Sep 17 00:00:00 2001
From: Vinicius Coque <vinicius.coque@bluepex.com>
Date: Fri, 13 Aug 2010 10:20:21 -0300
Subject: [PATCH 1/2] Fix the js that hides advanced button on firewall rules

---
 .../javascript/firewall_rules_edit/firewall_rules_edit.js    | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/usr/local/www/javascript/firewall_rules_edit/firewall_rules_edit.js b/usr/local/www/javascript/firewall_rules_edit/firewall_rules_edit.js
index 38b9363130..ae49a2ab1b 100644
--- a/usr/local/www/javascript/firewall_rules_edit/firewall_rules_edit.js
+++ b/usr/local/www/javascript/firewall_rules_edit/firewall_rules_edit.js
@@ -45,7 +45,7 @@ function ext_change() {
 
 function show_source_port_range() {
 	document.getElementById("sprtable").style.display = '';
-	document.getElementById("showadvancedboxspr").innerHTML='';
+	document.getElementById("showadvancedboxspr").style.display = 'none';
 }
 
 function typesel_change() {
@@ -120,11 +120,12 @@ function proto_change() {
 	if(document.iform.proto.selectedIndex >= 0 && document.iform.proto.selectedIndex <= 2) {
 		document.getElementById("dprtr").style.display = '';
 		if (editenabled) {
-			document.getElementById("showadvancedboxspr").innerHTML='<p><input type="button" onClick="show_source_port_range()" value="Advanced"></input> - Show source port range</a>';
+			document.getElementById("showadvancedboxspr").style.display = 'table-row';
 		}
 	} else {
 		document.getElementById("sprtable").style.display = 'none';
 		document.getElementById("dprtr").style.display = 'none';
+		document.getElementById("showadvancedboxspr").style.display = 'none';
 	}
 }
 

From ec325889dc8a9a9ee4476bea6cb17cc4b63e28fe Mon Sep 17 00:00:00 2001
From: Vinicius Coque <vinicius.coque@bluepex.com>
Date: Fri, 13 Aug 2010 10:30:58 -0300
Subject: [PATCH 2/2] Remove unnecessary JS variable

---
 .../www/javascript/firewall_nat_edit/firewall_nat_edit.js     | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/usr/local/www/javascript/firewall_nat_edit/firewall_nat_edit.js b/usr/local/www/javascript/firewall_nat_edit/firewall_nat_edit.js
index 9f21c2bfc6..e75e1924fc 100644
--- a/usr/local/www/javascript/firewall_nat_edit/firewall_nat_edit.js
+++ b/usr/local/www/javascript/firewall_nat_edit/firewall_nat_edit.js
@@ -1,7 +1,6 @@
 <!--
 var portsenabled = 1;
 var dstenabled = 1;
-var showsource = 0;
 
 function ext_change() {
 	if ((document.iform.srcbeginport.selectedIndex == 0) && portsenabled) {
@@ -59,7 +58,6 @@ function show_source() {
 
 	document.getElementById("srctable").style.display = '';
 	document.getElementById("showadvancedboxsrc").style.display = 'none';
-	showsource = 1;
 }
 
 function check_for_aliases() {
@@ -119,7 +117,7 @@ function proto_change() {
 	}
 
 	if(document.iform.proto.selectedIndex >= 0 && document.iform.proto.selectedIndex <= 2) {
-		document.getElementById("sprtable").style.display = showsource == 1 ? '':'none';
+		document.getElementById("sprtable").style.display = portsenabled == 1 ? '':'none';
 		document.getElementById("dprtr").style.display = '';
 		document.getElementById("lprtr").style.display = '';
 	} else {