mirrors/pfsense
2
0
Fork 0
mirror of https://github.com/pfsense/pfsense.git synced 2025-10-26 11:38:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

interface_netgraph_needed can miss setting found equals true

Browse Source 
This routine seems to go looking to see if the passed-in interface is PPP-style. At the end, if it is not PPP-style then it calls pfsense_ngctl_detach.
This foreach loop in its current state will always exit after the first iteration that is not mode "server". But it looks like it should look through all the 'pppoe' entries until it finds the interface or gets to the end.
In theory the code will sometimes miss setting $found = true when it should have. And thus pfsense_ngctl_detach would get called later for a PPP-style interface.
I noticed this while reviewing for code style guide - it is an example where the indenting shows the intention but there are no curlies to implement it.
This commit is contained in:
Phil Davis 2015-02-25 23:06:32 +05:45 committed by Renato Botelho
parent 8cf108b224
commit 2798bb681f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
etc/inc/interfaces.inc
View File

@ -134,9 +134,10 @@ function interface_netgraph_needed($interface = "wan") {
foreach ($config['pppoes']['pppoe'] as $pppoe) {
if ($pppoe['mode'] != "server")
continue;
if ($pppoe['interface'] == $interface)
if ($pppoe['interface'] == $interface) {
$found = true;
break;
}
}
}
if ($found == false)