From 1beafceb73be3362da8d9d1c3f6e89c4dfc80607 Mon Sep 17 00:00:00 2001
From: Erik Fonnesbeck <efonnes@gmail.com>
Date: Thu, 5 Aug 2010 22:58:42 -0600
Subject: [PATCH] On system_advanced_firewall.php, fix display of selected TFTP
 interfaces after saving. Fixes #794

---
 usr/local/www/system_advanced_firewall.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/usr/local/www/system_advanced_firewall.php b/usr/local/www/system_advanced_firewall.php
index 370c47c76f..1fe923d928 100644
--- a/usr/local/www/system_advanced_firewall.php
+++ b/usr/local/www/system_advanced_firewall.php
@@ -64,7 +64,7 @@ else
 $pconfig['reflectiontimeout'] = $config['system']['reflectiontimeout'];
 $pconfig['bypassstaticroutes'] = isset($config['filter']['bypassstaticroutes']);
 $pconfig['disablescrub'] = isset($config['system']['disablescrub']);
-$pconfig['tftpinterface'] = $config['system']['tftpinterface']; 
+$pconfig['tftpinterface'] = explode(",", $config['system']['tftpinterface']);
 
 if ($_POST) {
 
@@ -355,7 +355,7 @@ function update_description(itemnum) {
 										$ifdescs = get_configured_interface_with_descr();
 										foreach ($ifdescs as $ifent => $ifdesc):
 ?>
-											<option value="<?=$ifent;?>" <?php if (stristr($pconfig['tftpinterface'], $ifent)) echo "selected"; ?>><?=gettext($ifdesc);?></option>
+											<option value="<?=$ifent;?>" <?php if (in_array($ifent, $pconfig['tftpinterface'])) echo "selected"; ?>><?=gettext($ifdesc);?></option>
 <?php									endforeach; ?>
 									</select>
 									<strong><?=gettext("Choose the interfaces where you want TFTP proxy helper to be enabled.");?></strong>