From 9f4722022f0e8114741e8cf1a421520fded8be1f Mon Sep 17 00:00:00 2001 From: NewEraCracker Date: Mon, 13 Jun 2016 21:28:56 +0100 Subject: [PATCH] Fix PHP Warning about invalid argument supplied for foreach If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions) --- src/usr/local/www/system_groupmanager.php | 8 +++++--- src/usr/local/www/system_usermanager.php | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/usr/local/www/system_groupmanager.php b/src/usr/local/www/system_groupmanager.php index 95100848d6..8e0d253992 100644 --- a/src/usr/local/www/system_groupmanager.php +++ b/src/usr/local/www/system_groupmanager.php @@ -193,9 +193,11 @@ if (isset($_POST['save'])) { } /* Check the POSTed members to ensure they are valid and exist */ - foreach ($_POST['members'] as $newmember) { - if (!is_numeric($newmember) || empty(getUserEntryByUID($newmember))) { - $input_errors[] = gettext("One or more invalid group members was submitted."); + if(is_array($_POST['members'])) { + foreach ($_POST['members'] as $newmember) { + if (!is_numeric($newmember) || empty(getUserEntryByUID($newmember))) { + $input_errors[] = gettext("One or more invalid group members was submitted."); + } } } diff --git a/src/usr/local/www/system_usermanager.php b/src/usr/local/www/system_usermanager.php index dd462d6cda..3e87a2514b 100644 --- a/src/usr/local/www/system_usermanager.php +++ b/src/usr/local/www/system_usermanager.php @@ -214,9 +214,11 @@ if ($_POST['save']) { } /* Check the POSTed groups to ensure they are valid and exist */ - foreach ($_POST['groups'] as $newgroup) { - if (empty(getGroupEntry($newgroup))) { - $input_errors[] = gettext("One or more invalid groups was submitted."); + if(is_array($_POST['groups'])) { + foreach ($_POST['groups'] as $newgroup) { + if (empty(getGroupEntry($newgroup))) { + $input_errors[] = gettext("One or more invalid groups was submitted."); + } } }