From 124ea6b8a75fe9791c4e005f2fe715289f40626e Mon Sep 17 00:00:00 2001 From: Chris Buechler Date: Wed, 26 Dec 2007 03:27:04 +0000 Subject: [PATCH] remove forced reboot, expand comment Ticket #1555 --- usr/local/www/interfaces_vlan_edit.php | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/usr/local/www/interfaces_vlan_edit.php b/usr/local/www/interfaces_vlan_edit.php index f4bf7421f4..3e94d75814 100755 --- a/usr/local/www/interfaces_vlan_edit.php +++ b/usr/local/www/interfaces_vlan_edit.php @@ -85,10 +85,19 @@ if ($_POST) { $a_vlans[] = $vlan; write_config(); - - touch($d_sysrebootreqd_path); - /* these appear to not work */ + /* TODO sometime post-1.2 release + this does not always work, some systems require + a reboot before VLANs function properly + + This portion of code is also very slow, this is why + it takes a long time to add a new VLAN. + Benchmark_Timer on a 800 MHz VIA: + interfaces_lan_configure() takes about 6 seconds + interfaces_wan_configure() takes about 9.5 seconds + interfaces_optional_configure() takes about 5 seconds + */ + interfaces_vlan_configure(); interfaces_lan_configure(); interfaces_wan_configure();