mirror of
https://github.com/indentlabs/notebook.git
synced 2025-10-26 11:19:22 +00:00
7dcf798f8a
Our application JS is bloated with minified libraries, while our actual application Javascript barely amounts to more than two hundred lines. I propose removing these libraries from our sass file, and instead load them as separate resources in `<link>` and `<script>` tags. This has several advantages: - By using common CDNs, users are likely to have many of these libraries cached already. - Even if the files aren't cached, the CDN is likely to deliver them faster. - We can use the HTML5 'async' attribute to load these libraries asynchronously, so users aren't held up while they download. - Our fully compiled application JS is much, much smaller, which reduces the load on our host. Also, on the topic of load times, I realized that in #152 that one of the images was a PNG, not a JPG. I had tried optimizing the image, but I didn't realize that it wasn't a JPG like the others. Here, I converted it to a JPG, and it is significantly smaller, and it is visually unchanged. I'm having some difficulty testing on my local machine, so I would appreciate some additional manual testing before merging this.
37 lines
1.1 KiB
Plaintext
37 lines
1.1 KiB
Plaintext
<!DOCTYPE html>
|
|
<html lang="en">
|
|
<head>
|
|
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/medium-editor/5.22.1/css/medium-editor.min.css" integrity="sha256-R45gjjgTM82XinRpA4xKOL00zJ2/ajOSjY3tvw5JaDM=" crossorigin="anonymous" />
|
|
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/medium-editor/5.22.1/css/themes/bootstrap.min.css" integrity="sha256-IAkbHl+TfLeobqAknNEdwDbXIW8A0Rj7GEftvOJa/LI=" crossorigin="anonymous" />
|
|
|
|
<%= render 'layouts/common_head' %>
|
|
|
|
<script async src="https://cdnjs.cloudflare.com/ajax/libs/medium-editor/5.22.1/js/medium-editor.min.js" integrity="sha256-Q35a6YaW9okg2cZSdp9fcxRE33VKe3rp1mX1uf1Q85M=" crossorigin="anonymous"></script>
|
|
</head>
|
|
<body>
|
|
|
|
<%= render 'layouts/navbar' %>
|
|
|
|
<main>
|
|
<div>
|
|
<div class="row">
|
|
<div class="col s12 m12">
|
|
<%= yield %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<%= render 'layouts/ganalytics' %>
|
|
|
|
<a href="https://plus.google.com/118076966717703203223" rel="publisher"></a>
|
|
</main>
|
|
|
|
<%= render 'layouts/footer' %>
|
|
|
|
<script type="text/javascript">
|
|
<%= yield :javascript %>
|
|
</script>
|
|
|
|
</body>
|
|
</html>
|