From d52f8b3893e5a98c97e53bf867fda1de7ee60cfc Mon Sep 17 00:00:00 2001 From: Andrew Brown Date: Fri, 2 Jul 2021 17:48:43 -0700 Subject: [PATCH] speed up document authorizer by skipping unnecessary queries --- app/authorizers/document_authorizer.rb | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/authorizers/document_authorizer.rb b/app/authorizers/document_authorizer.rb index f31274a2..6a72f1d9 100644 --- a/app/authorizers/document_authorizer.rb +++ b/app/authorizers/document_authorizer.rb @@ -4,13 +4,13 @@ class DocumentAuthorizer < ApplicationAuthorizer end def readable_by?(user) - [ - resource.user_id == user.id, - resource.privacy == 'public', - resource.universe.present? && resource.universe.privacy == 'public', - resource.universe.present? && resource.universe.contributors.pluck(:user_id).include?(user.id), - resource.universe.present? && resource.universe.user_id == user.id - ].any? + return true if resource.user_id == user.id + return true if resource.privacy == 'public' + return true if resource.universe.present? && resource.universe.privacy == 'public' + return true if resource.universe.present? && resource.universe.contributors.pluck(:user_id).include?(user.id) + return true if resource.universe.present? && resource.universe.user_id == user.id + + return false end def updatable_by?(user)