From 768e430a9b818d067abaa606b4c66f97ee0a0985 Mon Sep 17 00:00:00 2001 From: drusepth Date: Thu, 6 Oct 2022 19:24:26 -0700 Subject: [PATCH 1/5] fix potential 500 for local installs --- app/views/thredded/users/_badge.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/thredded/users/_badge.html.erb b/app/views/thredded/users/_badge.html.erb index ad3530da..5abdd866 100644 --- a/app/views/thredded/users/_badge.html.erb +++ b/app/views/thredded/users/_badge.html.erb @@ -15,7 +15,7 @@ <% if user.respond_to?(:selected_billing_plan_id) %> <% if user.id == 5 %> - <%= badge_text.presence + 'Admin' %> + <%= badge_text.presence || 'Admin' %> <% elsif user.selected_billing_plan_id == 2 %> <%= badge_text.presence || 'Beta Tester' %> <% elsif user.selected_billing_plan_id == 3 %> From d3c2bdaf4cc47db98d2a5e54f027aec69db37e9a Mon Sep 17 00:00:00 2001 From: drusepth Date: Thu, 6 Oct 2022 20:06:38 -0700 Subject: [PATCH 2/5] let the thredded nav breathe a little so extra icons don't overlap on mobile --- .../stylesheets/thredded-overrides.scss | 31 +++++++++++++++---- app/views/thredded/shared/_nav.html.erb | 26 ++++++++++++++++ 2 files changed, 51 insertions(+), 6 deletions(-) create mode 100644 app/views/thredded/shared/_nav.html.erb diff --git a/app/assets/stylesheets/thredded-overrides.scss b/app/assets/stylesheets/thredded-overrides.scss index 2213a875..9a5225bb 100644 --- a/app/assets/stylesheets/thredded-overrides.scss +++ b/app/assets/stylesheets/thredded-overrides.scss @@ -1,13 +1,17 @@ @import "thredded"; #thredded--container { - #q /* search input */ { - padding-left: 16px; - } + .thredded--navigation--search { + margin-top: 4.5em; - @media only screen and (min-width: 600px) { #q /* search input */ { - height: 19px; + padding-left: 16px; + } + + @media only screen and (min-width: 600px) { + #q /* search input */ { + height: 19px; + } } } @@ -15,18 +19,33 @@ margin-top: 0.4em; padding-left: 0.1em; overflow: hidden; - min-height: 5em; + min-height: 3em; max-height: 60px; + width: 100%; + + li { + display: inline !important; + float: left; + padding-right: 4px; + margin-right: 8px; + } + li a { padding: 0; line-height: 2rem; } } + .thredded--scoped-navigation { + left: 1rem; + top: 0.5rem; + } + .thredded--scoped-navigation li a { padding: 0; line-height: 2rem; + float: left; } .thredded--user-navigation { diff --git a/app/views/thredded/shared/_nav.html.erb b/app/views/thredded/shared/_nav.html.erb new file mode 100644 index 00000000..a660fbb3 --- /dev/null +++ b/app/views/thredded/shared/_nav.html.erb @@ -0,0 +1,26 @@ +<%= yield :thredded_breadcrumbs %> + + \ No newline at end of file From 05c569e531419c5291fdf6b8af5cd230bafafcf7 Mon Sep 17 00:00:00 2001 From: drusepth Date: Thu, 6 Oct 2022 20:43:20 -0700 Subject: [PATCH 3/5] minor padding tweak to mobile thredded nav --- app/assets/stylesheets/thredded-overrides.scss | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/assets/stylesheets/thredded-overrides.scss b/app/assets/stylesheets/thredded-overrides.scss index 9a5225bb..9f295bf5 100644 --- a/app/assets/stylesheets/thredded-overrides.scss +++ b/app/assets/stylesheets/thredded-overrides.scss @@ -39,7 +39,7 @@ .thredded--scoped-navigation { left: 1rem; - top: 0.5rem; + top: 1rem; } .thredded--scoped-navigation li a { @@ -53,6 +53,13 @@ margin: 1rem; border-bottom: 0; + @media only screen and (max-width: 600px) { + .thredded--user-navigation--item { + padding-top: 0.5rem; + padding-right: 0.5rem; + } + } + .thredded--user-navigation--item a { padding: 8px 4px; line-height: 2rem; From 11e0904df9de2ad05c797fd42012c21e2dea46bb Mon Sep 17 00:00:00 2001 From: drusepth Date: Thu, 6 Oct 2022 21:18:02 -0700 Subject: [PATCH 4/5] oof css is hard --- app/assets/stylesheets/thredded-overrides.scss | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/assets/stylesheets/thredded-overrides.scss b/app/assets/stylesheets/thredded-overrides.scss index 9f295bf5..ffa737ca 100644 --- a/app/assets/stylesheets/thredded-overrides.scss +++ b/app/assets/stylesheets/thredded-overrides.scss @@ -22,8 +22,6 @@ min-height: 3em; max-height: 60px; - width: 100%; - li { display: inline !important; float: left; From fabd4c51c02c906ad0b7de92d4052c141dd528bb Mon Sep 17 00:00:00 2001 From: drusepth Date: Thu, 6 Oct 2022 21:24:40 -0700 Subject: [PATCH 5/5] add this tweak --- app/assets/stylesheets/thredded-overrides.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/assets/stylesheets/thredded-overrides.scss b/app/assets/stylesheets/thredded-overrides.scss index ffa737ca..d49e36f6 100644 --- a/app/assets/stylesheets/thredded-overrides.scss +++ b/app/assets/stylesheets/thredded-overrides.scss @@ -22,6 +22,8 @@ min-height: 3em; max-height: 60px; + width: 50%; + li { display: inline !important; float: left;