mirror of
https://github.com/nextcloud/server.git
synced 2025-10-26 19:21:34 +00:00
bcfe8431b4
The jQuery File Upload plugin triggers the "stop" event once there are no more files being uploaded (even if some of them were added when another upload was already in progress). Therefore, the progress bar should be hidden in the "fileuploadstop" callback. In some cases the "stop" event is not triggered and thus the progress bar is not hidden once no more files are being uploaded. This is caused by a race condition and it will be fixed in another commit; except in buggy cases like that one (that need to be fixed anyway) it is safe to hide the progress bar in the "fileuploadstop" callback. In any case, note that the callbacks in "fileuploaddone" may be called after the "stop" event was triggered and handled when using chunked uploads. In that case once all the chunks are uploaded the assembled file is moved to its final destination, so its promise could be resolved after the "stop" event was triggered. Therefore a different approach would be needed to keep the progress bar visible until the chunked upload is truly finished, but for the time being the current one is good enough. Before this commit the progress bar was being hidden when the first upload finished, either successfully or with an error, no matter if there were other files being uploaded too. The progress bar was being explicitly hidden also when the upload was cancelled. When an upload is cancelled all the single uploads are aborted, which triggers a "fail" event for each of them. However, the "stop" event is always triggered when no more files are being uploaded, so it is triggered too once all the single uploads were aborted. As all the single uploads are immediately aborted in a loop when the general upload is cancelled it makes no difference to hide the progress bar when the first single upload is aborted or when all the single uploads were aborted, so the progress bar is no longer explicitly hidden in the former case. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com> |
||
|---|---|---|
| .. | ||
| templates | ||
| admin.js | ||
| app.js | ||
| breadcrumb.js | ||
| detailfileinfoview.js | ||
| detailsview.js | ||
| detailtabview.js | ||
| favoritesfilelist.js | ||
| favoritesplugin.js | ||
| file-upload.js | ||
| fileactions.js | ||
| fileactionsmenu.js | ||
| fileinfomodel.js | ||
| filelist.js | ||
| files.js | ||
| filesummary.js | ||
| gotoplugin.js | ||
| jquery-visibility.js | ||
| jquery.fileupload.js | ||
| keyboardshortcuts.js | ||
| mainfileinfodetailview.js | ||
| merged-index.json | ||
| navigation.js | ||
| newfilemenu.js | ||
| recentfilelist.js | ||
| recentplugin.js | ||
| search.js | ||
| sidebarpreviewmanager.js | ||
| sidebarpreviewtext.js | ||
| tagsplugin.js | ||
| upload.js | ||