Commit Graph

67112 Commits

Author SHA1 Message Date
Julius Härtl
d9c81f56ad tests: Adapt node related unit tests mocks to required root view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +02:00
Julius Härtl
160bd75d0a fix: Use proper path when creating node instances
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +02:00
Simon L
85c9e75f33
Merge pull request #32314 from nextcloud/object-mkdir-logging
additional logging when mkdir fails for object storage
2023-04-17 23:42:08 +02:00
Alexander A. Klimov
ff02b072ae Drop broken unit test
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
2023-04-17 23:38:29 +02:00
Alexander A. Klimov
e3f1fae715 Omit "Accessing site insecurely via HTTP." warning if HTTP is secure enough
This is the case for localhost and Tor hidden services.

Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
2023-04-17 23:38:29 +02:00
Simon L
5cda8f0f45
Merge pull request #35129 from Glandos/previewperf2
[Performance] Reuse preview directory listing
2023-04-17 20:22:39 +02:00
Simon L
d87cc208bb
Merge pull request #31286 from rotdrop/bugfix/dont-start-session-when-session-is-already-open
Don't call session_start() when PHP session is still or already open.
2023-04-17 20:14:53 +02:00
Simon L
1ef23e7708 Allow images of any size as profile pictures
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-04-17 17:18:00 +00:00
Ferdinand Thiessen
dc9d8c42bb fix: Adjust console formatter code to match with Symfony type hints
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 18:35:10 +02:00
Ferdinand Thiessen
698332e81d chore: Update PSR container to 2.0.2, matching 3rdparty nextcloud/3rdparty#1311
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 18:35:08 +02:00
Thomas Citharel
ff3b69b21d refactor(dav): Since we're in a transaction, use QB properly when incrementing synctoken
Now that we're in a transaction, we can reuse the sync token's previous value without trouble, and rewrite the increment UPDATE query without dirty direct SQL.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-04-17 16:08:44 +00:00
Thomas Citharel
c9a3129cb4 fix(CalDAV/CardDAV): put every method from Cal/CardDAV backends that does multiple DB calls in transactions
In a lot of methods we're doing read-after-writes (for instance calling
updateProperties after touching calendar objects).
There's also a lot of deleting methods that do stuff sequentially which
could cause trouble.
This should avoid this kind of issues.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-04-17 16:08:44 +00:00
Christoph Wurst
a06898a2d0 fix(security)!: Use consistent HTTP status for strict cookie checks
Before: 503/412
Now: 412 + json body explaining the error

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-17 16:06:37 +00:00
Robin Appelman
30b7147a31 update icewind/smb to 3.5.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:06:17 +00:00
Robin Appelman
85a879894f update icewind/smb to 3.5.3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:06:17 +00:00
Ferdinand Thiessen
bdbff2181e fix: Allow to catch IMapperException by implementing Throwable
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 16:05:10 +00:00
Simon L
c4ab4018cf l10n: Change to a capital letter
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-04-17 16:03:25 +00:00
Christoph Wurst
b952066140
Merge pull request #37724 from nextcloud/fix/encryption-signature-check-logic
Cleanup signature checking logic in encryption
2023-04-17 17:39:34 +02:00
Simon L
800f40b71c fix php-lint
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 17:18:09 +02:00
Simon L
54b5703233
Merge pull request #35744 from nextcloud/mimeloader-transaction
Put Mimeloader insertion and read in the same transaction
2023-04-17 16:58:36 +02:00
Glandos
e542e60dbc try to make linters happy
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:14 +02:00
Glandos
3440387f0f gather code from small and max preview
use directory listing in both functions to gain 25% speed on run where
every preview already exist.

Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +02:00
Glandos
384a1d34a8 adapt test to new workflow
getDirectoryListing should return all files
getFile is not called anymore

Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +02:00
Glandos
24c121347a Revert 0e49b40
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +02:00
Glandos
06a7e90383 improve parameter doc
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +02:00
Glandos
4954bead1d Ensure max preview image is not null
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +02:00
Glandos
b6c65fee2a php-cs-fix
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +02:00
Glandos
9b4d5146d5 List preview directory only once
getCachedPreview used to call `getFile`, and this calls `getDirectoryListing` (or underlying function that list directory) to find the file. This was done for every preview spec.
Now, this is done only once at the beginning of the loop, and the array is just iterated when needed to find the correct entry.

Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +02:00
Claus-Justus Heine
45ec432492 Don't call session_start() when PHP session is still or already open.
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2023-04-17 16:23:02 +02:00
Claus-Justus Heine
456679c6fb Update lib/private/Preview/Bundled.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2023-04-17 16:19:02 +02:00
Claus-Justus Heine
b3d8363327 Prevent the OpenDocument preview generator from trying to open empty files.
Rationale: does not make sense, and triggers a deprecation error in
\ZipArchive.

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2023-04-17 16:19:02 +02:00
Simon L
e63720b714
Merge pull request #36217 from nextcloud/handle-push-notification-with-no-calendar-name
Handle reminders where calendar name is null
2023-04-17 15:43:21 +02:00
Louis
ed2b28b60d
Merge pull request #37764 from nextcloud/artonge/fix/disable_versions_feature_s3_versioning
Really disable versions features when S3 versioning is enabled
2023-04-17 15:32:47 +02:00
Thomas Citharel
036cd47bf4 Put Mimeloader insertion and read in the same transaction
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-04-17 13:32:02 +00:00
Simon L
bdb09abd1a
Merge pull request #36845 from Murena-SAS/reminder-iterator-exception
Fix max instances exception in get vevent call
2023-04-17 15:26:11 +02:00
Simon L
80645a591a add an admin check for db file locking
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 12:51:33 +02:00
Jérôme Herbinet
9a3d88f1e9 Fix wording meaning (placeholder)
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-04-17 09:18:10 +00:00
Louis Chemineau
cca46f18eb Really disable versions features when S3 versioning is enabled
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-17 11:16:20 +02:00
Joas Schilling
b21c5c86e5
Merge pull request #37735 from nextcloud/techdebt/ref-37476/ignore-excluded-dirs-on-image-optimization
chore(assets): Ignore git-ignored directories on image optimization
2023-04-17 10:25:24 +02:00
Nextcloud bot
a5348bc400
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-17 02:27:34 +00:00
Nextcloud bot
857961c9e7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-16 02:27:54 +00:00
John Molakvoæ
1078fa74c2
Merge pull request #37752 from nextcloud/automated/noid/master-update-psalm-baseline
[master] Update psalm-baseline.xml
2023-04-15 17:03:42 +02:00
dependabot[bot]
83c2105440
Merge pull request #37750 from nextcloud/dependabot/npm_and_yarn/webpack-5.79.0 2023-04-15 13:58:24 +00:00
dependabot[bot]
5aab2bb41d
Bump @nextcloud/browser-storage from 0.1.1 to 0.2.0
Bumps [@nextcloud/browser-storage](https://github.com/nextcloud/nextcloud-browser-storage) from 0.1.1 to 0.2.0.
- [Release notes](https://github.com/nextcloud/nextcloud-browser-storage/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-browser-storage/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-browser-storage/compare/v0.1.1...v0.2.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/browser-storage"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-15 15:15:03 +02:00
dependabot[bot]
7b5fc87daf
bump webpack from 5.78.0 to 5.79.0
---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-15 15:10:56 +02:00
John Molakvoæ
f89ce6ac7c
Merge pull request #37400 from nextcloud/dependabot/npm_and_yarn/nextcloud/calendar-availability-vue-0.6.0-alpha1 2023-04-15 14:53:51 +02:00
dependabot[bot]
a8b26f0093 chore(deps): Bump @nextcloud/calendar-availability-vue
Bumps [@nextcloud/calendar-availability-vue](https://github.com/nextcloud/calendar-availability-vue) from 0.5.0-rc2 to 0.6.0-alpha1.
- [Release notes](https://github.com/nextcloud/calendar-availability-vue/releases)
- [Changelog](https://github.com/nextcloud/calendar-availability-vue/blob/main/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/calendar-availability-vue/compare/v0.5.0-rc2...v0.6.0-alpha1)

---
updated-dependencies:
- dependency-name: "@nextcloud/calendar-availability-vue"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-04-15 08:35:22 +00:00
John Molakvoæ
d405be2536
Merge pull request #37751 from nextcloud/dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-5.58.0
bump @typescript-eslint/eslint-plugin from 5.45.0 to 5.58.0
2023-04-15 09:03:11 +02:00
John Molakvoæ
05edc2fc19
Merge pull request #37749 from nextcloud/dependabot/composer/build/integration/phpunit/phpunit-9.6.7
chore(deps-dev): Bump phpunit/phpunit from 9.6.6 to 9.6.7 in /build/integration
2023-04-15 09:02:43 +02:00
John Molakvoæ
606d90eecf
Merge pull request #37747 from nextcloud/dependabot/npm_and_yarn/vue/vue2-jest-29.2.3
chore(deps-dev): Bump @vue/vue2-jest from 29.1.1 to 29.2.3
2023-04-15 09:02:20 +02:00