6347 Commits

Author	SHA1	Message	Date
Julius Härtl	37591f05dc	Get the parent directory before creating a file from a template ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2021-04-01 13:48:21 +02:00
Joas Schilling	f9d4fa2d38	Rename the method to match what it does ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-03-31 10:21:18 +02:00
Joas Schilling	3696ef5b96	Don't allow Notnull for boolean columns ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-03-31 10:21:17 +02:00
kesselb	2212a67fbc	Merge pull request #25961 from nextcloud/enh/events/2fa_provider ... Add real events for enabled 2fa providers for users	2021-03-30 23:13:36 +02:00
Roeland Jago Douma	f3738eeff7	Merge pull request #25280 from nextcloud/explicit-file-permissions ... Set umask before operations that create local files	2021-03-30 21:55:50 +02:00
Arthur Schiwon	be3ae9a44b	gracefully handle deleteFromSelf when share is already gone ... - handling race conditions Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2021-03-30 12:59:40 +02:00
Daniel Calviño Sánchez	f216b9307a	Update Mink from 1.7.1 to 1.8.1 in acceptance tests ... Since version 1.8.0 of Mink "Mink::getSession()" no longer starts the session automatically (see https://github.com/minkphp/Mink/pull/705), so it now needs to be explicitly started. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-30 08:35:16 +02:00
Daniel Calviño Sánchez	7625a87412	Update Selenium driver for Mink from 1.3.1 to 1.4.0 in acceptance tests ... Since version 1.4.0 the Selenium driver for Mink uses again the element on which the value was set (see https://github.com/minkphp/MinkSelenium2Driver/pull/286). When creating a new folder or renaming one sending a new line ("\r") caused the element on which the value was set to be removed, so the element was no longer attached to the DOM when the driver tried to use it again, and thus a "StaleElementReference" exception was thrown. Due to this now it is needed to explicitly click the confirm button when creating a new folder. In the case of the renaming, on the other hand, nothing else besides not sending the new line is needed, as the Selenium driver now unfocuses the element (that is why it uses again the element after setting the value) which triggers the renaming. Besides that, the Selenium driver for Mink uses a library to simulate certain events, bitovi/syn. In version 1.4.0 that library was updated to version 0.0.3, which seems to somehow break pressing the "escape" key. Due to this now the sharing menu has to be closed by pressing "enter" on the share menu button instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-30 08:35:16 +02:00
Daniel Calviño Sánchez	223b36e851	Update Behat from 3.7.0 to 3.8.1 in acceptance tests ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-30 08:35:16 +02:00
Daniel Calviño Sánchez	b53f49b940	Update PHPUnit from 4.X to 6.X in acceptance tests ... The PHPUnit update also required an update of "symfony/yaml", so besides the changes needed for PHPUnit the "behat.yml" file also had to be adjusted. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-30 08:35:15 +02:00
Joas Schilling	8d3fdf24c8	Merge pull request #26353 from nextcloud/techdebt/noid/make-testcase-class-compatible-with-phpunit-9.5 ... Make Testcase class compatible with phpunit-9.5	2021-03-29 10:47:37 +02:00
Joas Schilling	cd35a5c71d	Make Testcase class compatible with phpunit-9.5 ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-03-29 09:43:08 +02:00
J0WI	d58d6199d9	Cleaner normalizePath regex ... Signed-off-by: J0WI <J0WI@users.noreply.github.com>	2021-03-27 21:29:28 +01:00
J0WI	5f468c0248	Cleaner removePassword regex ... Signed-off-by: J0WI <J0WI@users.noreply.github.com>	2021-03-27 18:42:58 +01:00
Vincent Petry	cc54f718f5	Add known user check in avatar when v2-private scope ... Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-26 13:07:10 +01:00
Vincent Petry	bb008be28a	Added PlaceholderAvatar with own cached images ... When avatar scope is private, the PlaceholderAvatar is used to deliver a placeholder avatar based on the user's initials. This was implemented as a separate class for now to avoid messing with the existing UserAvatar implementation and its generated vs non-generated logic. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-26 13:07:09 +01:00
Vincent Petry	b73df5846c	Add property scope tests for AccountManager ... Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-26 13:07:09 +01:00
Vincent Petry	278a73789e	Map old account scope properties to new names ... Use new scope values in settings page. Adjust all consumers to use the new constants. Map old scope values to new ones in account property getter. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-26 13:07:08 +01:00
Vincent Petry	b81a1c1bdb	Add new v2-private account scope ... Added new v2-private account manager scope that restricts the scope further by excluding public link access. Avatars with v2-private account scope are now showing the guest avatar instead of the real avatar. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-26 13:07:05 +01:00
Roeland Jago Douma	9fd29173cf	Merge pull request #26281 from hosting-de/fix/email ... Change my email address	2021-03-26 09:59:35 +01:00
Morris Jobke	ab48d5e8cb	Cleanup unneeded code around database.xml ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2021-03-24 22:15:44 +01:00
Johannes Leuker	e9ca59ef0a	Change my email address ... Signed-off-by: Johannes Leuker <j.leuker@hosting.de>	2021-03-24 15:13:56 +01:00
Vincent Petry	39a6d99526	Fix language codes test result order ... Fixes issue with Oracle by enforcing the order of the results to check. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-24 10:26:06 +01:00
Vincent Petry	8b92776be4	Bring back forgotten tests ... Remove "ocs-provider" test folder reference as it doesn't exist any more. Added back "Test" test subdir and fixed the tests inside. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-24 09:07:54 +01:00
Vincent Petry	95e03fba2d	Fix more controller tests in Core subdir ... Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-24 09:02:19 +01:00
Vincent Petry	9b8ca1697a	Fix more tests in the Core subdir ... Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-24 08:48:28 +01:00
Vincent Petry	c467f64848	Fix core tests command for app enabling/disabling ... Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-23 20:40:28 +01:00
Vincent Petry	e210e8e35a	Fix casing of core test folder ... It seems Phpunit < 9 was case insensitive. Fixed the phpunit config to target the correct name for the "Core" test directory. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-23 18:12:46 +01:00
Robin Appelman	e5dc1a8085	Set umask before operations that create local files ... this solves issues where "other php stuff" is messing with the umask Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-03-23 14:52:31 +01:00
Morris Jobke	1c074e7602	Merge pull request #26198 from nextcloud/unified-search-node ... Handle limit offset and sorting in files search	2021-03-22 21:48:51 +01:00
Morris Jobke	268acd301d	Merge pull request #25529 from nextcloud/fix-non-lgc-glyphs-in-avatars-and-txt-file-previews ... Fix non LGC glyphs in avatars and txt file previews	2021-03-22 21:06:22 +01:00
Roeland Jago Douma	3c5cf825b3	Add real events for enabled 2fa providers for users ... * Shiny new events * Listener to still emit the old event Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2021-03-22 20:57:10 +01:00
John Molakvoæ (skjnldsv)	15767643f2	Fix sharebymail tests ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	2021-03-22 06:50:47 +01:00
Daniel Calviño Sánchez	f99876997a	Remove duplicated query for email shares ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>	2021-03-22 06:50:47 +01:00
Robin Appelman	bfe3712372	handle ordering in folder search ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-03-19 16:07:54 +01:00
Julius Härtl	76170a58eb	Log and continue when failing to update encryption keys during for individual files ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2021-03-19 14:12:07 +01:00
Robin Appelman	feed42dd6d	folder filtering in sql ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-03-19 13:41:00 +01:00
Roeland Jago Douma	1286848731	Merge pull request #23718 from nextcloud/already-shared-error-message ... expand 'path is already shared' error message	2021-03-19 13:39:22 +01:00
Robin Appelman	de713967c0	cleanup fileinfo creation ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-03-19 13:35:37 +01:00
Vincent Petry	7bf5adb1fa	Merge pull request #26200 from nextcloud/bugfix/26197/fix-expiration-validation-confusion ... Update user share must use correct expiration validation	2021-03-19 10:51:21 +01:00
Robin Appelman	bd229e7548	handle limit and offset in folder file search ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-03-18 17:38:31 +01:00
Robin Appelman	50e374c12f	only require user to be set in a query that handles tags ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-03-18 17:16:28 +01:00
Vincent Petry	a9e3d2a10f	Update user share must use correct expiration validation ... Updating a user or group share now uses the correct method for the validation of the expiration date. Instead of using the one from links it uses the one for internal shares. To avoid future confusion, the method "validateExpirationDate" has been renamed to "validateExpirationDateLink". Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2021-03-18 17:12:28 +01:00
Robin Appelman	9e3775618b	log full expection during repair step ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-03-18 08:45:17 +01:00
Julius Härtl	a2f3077ee8	Skip db migration simulation for core schema changes ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2021-03-17 21:08:22 +01:00
Joas Schilling	0d46fafd41	Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches ... Improve search results when only phonebook-matches can we autocompleted	2021-03-17 15:22:03 +01:00
Joas Schilling	cf434d5107	Also limit to user group in case enumeration is enabled for groups and phonenumbers ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-03-17 11:20:30 +01:00
Joas Schilling	9a189bc710	Improve search results when only phonebook-matches can we autocompleted ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-03-17 09:51:31 +01:00
Vincent Petry	e559afb8d4	Merge pull request #25136 from nextcloud/cachejail-search-filter ... do cachejail search filtering in sql	2021-03-15 17:45:30 +01:00
Robin Appelman	a550649708	expand 'path is already shared' error message ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-03-15 15:55:08 +01:00
Robin Appelman	32551b9ff7	Merge pull request #25722 from nextcloud/objectstore-copy-cross ... apply object store copy optimization when 'cross storage' copy is wit…	2021-03-12 16:10:18 +00:00
Joas Schilling	a609074c18	Fix Test class name ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-03-12 08:53:43 +01:00
Joas Schilling	cf8f9c16df	Change label also in the acceptance tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-03-10 18:55:01 +01:00
Joas Schilling	5b53b6f977	Add a setting to restrict returning a full match unless in phonebook or same group ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-03-10 17:25:57 +01:00
Joas Schilling	236aa194e2	Restrict autocompletion also based on the phonebook known users ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-03-10 17:19:55 +01:00
Robin Appelman	c87b1a50d9	apply object store copy optimization when 'cross storage' copy is within the same object store ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-03-09 20:31:27 +01:00
Roeland Jago Douma	30e096f3f5	Allow overwriting isAuthenticated ... * Some implementations might check for different things * IT will not change how the current ones work Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2021-03-09 09:17:30 +01:00
kesselb	2ddf3c9df0	Merge pull request #25990 from nextcloud/do-not-try-to-add-an-existing-user-again-in-acceptance-tests ... Do not try to add an existing user again in acceptance tests	2021-03-08 10:18:46 +01:00
Roeland Jago Douma	615721df82	Merge pull request #25925 from nextcloud/techdept/psalm/ActionProviderStore ... Pimp ActionProviderStore	2021-03-08 09:20:45 +01:00
Daniel Calviño Sánchez	c51c3c771f	Remove unneeded steps to add already existing user ... User "user1" is added when installing and configuring the server, so it is already added in all tests. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-07 18:34:10 +01:00
Daniel Calviño Sánchez	0e6401933b	Fix acceptance test for searching just added users in contacts menu ... User "user1" is added when installing and configuring the server, so it is already added in all tests. As the test verifies that just added users can be searched in the contacts menu a new user should be actually added. The test did not fail because it assumed that "user1" did not exist and just checked that it existed after "adding" it, but not whether adding it failed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-07 18:27:45 +01:00
Daniel Calviño Sánchez	ee1f8104a0	Find directly the label instead of falling back to it ... The input element is always hidden, so the check always ended falling back to the label. Moreover, the label is the element that the user interacts with, so it must be the one used. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-06 01:34:43 +01:00
Daniel Calviño Sánchez	7b6946d2d2	Assert also element visibility instead of just finding it ... Although if the element could not be found an exception would be thrown and the test aborted if an element is in the DOM but hidden it would be found and the test would pass. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-06 01:34:43 +01:00
Daniel Calviño Sánchez	78faf0105d	Add explicit locator for "Enable all" bundle button ... Instead of looking for the bundle button and then checking its value now the expected value is included in the locator and the button is checked similarly to other elements. No "Disable all" locator was added as it was not currently needed anywhere. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-06 01:34:43 +01:00
Daniel Calviño Sánchez	f87473e410	Find elements through the actor rather than the driver ... "Actor::find" is a more robust way to look for elements, as it handles some exceptions that may be thrown. Therefore, even if the elements are not actually used and it is only checked whether they exist or not using the actor is the preferred way when possible (and it also makes it consistent with the rest of the acceptance tests). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-06 01:34:43 +01:00
Daniel Calviño Sánchez	6d145ea54a	Add locator for apps list ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-06 01:34:42 +01:00
Daniel Calviño Sánchez	4c23d24277	Fix identation ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-06 01:34:42 +01:00
Daniel Calviño Sánchez	bc084070c8	Fix delete user acceptance test ... Adding some missing asserts showed that the "delete user" acceptance test was silently failing, as the deletion was not being confirmed in the dialog and thus the user was not being deleted. The dialog button contains a single quote ("user0's"), so the XPath expression had to be adjusted (it seems that it is not possible to escape a single quote in a string enclosed in single quotes in XPath 1.0). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-06 01:29:54 +01:00
Daniel Calviño Sánchez	d5586ec437	Verify WaitFor::element... results with an assertion ... WaitFor::element... calls only perform the waiting and return whether the condition succeeded or not, but that result needs to be explicitly checked to prevent further steps from being executed if the wait failed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-05 22:06:05 +01:00
Daniel Calviño Sánchez	caa2246568	Add missing waits when finding elements in the acceptance tests ... As no timeout was specified the elements were tried to be found just once. This caused the steps to fail if the elements did not appear yet in the page when they were tried to be found. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-05 22:06:05 +01:00
Roeland Jago Douma	54cffefed4	Merge pull request #25660 from hosting-de/feature/add-backend-list-groups ... Show group backends in occ group:list --info and group:info	2021-03-05 08:49:43 +01:00
Roeland Jago Douma	f04a2ce19f	Pimp ActionProviderStore ... * Fix paradoxale condition * Add types * Move away from ILogger Makes psalm happy, and thus me happy Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2021-03-04 12:29:49 +01:00
Roeland Jago Douma	7b9ca4f7c2	Add some typing to SharedStorage ... Makes psalm a bit more happy. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2021-03-04 10:49:42 +01:00
Roeland Jago Douma	5325c3002c	Merge pull request #25917 from nextcloud/techdept/kill_deprecated/ocp_api ... Remove deprecated \OCP\API	2021-03-03 21:57:34 +01:00
Roeland Jago Douma	cc744740b7	Remove deprecated \OCP\API ... Time to remove this forgood now. Remaining constant moved over The world is a tiny bit better Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2021-03-03 20:54:32 +01:00
Roeland Jago Douma	68ec18323d	Fix types in the Group Manager ... Psalm found an issue. However the issue found was because of lying docblocks. Fixed those and did some typing to make it all better. For #25839 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2021-03-03 14:52:47 +01:00
Daniel Calviño Sánchez	ee06780029	Include additional scripts in Noto fonts ... Generated avatars as well as text file previews are rendered using the "core/fonts/NotoSans-Regular.ttf" font. The file was the standard hinted "NotoSans-Regular.ttf" file from https://www.google.com/get/noto/. However that file does not cover some non LGC (Latin, Greek, Cyrillic) scripts, like Arabic, Devanagari or Hebrew, to name a few. Markdown file previews also use "core/fonts/NotoSans-Bold.ttf", which is in the same situation as the regular one. Due to limitations in the TTF format it is not possible to provide a single file for each style that includes all Noto fonts. However, it is possible to add more scripts to the standard "NotoSans-Regular.ttf" and "NotoSans-Bold.ttf" files (although no CJK (Chinese, Japanese, Korean) glyph can be included due to the aforementioned limitations). This commit replaces the standard files with an extended version created using the Noto Tools. The build script (as well as a patch for the Noto Tools) is also included for reference and to be able to update the font files in the future if needed. Due to the additional scripts added the font files are now much larger, although this does not seem to increase the time spent rendering LGC scripts. Note that the file for the bold style still contains less scripts than the regular one, as not all scripts supported by Noto have a bold weight. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-03-01 19:15:01 +01:00
Johannes Leuker	2796ef80ff	Show group backends in occ group:list --info and group:info ... Signed-off-by: Johannes Leuker <j.leuker@hosting.de>	2021-03-01 16:02:08 +01:00
Christoph Wurst	5026d2cca1	Merge pull request #25086 from nextcloud/dependabot/composer/nextcloud/coding-standard-0.5.0 ... Bump nextcloud/coding-standard from 0.3.0 to 0.5.0	2021-02-18 14:05:54 +01:00
dependabot-preview[bot]	eb502c02ff	Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 ... Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-02-18 13:31:24 +01:00
Joas Schilling	6ed4aaeeea	Send emails on password reset to the displayname ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-02-18 12:38:43 +01:00
Roeland Jago Douma	644e6df02e	Merge pull request #25440 from nextcloud/bugfix/noid/cache-the-user-backend-info-for-30s ... Cache the user backend info for 5mins	2021-02-17 08:56:55 +01:00
Christoph Wurst	b794fadbce	Merge pull request #25575 from k00ni/pr/add-tests-for-LoginFlowV2Service ... Add tests for \OC\Core\Service\LoginFlowV2Service	2021-02-15 12:22:39 +01:00
Joas Schilling	645f83121e	Cache the user backend info for 300s ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-02-15 10:36:08 +01:00
Roeland Jago Douma	24d4c3eeab	Merge pull request #25577 from nextcloud/enhancement/app-code-checker-noop ... Make the app code checker a NOOP	2021-02-13 15:51:41 +01:00
Konrad Abicht	330315f03e	refined name of getOpenSSLEncryptedAndPrivateKey ... Signed-off-by: Konrad Abicht <hi@inspirito.de>	2021-02-12 13:01:37 +01:00
Konrad Abicht	0bc49d67cd	added unit tests for LoginFlowV2Service::createTokens ... Signed-off-by: Konrad Abicht <hi@inspirito.de>	2021-02-12 12:57:24 +01:00
Christoph Wurst	883848b58a	Micro-optimize validation of empty email addresses ... Then we don't have to construct any validators. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-02-11 15:15:38 +01:00
Christoph Wurst	e618ea83b5	Make the app code checker a NOOP ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-02-11 11:46:02 +01:00
Konrad Abicht	c755165dd4	added unit tests for LoginFlowV2Service::flowDone ... Signed-off-by: Konrad Abicht <hi@inspirito.de>	2021-02-11 10:45:47 +01:00
Roeland Jago Douma	d5dea10517	Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements ... Improve mention matches	2021-02-11 10:33:15 +01:00
Konrad Abicht	d60dd8a208	added unit tests for LoginFlowV2Service::startLoginFlow ... Signed-off-by: Konrad Abicht <hi@inspirito.de>	2021-02-11 09:56:09 +01:00
Konrad Abicht	f29748a5e1	added unit tests for LoginFlowV2Service::getByLoginToken ... Signed-off-by: Konrad Abicht <hi@inspirito.de>	2021-02-11 09:49:39 +01:00
Konrad Abicht	b0a2278a7e	added unit tests for LoginFlowV2Service::poll ... Signed-off-by: Konrad Abicht <hi@inspirito.de>	2021-02-11 09:38:29 +01:00
Roeland Jago Douma	7bacd710a1	Merge pull request #25460 from nextcloud/fix/apppassword/always_renew ... Always renew apppasswords on login	2021-02-10 21:09:20 +01:00
Roeland Jago Douma	cd457cc68b	Always renew apppasswords on login ... Else you can end up that you renewed your password (LDAP for example). But they still don't work because you did not use them before you logged in. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2021-02-10 19:02:37 +01:00
Christoph Wurst	2f26ff40e9	Merge pull request #25359 from nextcloud/enhancement/typed-service-registration ... Type the service registration	2021-02-10 15:31:42 +01:00
Christoph Wurst	aabd73912e	Type the service registration ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-02-10 09:44:24 +01:00
Christoph Wurst	e4ca0c9fa0	Merge pull request #25548 from k00ni/pr/add-tests-for-LoginFlowV2Credentials ... Added tests for OC\Core\Data\LoginFlowV2Credentials	2021-02-09 21:37:37 +01:00
Konrad Abicht	a50c615d37	simplified tests ... Signed-off-by: Konrad Abicht <hi@inspirito.de>	2021-02-09 15:48:37 +01:00
Konrad Abicht	a28705064b	fixed coding style issue ... Signed-off-by: Konrad Abicht <hi@inspirito.de>	2021-02-09 15:40:19 +01:00
Konrad Abicht	b38a619212	added tests for OC\Core\Data\LoginFlowV2Credentials ... Signed-off-by: Konrad Abicht <hi@inspirito.de>	2021-02-09 15:25:37 +01:00
Christoph Wurst	abc61a9f63	Fix the legacy dispatcher argument order ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-02-09 10:47:14 +01:00
Joas Schilling	86109f77e0	Fix unit tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-02-06 13:07:06 +01:00
Christoph Wurst	f6ddda8dad	Test the symfony adapter ... To prevent regression in the future. And make sure we always return an object … Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-02-05 12:14:47 +01:00
Daniel Kesselberg	b68c3a5836	Add test for dbal exception wrapping ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2021-02-03 19:43:52 +01:00
Arthur Schiwon	d4a45b4cac	test: adjust expectation ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2021-01-29 19:32:12 +01:00
Arthur Schiwon	558f062ca6	add repair job for unencoded calendars ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2021-01-29 17:29:10 +01:00
Christoph Wurst	7d9dceb1af	Add negative version comparison test for version suffixes ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-01-27 16:01:26 +01:00
Christoph Wurst	b4f71ccf4d	Fix app fetcher php comparison to allow wider ranges ... When app app specifies php 7.4 as upper limit we have to allow the installation on php>7.4.0. The previous version check didn't do that. This adjusts the regexes to discard any irrelevant suffix after the three version numbers so that we can use more fine granular checks than php's version_compare can do out of the box, like for php 7.4 we only compare the major and minor version numbers and ignore the patch level. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-01-26 16:35:43 +01:00
Robin Appelman	e511a539b7	adjust tests ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-01-26 15:55:38 +01:00
Robin Appelman	5ae0be08b4	fix search in nested jails ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-01-26 15:30:54 +01:00
Robin Appelman	27f9df2e87	fix cachjail searching for root ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-01-26 15:30:50 +01:00
Robin Appelman	a44aab11f7	do cachejail search filtering in sql ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2021-01-26 15:30:46 +01:00
Christoph Wurst	99d525eb36	Convert 2FA token type to string ... The IConfig service is documented to handle its data as strings, hence this changes the code a bit to ensure we store keys as string and convert them back when reading. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-01-22 14:09:37 +01:00
Morris Jobke	d84e1f1951	Re-use fetched dependencies in lib/base.php ... Reduces calls to DI container by reusing already fetched dependencies. For status.php it went from 355 to 344. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2021-01-20 21:55:16 +01:00
Roeland Jago Douma	0893bba369	Merge pull request #25153 from nextcloud/bugfix/noid/force-signature-verification-on-occ ... Force signature verification of apps on occ	2021-01-19 09:35:52 +01:00
Joas Schilling	90c3013d40	Cleanup the constructor ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-01-18 11:32:50 +01:00
Daniel Calviño Sánchez	d6a1d8d3a1	Add "composer.lock" for acceptance tests to git ... As "composer.lock" was not versioned the dependencies had to be resolved everytime that the acceptance tests run, which took some precious time. Besides that the dependency versions were also tightened for better control. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2021-01-17 16:44:32 +01:00
blizzz	f9ab7575e7	Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2 ... respect DB restrictions on number of arguments in statements and queries	2021-01-14 11:36:42 +01:00
Roeland Jago Douma	9b58a027e3	Allow installing/updating of apps again ... The Guzzle API changed. We shall now use sink Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2021-01-12 10:51:41 +01:00
blizzz	7cdc7adf59	Merge pull request #25038 from nextcloud/bugfix/noid/install-mysql8-with-php8 ... Don't try a transaction for the migrator on MySQL	2021-01-11 18:07:11 +01:00
Joas Schilling	2d34ca4143	Only rollback when not MySQL ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2021-01-11 16:11:02 +01:00
Arthur Schiwon	f9484d15cb	DB: warn on parameter number constraints ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2021-01-11 13:43:34 +01:00
Christoph Wurst	c3cb288268	Bump scssphp/scssphp from 1.0.3 to 1.4.0 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-01-11 12:41:25 +01:00
Christoph Wurst	f0c6cfde3a	Rollback failed transactions in TestCase.php to not break followup tests ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-01-08 11:45:19 +01:00
Christoph Wurst	8b64e92b92	Bump doctrine/dbal from 2.12.0 to 3.0.0 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2021-01-08 11:45:19 +01:00
Jasper Knockaert	261966ace5	Update EncryptionTest.php	2021-01-05 21:45:50 +01:00
Jasper Knockaert	664e74a82e	2nd attempt to fix tests	2021-01-05 20:41:02 +01:00
Jasper Knockaert	87c640193b	attemtp to fix test	2021-01-05 19:09:16 +01:00
Julius Härtl	98560c80ea	Properly handle result when copying with failure and throw in tests ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2021-01-05 09:20:35 +01:00
Julius Härtl	ee842f1c43	Fix writeStream mocking ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2021-01-05 09:20:35 +01:00
Julius Härtl	1bb81f8f11	jsunit: Remove warnings during test runs ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-12-29 08:42:34 +01:00
Julius Härtl	c7a320d880	jsunit: Run jsunit with chromium/puppeteer on github actions ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-12-29 08:42:27 +01:00
Christoph Wurst	b981cb0718	Merge pull request #19942 from ACTom/add-mindmap-icon ... Add mindmap type file icon	2020-12-28 10:13:38 +01:00
ACTom	d9db6ae84e	Readd test getOnlyDefaultAliases() ... Signed-off-by: ACTom <i@actom.me>	2020-12-28 13:59:10 +08:00
Maxence Lange	e0bafb7475	deleteChildren only returns array ... Signed-off-by: Maxence Lange <maxence@artificial-owl.com>	2020-12-23 11:00:47 +01:00
Christoph Wurst	f37e150d1c	Merge pull request #24702 from nextcloud/enhancement/well-known-handler-api ... Add well known handlers API	2020-12-18 13:34:04 +01:00
Christoph Wurst	6995223b1e	Add well known handlers API ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-12-16 13:13:05 +01:00
Arthur Schiwon	d8ad4ef6b5	use a consistent default value for sharing.maxAutocompleteResults ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2020-12-15 11:53:39 +01:00
Julius Härtl	131fcac91e	Show unique displayname context in the sharing input ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-12-14 11:14:59 +01:00
Roeland Jago Douma	ccd5ca5476	Merge pull request #23044 from nextcloud/migration-10.5 ... Handle owncloud migration to latest release	2020-12-10 14:32:13 +01:00
Roeland Jago Douma	3c693db0ca	Merge pull request #24605 from nextcloud/enh/share-deck ... Add deck share provider support	2020-12-10 14:30:08 +01:00
Julius Härtl	a0444bc69c	Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string	2020-12-09 17:25:59 +01:00
Julius Härtl	85e6cbc87a	Extend dummy factory in tests ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-12-09 13:20:25 +01:00
Julius Härtl	9fe94f282f	Readd repair steps that are relevant when migrating from ownCloud ... This reverts commit d9b1492e03. Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-12-09 12:13:35 +01:00
Joas Schilling	d04b7cf03d	Skip the test if Imagick is misconfigured ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-12-09 09:07:20 +01:00
Joas Schilling	86a3b7e7bf	Merge pull request #24486 from nextcloud/feature/noid/phone-number-validation ... Phone number validation and search	2020-12-08 17:05:38 +01:00
Julius Härtl	4f927721b2	Add temporary test for migrating int to string ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-12-08 16:06:13 +01:00
Roeland Jago Douma	6a7e849090	php cs fix ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:04 +01:00
Roeland Jago Douma	c02e6fcae2	fix appconfig tests ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:04 +01:00
Roeland Jago Douma	b668850aa1	Fix filesystem tests ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:04 +01:00
Roeland Jago Douma	a25b46f494	Make sure we can also run with escapedshell args ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:04 +01:00
Roeland Jago Douma	48679ae39f	Make sure we just check for the keys ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:03 +01:00
Roeland Jago Douma	d690f90928	Do not run image tests on php8 ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:03 +01:00
Roeland Jago Douma	1670eabdb3	Do not run on php8 ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:03 +01:00
Roeland Jago Douma	6b7731a852	Move to new phpunit ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:03 +01:00
Roeland Jago Douma	988ce1374c	Don't check on php8 ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:03 +01:00
Roeland Jago Douma	c084008df2	Avatar fixes ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:03 +01:00
Roeland Jago Douma	9317e0f0f0	Fix test traits for phpunit 9 ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-07 15:44:03 +01:00
Joas Schilling	f0ca76aefb	Add and fix unit tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-12-07 14:19:38 +01:00
Joas Schilling	da9462b482	Make code strict ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-12-07 14:19:37 +01:00
Roeland Jago Douma	3d315ec64f	Fix vsprint parameter ... %2\$; is not valid. On php7 this is just ignored but on php8 it gives an error. %2\$s; works. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-12-03 08:25:11 +01:00
Morris Jobke	c0a05c0412	Add notification for user limit ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-12-02 15:20:03 +01:00
Morris Jobke	d87705a894	Allow subscription to indicate that a userlimit is reached ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-12-02 15:20:03 +01:00
Morris Jobke	83a75c670b	Replace static call to Share::unshare with ShareManager->deleteShare in tests ... And then cleanup all the code that is dead then... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-11-30 09:51:18 +01:00
Roeland Jago Douma	2172432420	Merge pull request #23912 from nextcloud/objectstore-copy ... use in objectstore copy	2020-11-25 16:09:26 +01:00
Robin Appelman	9d4848e863	use in objectstore copy ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-11-24 15:16:58 +01:00
Arthur Schiwon	16a78f535a	set the display name of federated sharees from addressbook ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2020-11-24 11:30:11 +01:00
Morris Jobke	efe644137d	[encryption] Remove dependency fetching inside the constructor and move them to method call parameters ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-11-22 22:35:02 +01:00
Morris Jobke	1b613c84e9	Merge pull request #24007 from nextcloud/select-distinct-multiple ... allow selecting multiple columns with SELECT DISTINCT	2020-11-19 22:39:01 +01:00
Roeland Jago Douma	d602aa1825	Merge pull request #24135 from medical-cloud/fix/23357-nextcloud-logo-in-email-notifications-is-misaligned-in-version-20 ... Fix nextcloud logo in email notifications misalignment	2020-11-19 10:48:18 +01:00
medcloud	87ec4a0da3	Fix #23357 ... Signed-off-by: medcloud <42641918+medcloud@users.noreply.github.com>	2020-11-18 22:29:02 +01:00
Roeland Jago Douma	66013f906d	Merge pull request #24189 from nextcloud/enh/csp/frame-ancestors ... Set frame-ancestors to none if none are filled	2020-11-18 11:29:28 +01:00
Roeland Jago Douma	9163790b7c	Set frame-ancestors to none if none are filled ... frame-ancestors doesn't fall back to default-src. So when we apply a very restricted CSP we should make sure to set it to 'none' and not leave it empty. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-11-18 10:13:36 +01:00
Roeland Jago Douma	72a9c35be3	Remove some IRouter methods ... This is not the end. IRouter needs to burn. But it is a start. 🎵 we didn't start the fire 🎵 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-11-17 14:08:20 +01:00
Robin Appelman	a61a757b85	allow selecting multiple columns with SELECT DISTINCT ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-11-16 15:45:17 +01:00
Daniel Calviño Sánchez	4d3cb1533e	Add unit tests for "validateExpirationDateInternal" ... They were copied and adjusted as needed from the tests for "validateExpirationDate". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-16 08:54:19 +01:00
Daniel Calviño Sánchez	baaaacd650	Add explicit time to test date for clarity ... This shows in a clearer way that the expected expiration date is the original one, but without time. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:34 +01:00
Daniel Calviño Sánchez	578b57837a	Add unit test for expiration date with date and with default ... This adds back what was being actually tested in the unit test fixed in the previous commit. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:34 +01:00
Daniel Calviño Sánchez	70018ddabf	Fix unit test for expiration date without date but with default ... The expiration date was explicitly given, so it was not testing what it should. Moreover, "link_defaultExpDays" needs to be mapped when testing the default value (even if it will just fallback to the value of "shareapi_expire_after_n_days"). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:32 +01:00
Daniel Calviño Sánchez	3a53c2b6e5	Fix unit test method name ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:31 +01:00
Daniel Calviño Sánchez	e997f0fa46	Fix unit test for verifying enforced valid expiration date. ... The enforced expiration date was not actually enabled, as for that "shareapi_default_expire_date" needs to be explicitly set to "yes". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:31 +01:00
Daniel Calviño Sánchez	8f1fff40e8	Fix unit test for verifying enforced expire date too far in the future ... The test should fail if no exception was thrown, and no exception was thrown due to a missing configuration parameter. However, the use of "addToAssertionCount(1)" made the test pass even if no exception was thrown and, therefore, to silently fail. Now the missing configuration parameter was added and the test will fail if the expected exception is not thrown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:29 +01:00
Daniel Calviño Sánchez	ec92e82571	Add unit tests to enforce a relaxed default share expiration date ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:28 +01:00
Daniel Calviño Sánchez	4dbeab5cff	Remove wrong and misleading comment ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:26 +01:00
Daniel Calviño Sánchez	72f51422ec	Remove extra spaces ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:25 +01:00
Daniel Calviño Sánchez	7cfa2701b9	Fix typo in variable name ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:23 +01:00
Daniel Calviño Sánchez	c8dc51f0ba	Fix typos in method names ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-12 11:57:22 +01:00
Morris Jobke	42a033bbc4	Change to full class names for the encryption app DI in preparation of auto-wiring ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-11-11 21:30:45 +01:00
Joas Schilling	e39d657e24	Merge pull request #23882 from nextcloud/tests/oracle ... Run unit tests against oracle	2020-11-11 10:05:24 +01:00
Daniel Calviño Sánchez	b6dec0be99	Add acceptance tests for reshares by link when resharing is disabled ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-11 01:35:27 +01:00
Daniel Calviño Sánchez	22d949d9d9	Add acceptance tests for reshares when resharing is disabled ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-11-11 01:35:27 +01:00
Joas Schilling	0c695d97ec	Fix unique key in test table ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-11-10 21:39:19 +01:00
Joas Schilling	61c767128c	Skip the insertIfNotExists() tests on Oracle because it doesn't work with clob ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-11-10 15:34:35 +01:00
Joas Schilling	74c0143001	Easier debugging and spell fix ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-11-10 15:34:35 +01:00
Joas Schilling	e313777cd6	Use a different column for the primary key as we can not insert it on oracle ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-11-10 15:34:35 +01:00
Julius Härtl	2050517d44	Add github action for oci8 ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-11-10 15:34:35 +01:00
Joas Schilling	8027dcbc6f	Don't leave cursors open when tests fail ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-11-09 12:28:17 +01:00
Joas Schilling	c07720de77	Use query builder instead of OC_DB in OC\Files\* ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-11-09 09:05:15 +01:00
John Molakvoæ	d25e5366b8	Merge pull request #23934 from nextcloud/enh/avoid_scss_compile	2020-11-07 10:11:50 +01:00
Morris Jobke	3e6e9186d8	Fix tests to return config default values ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-11-07 10:11:20 +01:00
Morris Jobke	659ea6ad79	Merge pull request #23851 from nextcloud/enh/read_env_only_once ... Read the env variables only once	2020-11-06 22:35:00 +01:00
Joas Schilling	da1c2bdfe6	Fix repair mimetype step to not leave stray cursors ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-11-06 10:33:59 +01:00
Roeland Jago Douma	f7a2b71627	Fix tests ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-11-06 09:37:45 +01:00
Joas Schilling	ede7510854	Add a function to get the unread count for multiple objects in one go ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-11-04 11:01:21 +01:00
Morris Jobke	8d02ee9ac7	Merge pull request #21693 from nextcloud/fix/noid/import-certificates-only-by-system ... Improve CertificateManager to not be user context dependent	2020-11-03 21:48:37 +01:00
Morris Jobke	f03bb4716b	Remove OCSResponse type hint - see #23827 ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-11-03 10:43:32 +01:00
Morris Jobke	dc479aae2d	Improve CertificateManager to not be user context dependent ... * removes the ability for users to import their own certificates (for external storage) * reliably returns the same certificate bundles system wide (and not depending on the user context and available sessions) The user specific certificates were broken in some cases anyways, as they are only loaded if the specific user is logged in and thus causing unexpected behavior for background jobs and other non-user triggered code paths. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-11-03 00:13:01 +01:00
Roeland Jago Douma	fa6a790859	Remove deprecated OCSResponse ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-11-01 14:12:27 +01:00
Morris Jobke	f94af85749	Merge pull request #23788 from nextcloud/techdebt/noid/only-run-phpunit-when-php-changed ... Only run phpunit when "php" changed	2020-10-30 13:06:50 +01:00
Joas Schilling	8a3d9e52e3	Also run for .sh and .json (when not package or package-lock) ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-30 10:30:50 +01:00
Joas Schilling	be357ecd78	Also run all tests when drone config is modified ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-30 09:47:27 +01:00
Joas Schilling	0de48617ec	Only run phpunit when php, xml or test files are modified ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-30 09:46:53 +01:00
Robin Appelman	de7026f6e4	use file name instead of path in 'not allowed to share' message ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-10-29 16:43:21 +01:00
Morris Jobke	7ed11b6dfa	Merge pull request #23765 from nextcloud/techdebt/noid/sudadmin-events-into-typed-events ... Add typed events for adding and removing a subadmin	2020-10-29 11:18:01 +01:00
Morris Jobke	765ee60eea	Change tests to typed event listener ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-10-28 23:10:23 +01:00
Morris Jobke	6e35457fcc	Remove unused private ForwardEmitter and LegacyEmitter ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-10-28 22:23:39 +01:00
Morris Jobke	e4f53ff91b	Add typed events for adding and removing a subadmin ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-10-28 21:55:08 +01:00
Roeland Jago Douma	cf1af5b83b	Merge pull request #23496 from lynn-stephenson/fix/related-key-issue ... Fixes related key issue.	2020-10-27 20:23:07 +01:00
Roeland Jago Douma	eadce7fadd	Merge pull request #23601 from nextcloud/techdebt/noid/comments-manager-improvements ... Comments manager improvements/extensions needed by Talk	2020-10-27 19:57:55 +01:00
Morris Jobke	a7470576cf	Merge pull request #23614 from nextcloud/tests/22305/unreliable-app-files-sharing-338 ... Disable unreliable app-files-sharing.feature:108	2020-10-22 12:19:39 +02:00
Morris Jobke	19950cb23c	Merge pull request #23613 from nextcloud/tests/22305/unreliable-app-files-feature-108 ... Disable unreliable app-files.feature:108	2020-10-22 12:18:12 +02:00
Joas Schilling	1f1244fdcc	Fix PHP CS ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-22 11:00:54 +02:00
Joas Schilling	8600e51df5	Fix manager creation and testing ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-22 10:54:03 +02:00
Morris Jobke	dff9853d36	Disable unreliable app-files-sharing.feature:108 ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-10-21 22:07:13 +02:00
Morris Jobke	8128913dff	Disable unreliable app-files.feature:108 ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-10-21 21:53:29 +02:00
John Molakvoæ	766590d204	Merge pull request #23173 from nextcloud/feat/comments-sidebar-vue	2020-10-20 20:46:21 +02:00
John Molakvoæ (skjnldsv)	6cd7549509	Bump @nextcloud/vue to 3.0.0 ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>	2020-10-20 18:02:45 +02:00
Joas Schilling	4bc821edd9	PSR logger for accounts ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-20 17:41:47 +02:00
John Molakvoæ (skjnldsv)	3e1916080a	Add ICommentsManager::load method ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	2020-10-20 14:39:28 +02:00
Roeland Jago Douma	ffd76d05c9	Merge pull request #23374 from nextcloud/bugfix/noid/app-fetch-retry ... Only retry fetching app store data once every 5 minutes in case it fails	2020-10-20 09:21:51 +02:00
ACTom	2d175586b4	fix php-cs check fail(tests/lib/IntegrityCheck/CheckerTest.php) ... Signed-off-by: ACTom <i@actom.me>	2020-10-18 00:38:57 +08:00
ACTom	47ebcdff9e	fix Test\IntegrityCheck\CheckerTest tests fail ... Signed-off-by: ACTom <i@actom.me>	2020-10-18 00:38:48 +08:00
Julius Härtl	4512c73293	Only retry fetching app store data once every 5 minutes in case it fails ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-10-16 14:32:58 +02:00
Morris Jobke	cce716f9f3	Clear cached app config while waiting for the SCSSCache to finish processing the file ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-10-16 13:28:00 +02:00
lynn-stephenson	a3bdb0c4cb	Implement unit tests for versions 1 and 2. ... Signed-off-by: lynn-stephenson <lynn.stephenson@protonmail.com>	2020-10-15 21:23:24 -08:00
Joas Schilling	0ad4ad31e1	Fix more tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-13 08:16:17 +02:00
Joas Schilling	49ff48fcd3	Use PSR logger in authentication ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-12 22:07:04 +02:00
Morris Jobke	f5a52e941c	Overwrite also the new command bus name to execute them in sync in the tests ... Followup to #23245 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-10-12 21:04:00 +02:00
Morris Jobke	91d445909a	Fix code style ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-10-12 14:54:51 +02:00
Robin Windey	6a1f8fb3be	Fix typo 'shared'	2020-10-12 14:19:41 +02:00
Morris Jobke	3b82c6cc84	Merge pull request #23184 from nextcloud/bugfix/noid/make-sure-getUsersFavoritingObject-can-be-run-without-a-user ... Make sure getUsersFavoritingObject can be run without a user	2020-10-07 13:08:02 +02:00
Joas Schilling	9f99f859a1	Make sure getUsersFavoritingObject can be run without a user ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-06 16:49:23 +02:00
Christoph Wurst	d9015a8c94	Format code to a single space around binary operators ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-10-05 20:25:24 +02:00
Roeland Jago Douma	b976cd5535	Merge pull request #21821 from nextcloud/enh/bootstrap/initial_state ... Bootstrap: add initial state registration	2020-10-04 11:09:18 +02:00
Roeland Jago Douma	1896f37465	Merge pull request #22937 from nextcloud/enh/allow_configuring_token_auth_activity_interval ... Allow configuring the activity update interval of token	2020-10-04 10:37:41 +02:00
Roeland Jago Douma	f4707d178e	Merge pull request #23047 from nextcloud/techdebt/noid/warn-on-database-abuse ... Log the number of queries built and executed	2020-10-04 10:07:49 +02:00
Roeland Jago Douma	f865a3a1c2	Move initial state provider to boostrap ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-10-04 09:35:33 +02:00
Roeland Jago Douma	76a7600e2e	Allow configuring the activity update interval of token ... On some systems with a lot of users this creates a lot of extra DB writes. Being able to increase this interval helps there. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-10-04 09:31:41 +02:00
Joas Schilling	95a301ea57	Fix tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-02 10:37:18 +02:00
Joas Schilling	7255666557	Set status is also there now ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-10-02 09:12:03 +02:00
Joas Schilling	c25063dc07	Don't break when the IP is empty ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-09-10 14:20:27 +02:00
Morris Jobke	cd563023db	Merge pull request #22657 from nextcloud/bugfix/noid/quota-trash-creation ... Check if quota should be applied to path when creating directories	2020-09-09 17:37:28 +02:00
Morris Jobke	e6fca0a519	Fix code style ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-09-09 17:36:58 +02:00
Morris Jobke	22ff60e088	Merge pull request #22564 from nextcloud/bugfix/noid/show-avatars-again ... The privacy setting is only about syncing to other servers	2020-09-09 17:35:13 +02:00
Julius Härtl	74747163d6	Make sure tests cover the new mkdir behaviour on 0 quota ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-09-08 11:35:32 +02:00
Joas Schilling	c2bef528ef	Remove unused members and imports ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-09-08 10:45:35 +02:00
Christoph Wurst	adf100a42f	Fix undefined class property access after upgrade from 19 to 20 ... The serialized data in 19 has one property less and this was not considered in the code. Hence adding a fallback. Moreover I'm changing the deserialization into an array instead of object, as that is the safer option. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-09-07 13:31:24 +02:00
John Molakvoæ	593d64d935	Merge pull request #17456 from brad2014/feature/brad2014/12391-improve-imip-mail-message-take-2	2020-09-04 19:53:02 +02:00
Joas Schilling	a4b2403e29	The privacy setting is only about syncing to other servers ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-09-03 15:46:21 +02:00
Daniel Calviño Sánchez	96821945fb	Adjust acceptance tests to changes in @nextcloud/vue 2.6.3 ... The menu button and the menu of a share are no longer direct childs of the actions of the share row. The menu button is now a child of a ".trigger" element, while the menu is a direct child of the body and has an id defined in the "aria-describedby" attribute of the ".trigger" element. In XPath 1.0 it does not seem possible to "backreference" a value or create variables, so when the share menu or one of its item is needed now the ".trigger" element is first found and then its XPath expression is used to compose its "aria-describedby" attribute in the XPath expression for the menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-09-03 09:09:26 +02:00
Brad Rubenstein	442af8c5d5	Minor cleanup: php-cs-fixer, tests, interface consistency ... IMipPlugin.php Removed blank lines to make php-cs-fixer happy. Minor cleanup: bugs found by Psalm static checker IEMailTemplate: The public interface to addBodyListItem also needs to include the new plainIndent parameter. IMipPlugin: Fixes an undefined variable for events that do not have DTEND. Also use explicit string conversion for parameters and properties in several places. The new email template adds an additional blank line before "button" links in plain text, so the tests were fixed to include that additional blank line. Signed-off-by: Brad Rubenstein <brad@wbr.tech>	2020-09-02 17:54:36 +02:00
Julius Härtl	e0ae37745a	Do not expose direct editing if no master key is available ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-09-01 11:40:27 +02:00
Daniel Calviño Sánchez	034b7bd4a9	Fix clicks on actions menu of non opaque file rows in acceptance tests ... When a row is added to the file list the opacity of the file row is animated from transparent to fully opaque. As the file actions menu is a descendant of the row but overflows it when the row is not fully opaque clicks on the menu entries "fall-through" and are received instead by the rows behind. The opacity animation is a CSS animation, and it is not possible to know if a row is appearing or not except from its opacity (the row will have the "appear" CSS class even after the animation ended). Therefore it should be waited until the row of the file is fully opaque before using the menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-08-29 03:32:14 +02:00
Roeland Jago Douma	7b8364e001	Merge pull request #21288 from lmamane/master ... Return correct loginname in credentials	2020-08-28 16:11:46 +02:00
Morris Jobke	a0cbf16d9b	In case the group backend returns $limit or more results it is expected to contain more results ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-21 13:14:32 +02:00
Roeland Jago Douma	987f621173	Merge pull request #22331 from nextcloud/bugfix/noid/dont-use-deprecated-inigetwrapper ... Don't use deprecated getIniWrapper() anymore	2020-08-20 19:45:47 +02:00
Morris Jobke	65b5e65185	Merge pull request #21529 from nextcloud/enh/encryption/improve_key_format ... New SSE key format	2020-08-20 17:41:18 +02:00
Morris Jobke	590d461210	Remove unneeded import ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-20 16:53:34 +02:00
Morris Jobke	9e483ea949	Fix unit tests ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-20 16:35:38 +02:00
Joas Schilling	b09620651c	Don't use deprecated getIniWrapper() anymore ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-08-20 16:35:38 +02:00
Lionel Elie Mamane	2c8e7912f3	adapt testGetLoginCredentialsInvalidTokenLoginCredentials() unit test to uid != loginname ... Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>	2020-08-20 16:02:23 +02:00
Roeland Jago Douma	5340ab3a75	New SSE key format ... * Encrypt the keys with the instance secret * Store them as json (so we can add other things if needed) Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-08-20 15:42:43 +02:00
Morris Jobke	387cac4c5f	Properly inject IRouter into URLGenerator to properly encapsulate tests ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-19 22:00:47 +02:00
Morris Jobke	053ee7b386	Only load routes of the app which is requested ... * Add fallback to load all routes if needed * Move partial loaded routes test to proper place Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-19 21:58:20 +02:00
Joas Schilling	a9f22ac7b1	More test fixing ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-08-19 12:40:25 +02:00
Joas Schilling	41d8a7e05f	Fix unit tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-08-19 11:20:36 +02:00
Joas Schilling	3a71155fc5	Fix activity tests again ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-08-18 18:21:03 +02:00
Georg Ehrke	5b26487f14	Expose status via Collaborators API ... Signed-off-by: Georg Ehrke <developer@georgehrke.com>	2020-08-14 17:04:52 +02:00
Gary Kim	5559570faf	Merge pull request #22242 from nextcloud/techdebt/noid/remove-deprecated-methods ... Remove deprecated and unused method calls	2020-08-14 10:10:53 +08:00
Morris Jobke	8e249569af	Fix existing test and add a specific one for the new case ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-13 23:24:21 +02:00
Morris Jobke	16d83ab30a	Remove getLastJob from IJobList ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-13 21:50:06 +02:00
Morris Jobke	725fecee34	Merge pull request #21344 from nextcloud/fix/twofactor-cleanup-event ... Emit an event for every disabled 2FA provider during cleanup	2020-08-13 07:25:01 +02:00
Morris Jobke	234b510652	Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-12 13:55:19 +02:00
Morris Jobke	8fc877ff7d	Merge pull request #22117 from nextcloud/activity-settings-grouping ... allow grouping of activity settings	2020-08-11 11:24:23 +02:00
Daniel Kesselberg	aa0e90f0c0	Exclude apps/files_external/3rdparty again ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2020-08-10 21:49:50 +02:00
Daniel Kesselberg	2ae285daec	Rename Core/ to core/ ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2020-08-10 21:48:30 +02:00
Daniel Kesselberg	385613c3aa	Exclude apps/*/tests for coverage calculation ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2020-08-10 13:40:16 +02:00
John Molakvoæ (skjnldsv)	9e962fb69f	Allow to update to nightly ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	2020-08-07 13:51:39 +02:00
Morris Jobke	06eb230d24	Merge pull request #22135 from nextcloud/enh/noid/occ-preview-repair ... Add occ preview:migrate to migrate previews from the old flat structure to a subfolder structure	2020-08-07 11:09:16 +02:00
Morris Jobke	97c49b0b15	Add tests for occ preview:migrate - initial check for empty directories ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-07 10:42:09 +02:00
Morris Jobke	45428e4948	Add config option to enable multibucket preview distribution ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-06 22:31:39 +02:00
Morris Jobke	159f28cd52	Mount the old previews in a separate folder for the multi bucket setup and check in them before using the actual locations ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-06 22:19:21 +02:00
John Molakvoæ	5b6246f52a	Merge pull request #21598 from nextcloud/enh/20930/dashboard-drag	2020-08-06 08:17:52 +02:00
Morris Jobke	5a06e38564	Dashboard app is disabled and there is no need to redirect to files app ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-08-05 22:49:47 +02:00
Morris Jobke	519cd678ee	Merge pull request #22008 from elijahnyp/OCImage_Leak_Fix ... Ensured large image is unloaded from memory when generating previews	2020-08-05 22:39:09 +02:00
Julius Härtl	4679926511	Redirect to files app after login in acceptance tests ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-08-05 17:01:29 +02:00
Robin Appelman	227e362842	allow grouping of activity settings ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-08-05 16:13:03 +02:00
Georg Ehrke	0fad921840	Add user-status app ... Signed-off-by: Georg Ehrke <developer@georgehrke.com>	2020-07-31 16:45:27 +02:00
John Molakvoæ (skjnldsv)	3a31397ac2	Use babel-loader-exclude-node-modules-except ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	2020-07-31 11:00:33 +02:00
Joas Schilling	bab4fb98eb	Fix overwriteService() for apps ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-07-28 09:38:43 +02:00
Elijah Martin-Merrill	56ed563b0c	fix memory leak caused by not destroying image in Preview/Generate.php ... Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>	2020-07-27 10:52:44 -04:00
Morris Jobke	34c027e443	Merge pull request #21940 from nextcloud/fix/14541/fix-fragile-acceptance-tests-part1 ... Revert "Disable fragile tests for now" partially	2020-07-24 01:04:13 +02:00
Morris Jobke	a169bd243f	Merge pull request #21972 from nextcloud/techdebt/noid/cleanup-phpunit-warnings ... Fix PHPUnit deprecation warnings	2020-07-23 21:38:22 +02:00
Morris Jobke	173f8abc7e	Merge pull request #21628 from nextcloud/external-to-s3-trashbin-fix ... fix moving files from external storage to object store trashbin	2020-07-23 21:35:18 +02:00
Simon Spannagel	d5b1297b55	Adjust tests to new e-mail layout ... Signed-off-by: Simon Spannagel <simonspa@kth.se>	2020-07-23 20:22:48 +02:00
Morris Jobke	761cdf9877	Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests ... I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside. See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322 It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-07-23 17:11:29 +02:00
Morris Jobke	7e6c0ec284	Use assertEqualsCanonicalizing instead of deprecated assertEquals parameter ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-07-23 17:11:29 +02:00
Morris Jobke	e4144e6b36	Remove deprecated test of internal attributes via assertAttributeEquals ... See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322 It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-07-23 17:11:29 +02:00
Morris Jobke	0123cd0ae3	Use assertStringContainsString instead of assertContains on strings ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-07-23 17:11:29 +02:00
Robin Appelman	ad7798f9c9	use exceptions for error signaling in writeStream ... this remove the ambiguity when writing zero length files Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-07-23 15:24:52 +02:00
Robin Appelman	fcad692b4a	rollback cache rename if trashbin move fails ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-07-23 15:24:48 +02:00
Morris Jobke	346f647962	Merge pull request #21870 from nextcloud/fix/bootstrap-context-container-interfaces ... Make the bootstrap context return ContainerInterface instances	2020-07-22 20:38:50 +02:00
Daniel Calviño Sánchez	9303390b66	Hide share link menu before copying the share link in acceptance tests ... The (old) Firefox version used in the acceptance tests does not properly render the share link menu. As the menu is taller than it should sometimes it covers the copy link button, so it is not possible to click it without hiding the share link menu. Moreover, in those cases the share menu button is also covered by the share menu, so the menu needs to be closed by pressing the "Esc" key. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-07-22 15:59:35 +02:00
Georg Ehrke	f217b11443	Fix breaking changes of nc/vue update ... Signed-off-by: Georg Ehrke <developer@georgehrke.com>	2020-07-22 15:55:59 +02:00
Christoph Wurst	91e7f12088	Adjust apps' code to use the ContainerInterface ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-07-21 20:43:18 +02:00
Morris Jobke	5cd5d3c55b	Revert "Disable fragile tests for now" ... This reverts commit 40e04c8391. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-07-21 15:58:55 +02:00
Julius Härtl	6f32b59b23	Remove outdated ui-regression tests ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-07-20 09:27:46 +02:00
Roeland Jago Douma	7d7ba61625	Add real events to load additionalscripts ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-07-15 14:07:18 +02:00
Julius Härtl	81e5593133	Move to lazy panel registration during registration context ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-07-15 09:27:57 +02:00
Christoph Wurst	f03f88b437	Delegate bootstrap registration lazily ... * Keep the registration context * Expose the context object for other components * Ensure registration is only run once Search providers are migrated for demonstration. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-07-14 15:33:32 +02:00
Roeland Jago Douma	10d862e243	Merge pull request #21759 from nextcloud/enh/lazy_subscription ... Make the subscription registry lazy	2020-07-09 15:43:48 +02:00
Daniel Kesselberg	d9f5fdb67a	Add DummySubscription for tests ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2020-07-09 14:24:00 +02:00
Roeland Jago Douma	725872c23a	Make the subscription registry lazy ... This will allow to do lazy registration here which should allow for loading less (or at least only when needed!). Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-07-09 12:21:06 +02:00
Robin Appelman	37c334a2a6	ensure mounts are scanned during tests ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-07-09 11:14:44 +02:00
Roeland Jago Douma	43efac345e	Use the correct mountpoint to calculate ... If we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-07-09 11:14:44 +02:00
Roeland Jago Douma	3f447b9c8c	Fix supporting defaults for routes ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-07-08 19:52:45 +02:00
Roeland Jago Douma	edc1c77dd9	Do not create a RouteActionHandler object for each route ... This is not required and doesn't allow us to be properly lazy. On top of it this doesnt allow us to cache the routes (since closures/objects can't be cached). This is the first small step into cleaning up the routing we have Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-07-07 12:33:22 +02:00
Holger Hees	e70249e089	Update SecurityMiddleware.php ... OC::$WEBROOT can be empty in case if your nextcloud installation has no url prefix. This will result in an empty Location Header. in other areas OC::$WEBROOT is always used together with an /	2020-07-06 21:34:46 +02:00
Morris Jobke	e20db42a0c	Tags.php and the old sharing mechanism ... The old sharing mechanism isn't working anymore, because it was replaced by Share 2.0. Also it was nowhere used so this removes the code paths and reduces complexity. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-07-06 14:12:12 +02:00
Morris Jobke	d3d11cb826	Merge pull request #21626 from nextcloud/enhancement/injectible-callables ... Callable parameter injection	2020-07-05 22:03:12 +02:00
Christoph Wurst	4a3ea04baa	Callable parameter injection ... This is like what we have to DI and classes, but for callables. The motivating factor is to get rid of *service locators* in the `boot` method of apps as a new pattern is about to emerge where we have lots of `query` calls on the app or server container in order to fetch some services. With this little helper it's possible to call another (public) method and magically have everything injected. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-07-03 14:37:46 +02:00
Joas Schilling	19e1efd1dd	Merge pull request #21439 from nextcloud/feature/noid/move-autocomplete-filter-event-to-new-dispatcher-and-class ... Move AutoComplete::filterResults to new event dispatcher and GenericE…	2020-07-03 10:03:34 +02:00
Roeland Jago Douma	d53e005458	Merge pull request #21360 from nextcloud/root-storage-prevent-scanning ... prevent the root storage from accidentally scanning user folders	2020-07-02 21:07:16 +02:00
Roeland Jago Douma	0157e30ad4	Merge pull request #21599 from nextcloud/debt/noid/type-to-types ... Replace TYPE with TYPES	2020-07-02 12:21:01 +02:00
Roeland Jago Douma	0ac3a65f62	Merge pull request #21653 from nextcloud/bugfix/noid/fix-ipv6-remote-addresses-from-x-forwarded-for-header ... Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validating	2020-07-02 12:01:24 +02:00
Joas Schilling	74a9cadc50	Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validating ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-07-02 11:13:13 +02:00
Joas Schilling	35c6b1236f	Move AutoComplete::filterResults to new event dispatcher and GenericEvent ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-07-01 09:57:33 +02:00
Daniel Kesselberg	87dd760a89	Replace TYPE with TYPES ... As TYPE::* is deprecated. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2020-06-30 23:46:22 +02:00
Joas Schilling	1336f44a68	Fix unit tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-06-26 16:13:09 +02:00
Joas Schilling	b7060be18d	Fix robots "noindex, nofollow" signals ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-06-25 08:29:43 +02:00
Roeland Jago Douma	7d4682da40	Merge pull request #21379 from nextcloud/fix-share-permission-checkboxes-enabled-when-permissions-can-not-be-set ... Fix share permission checkboxes enabled when permissions can not be set	2020-06-24 21:20:17 +02:00
Joas Schilling	a2f34f46b2	Fix tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-06-24 18:13:37 +02:00
Joas Schilling	89ed2c37bf	Update share type constant usage ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-06-24 16:49:16 +02:00
Christoph Wurst	4488e846a5	Add unified search API ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-06-24 14:20:25 +02:00
Joas Schilling	95652d4469	Fix language in share notes email for users ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-06-23 22:01:40 +02:00
Joas Schilling	8ec1b8132e	Merge pull request #21452 from nextcloud/bugfix/21451/allow-autocomplete-by-displayname-again ... Fix autocomplete for LDAP with `shareapi_only_share_with_group_members` on	2020-06-23 14:02:17 +02:00
blizzz	859941db32	Merge pull request #21479 from nextcloud/fix/21474/allow_specifying_cookie_type ... Allow to specify the cookie type for appframework responses	2020-06-22 13:00:12 +02:00
Roeland Jago Douma	fbf9772a3e	Allow to specify the cookie type for appframework responses ... In general it is good to set them to Lax. But also to give devs more control over them is not a bad thing. Helps with #21474 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-06-22 08:38:44 +02:00
Roeland Jago Douma	c006b5ff2a	Fix unit test of the ResponseTest ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-06-21 09:44:56 +02:00
Arthur Schiwon	de61c7d302	acceptence tests shall specify which branch to pick when cloning apps ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2020-06-19 21:08:39 +02:00
Christoph Wurst	2b7b7144d4	Allow crash reporters registration during app bootstrap ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-06-19 10:38:26 +02:00
Joas Schilling	1151394739	Fix unit tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-06-18 11:33:43 +02:00
Christoph Wurst	69571fb536	Add dedicated API for apps' bootstrapping process ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-06-17 09:22:21 +02:00
Christoph Wurst	68794ebc92	Emit an event for every disabled 2FA provider during cleanup ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-06-16 14:38:33 +02:00
Christoph Wurst	5e52c110bb	Merge pull request #21416 from nextcloud/fix/user-deleted-token-cleanup ... Clean up auth tokens when user is deleted	2020-06-16 10:01:29 +02:00
Christoph Wurst	3474afa938	Clean up auth tokens when user is deleted ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-06-15 19:24:04 +02:00
Julius Härtl	294e40db5f	Avoid duplicate matches in wide and exact results ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-06-15 09:34:57 +02:00
Joas Schilling	b6d5979d0a	Increase timeout of the appstore requests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-06-12 13:01:06 +02:00
Daniel Calviño Sánchez	2c6d5068ad	Add acceptance test for disabling create permission after sharing ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-06-11 23:18:21 +02:00
Daniel Calviño Sánchez	33222d67ea	Add acceptance test for sharing a folder without create permission ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-06-11 23:17:33 +02:00
Daniel Calviño Sánchez	573bf4d667	Add acceptance test for sharing a file without edit permission ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-06-11 23:15:26 +02:00
Daniel Calviño Sánchez	cafa68493a	Generalize functions to get locators for share permission checkboxes ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-06-11 23:12:20 +02:00
Robin Appelman	e9b5514186	prevent the root storage from accidentally scanning user folders ... while this scan *should* never be triggered, it's good to have some failsafe to ensure that the users home contents don't end up getting scanned in the root storage Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-06-11 15:41:33 +02:00
Joas Schilling	c68718f90c	Remove dropped " ON " when join has no condition ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-06-08 08:03:35 +02:00
Joas Schilling	69eda9c0f6	Prevent harder to share your root ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-06-03 14:47:38 +02:00
Roeland Jago Douma	251a4d3097	Merge pull request #21143 from nextcloud/fix-password-changes-in-link-and-mail-shares ... Fix password changes in link and mail shares	2020-05-29 13:36:09 +02:00
Daniel Calviño Sánchez	45de42a6b8	Fix disabling send password by Talk without new password in mail shares ... When "send password by Talk" was disabled in a mail share it was possible to keep the same password as before, as it does not pose any security issue (unlike keeping it when "send password by Talk" is enabled, as in that case the password was already disclosed by mail). However, if a mail share is updated but the password is not set again only the hashed password will be available. In that case it would not make sense to send the password by mail, so now the password must be changed when disabling "send password by Talk". Note that, even if explicitly setting the same password again along with the "send password by Talk" property would work, this was also prevented for simplicity. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-05-29 02:46:12 +02:00
Daniel Calviño Sánchez	a426f84dbe	Fix enabling send password by Talk with same password in mail shares ... When "send password by Talk" is enabled in a mail share a new password must be also set. However, when the passwords of the original and the new share were compared it was not taken into account that the original password is now hashed, while the new one is not (unless no new password was sent, in which case the password of the original share was set in the new share by the controller, but that was already prevented due to both passwords being literally the same), so it was possible to set the same password again. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-05-28 21:51:28 +02:00
Daniel Calviño Sánchez	7569590514	Fix enabling send password by Talk with empty password in link shares ... When "send password by Talk" is enabled in a link share now a non empty password is enforced. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2020-05-28 21:51:28 +02:00
Roeland Jago Douma	28f8a445e4	Move the systemtags to core/src ... * Move to the handlebar loader from webpack Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>	2020-05-28 19:05:09 +00:00
Roeland Jago Douma	6aa6ab3e02	Add lazy events for the Node API ... Right now if you want to get events via the Node API you have to have a real instance of the Root. Which in turns sets up the whole FS. We should make sure this is done lazy. Else enabling the preview generator for example makes you setup the whole FS on each and every authenticated call. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-05-28 12:35:45 +02:00
Arthur Schiwon	653162a709	use the loginname to verify the old password in user password changes ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2020-05-26 16:53:25 +02:00
Morris Jobke	18b0d753f2	Do not read certificate bundle from data dir by default ... Before the resources/config/ca-bundle.crt was only used when the list of custom certificates was empty and the instance was not installed. But it should also be used when the list is empty and the instance is installed. This is inverting the logic to stop if the instance is not installed to use the default bundle. And it also does this when the list is empty. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-05-25 16:57:56 +02:00
Roeland Jago Douma	44d05bf356	Move core/js/files to webpack ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>	2020-05-22 20:28:31 +02:00
Roeland Jago Douma	cac844d915	Merge pull request #20814 from nextcloud/group-id-only ... dont get the group details if we only ask for the id	2020-05-21 09:53:45 +02:00
Morris Jobke	8123737a40	Revert "Compress the appstore requests by default" ... This reverts commit 6ffde128ad. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-05-20 13:37:28 +02:00
Morris Jobke	8bcd1c31da	Allow gzip encoded requests by default ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-05-20 13:37:28 +02:00
Morris Jobke	6ffde128ad	Compress the appstore requests by default ... In test it reduced the transfered data from 5 MB to 2 MB. This should reduce the load on the appstore significantly. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-05-20 09:51:07 +02:00
Morris Jobke	3e0d8df036	Cache appstore requests for 60 instead of 5 minutes ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-05-20 09:51:06 +02:00
Valdnet	8e3de41b4b	l10n: Add "The" before "Following"	2020-05-15 14:26:50 +08:00
Roeland Jago Douma	7c15c63b05	Merge pull request #20939 from nextcloud/enh/middleware/not_modified ... Move not modified check to the middleware	2020-05-13 09:04:56 +02:00
Roeland Jago Douma	4fbea316a7	Merge pull request #20897 from nextcloud/bugfix/httpcache ... Proxy server could cache http response when it is not private	2020-05-13 08:27:05 +02:00
Roeland Jago Douma	12fa748c49	Move the notmodified check to middleware where it belongs ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-05-13 08:11:24 +02:00
Roeland Jago Douma	6374c329e3	Merge pull request #20270 from nextcloud/enh/appframework/gzip ... Add AppFramework compression middleware to gzip responses	2020-05-12 12:20:39 +02:00
Clement Wong	979dd1b6f5	Fix http cache test ... Signed-off-by: Clement Wong <git@clement.hk>	2020-05-12 11:50:48 +02:00
Roeland Jago Douma	203d7eb1d3	Add AppFramework GZip middleware to gzip responses ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-05-12 09:09:48 +02:00
Roeland Jago Douma	35ff4aa1c6	Use random_bytes ... Since we don't care if it is human readbale. The code is backwards compatible with the old format. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-05-11 12:46:59 +02:00
Morris Jobke	16f4b43d94	Adjust tests to only return group IDs ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-05-08 08:10:38 +02:00
Robin Appelman	aa83b0b22d	dont get the group details if we only ask for the id ... currenty when getting the groups for a user, the full group object is always created (and cached) even if only the groupid is required Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-05-07 17:16:43 +02:00
Morris Jobke	a93d182bac	Merge pull request #20722 from nextcloud/enh/20693/etag-capabilities ... Set etag for capabilities endpoint	2020-05-04 10:22:01 +02:00
Roeland Jago Douma	a41ad78408	Update education bundle ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-05-01 09:52:58 +02:00
Roeland Jago Douma	c724eb24d5	Merge pull request #20380 from nextcloud/design/notification-mails ... Fix design and layout of notification mails	2020-05-01 08:53:39 +02:00
Jan-Christoph Borchardt	e981669e89	Fix notification mail tests ... Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	2020-05-01 03:00:42 +02:00
Robin Appelman	4e6d3d1880	Fix getDirectoryContent implementation for Jail wrapper ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-04-30 15:27:09 +02:00
MichaIng	ad60619655	Fix Argon2 options checks ... The minimum for memory cost is 8 KiB per thread. Threads must be checked and set first to allow checking against the correct memory cost mimimum. Options are now applied the following way: - If config.php contains the setting with an integer higher or equal to the minimum, it is applied. - If config.php contains the setting with an integer lower than the minimum, the minimum is applied. - If config.php does not contain the setting or with no integer value, the PHP default is applied. Signed-off-by: MichaIng <micha@dietpi.com> Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-04-30 10:18:46 +02:00
Daniel Kesselberg	df669a2936	Set etag for capabilities endpoint ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2020-04-29 15:26:46 +02:00
Morris Jobke	1738e17e20	Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare ... Fix resharing of federated shares that were created out of links	2020-04-27 11:05:34 +02:00
Morris Jobke	a64681a0fe	Merge pull request #19514 from sndrr/already-enabled-apps ... Already enabled apps	2020-04-27 11:00:16 +02:00
Morris Jobke	9b7e24a7a1	Merge pull request #19084 from nextcloud/bug/13556/wrong-paths-for-svg ... Make it possible to resolve svg's outside \OC::$SERVERROOT	2020-04-27 10:58:34 +02:00
Sander Ruitenbeek	3d9cd00c7b	Updated test to check for already enabled apps ... Signed-off-by: Sander Ruitenbeek <s.ruitenbeek@getgoing.nl>	2020-04-24 16:30:45 +02:00
Daniel Kesselberg	d766d09f01	Add test to ensure that symlinked apps_paths are not resolved ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2020-04-24 16:19:14 +02:00
Daniel Kesselberg	72a16b1779	Make it possible to resolve svg for apps_paths outside the document root ... Previous implementation assumes the app path is always a child \OC::$SERVERROOT. That's not always true. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2020-04-24 16:19:10 +02:00
Roeland Jago Douma	f4b8623d33	Allow specifying a default expiration date ... This overrides the max expiration date. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-04-24 16:18:20 +02:00
Julius Härtl	2eadf9d567	Do not create remember me cookie ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-04-23 19:12:54 +02:00
Roeland Jago Douma	c870b6ab2e	Fix new routing in settings etc ... Also prefix resources Unify the prefix handling Handle urls with and without slash Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-04-22 13:09:25 +02:00
Roeland Jago Douma	8f650feede	Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls ... Allow some apps to have root URLs in their own routing file	2020-04-21 16:00:34 +02:00
Julius Härtl	397ab1c3c5	Remove unneeded test since links have resharing permissions by default ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	2020-04-21 14:35:29 +02:00
Roeland Jago Douma	6c603e8e7d	Move to subfolders for preview files ... Else the number of files can grow very large very quickly in the preview folder. Esp on large systems. This generates the md5 of the fileid. And then creates folders of the first 7 charts. In that folder is then a folder with the fileid. And inside there are the previews. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-04-19 10:30:56 +02:00
Joas Schilling	250467e842	Extend tests for root url ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-04-18 11:21:28 +02:00
Roeland Jago Douma	16e6707f3f	Fix mailer test ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-04-17 16:39:49 +02:00
John Molakvoæ	36f9ad32f2	Merge pull request #20447 from liamjack/fix/13287/welcome_email ... Increase max-height on button in welcome email template	2020-04-17 09:42:49 +02:00
Morris Jobke	840bed9a85	Fix tests ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-04-17 09:00:59 +02:00
blizzz	d55f4183b5	Merge pull request #20505 from nextcloud/fix/noid/system-creds ... do not advertise nulled userId for for systemwide credentials	2020-04-16 11:53:24 +02:00
Roeland Jago Douma	bb4dedb015	Provide the proper language to the mailer ... Else we can't properly translate the footer in the recipients e-mail language. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	2020-04-16 09:04:13 +02:00
Arthur Schiwon	5437844b7e	fix credentialsManager documentation and ensure userId to be used as string ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2020-04-15 19:34:23 +02:00
Arthur Schiwon	f6cb452037	add DB tests for credentials manager ... these are actually expected to FAIL, because NULL as a userid is not allowed in the schema, but documented to be used on the source Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2020-04-15 16:44:28 +02:00
Morris Jobke	7fe8477830	Run cs:fix and fix HashWrapper code ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	2020-04-15 14:08:56 +02:00
Joas Schilling	5c0637bc90	Merge pull request #20138 from nextcloud/bugfix/noid/make-remote-checking-more-generic ... Make remote checking more generic	2020-04-15 12:48:49 +02:00
Roeland Jago Douma	95ad9ab4ac	Merge pull request #20401 from nextcloud/fix/login-sso-redirct ... Fix absolute redirect	2020-04-15 11:28:40 +02:00
Roeland Jago Douma	d63abebc93	Merge pull request #19351 from nextcloud/dav-upload-hash ... Return hashes of uploaded content for dav uploads	2020-04-15 10:23:22 +02:00
Joas Schilling	fd0c1a3bb2	Fix unit tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-04-15 08:06:51 +02:00
Joas Schilling	5e402f8aae	Check all remotes for local access ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2020-04-14 18:56:06 +02:00
Daniel Kesselberg	0ccaec9841	Fix jsunit tests ... JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2020-04-14 11:55:12 +02:00
Robin Appelman	c2677682c4	Return hashes of uploaded content for dav uploads ... hashes are set in "X-Hash-MD5", "X-Hash-SHA1" and "X-Hash-SHA256" headers. these headers are set for file uploads and the MOVE request at the end of a multipart upload. Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-04-13 12:57:27 +02:00
John Molakvoæ	b5a30d5cd6	Merge pull request #20426 from nextcloud/techdebt/psr2 ... It is done	2020-04-11 08:21:35 +02:00
John Molakvoæ	97de425a17	Merge pull request #20419 from nextcloud/dependabot/npm_and_yarn/various ... Bump p-limit from 2.2.2 to 2.3.0, @nextcloud/auth from 1.2.2 to 1.2.3, @babel/preset-env from 7.8.7 to 7.9.5, @nextcloud/event-bus from 1.1.3 to 1.1.4, @nextcloud/password-confirmation from 1.0.0 to 1.0.1, @nextcloud/l10n from 1.2.2 to 1.2.3, @nextcloud/initial-state from 1.1.1 to 1.1.2, core-js from 3.6.4 to 3.6.5 …	2020-04-11 08:18:14 +02:00
John Molakvoæ (skjnldsv)	0f135c7bd6	Bump acceptance tests ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	2020-04-10 17:07:14 +02:00
Christoph Wurst	28f8eb5dba	Add visibility to all constants ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-10 16:54:27 +02:00
Christoph Wurst	1584c9ae9c	Add visibility to all methods and position of static keyword ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-10 16:51:06 +02:00
Christoph Wurst	a7c8d26d31	Add visibility to all properties and move static keyword ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-10 16:48:31 +02:00
Christoph Wurst	1762a409f9	Merge pull request #20422 from nextcloud/techdebt/format-control-structs-classes-methods ... Format control structures, classes, methods and function	2020-04-10 16:38:23 +02:00
Roeland Jago Douma	eba3726e1e	Merge pull request #19495 from nextcloud/preview-generate-batch ... optimize batch generation of previews	2020-04-10 15:57:06 +02:00
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-10 14:19:56 +02:00
Robin Appelman	8f9bac26f8	fix preview generation tests ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-04-10 13:39:45 +02:00
Christoph Wurst	14c996d982	Use elseif instead of else if ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-10 10:35:09 +02:00
John Molakvoæ (skjnldsv)	6c49dc2d1f	Fix absolute redirect ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	2020-04-10 08:58:54 +02:00
Christoph Wurst	3a415e4139	Remove space between switch case and colon ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-09 16:17:53 +02:00
Christoph Wurst	a8a06a82d2	Remove trailing whitespaces from comments ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-09 16:09:23 +02:00
Christoph Wurst	44577e4345	Remove trailing and in between spaces ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-09 16:07:47 +02:00
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-09 13:54:22 +02:00
Christoph Wurst	2a529e453a	Use a blank line after the opening tag ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-09 11:50:14 +02:00
Christoph Wurst	41b5e5923a	Use exactly one empty line after the namespace declaration ... For PSR2 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-09 11:48:10 +02:00
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-09 10:16:08 +02:00
blizzz	e9795d01f1	Merge pull request #16035 from nextcloud/share-search-hide-on-match ... dont show remote and email options if we have an exact match for local user email	2020-04-09 00:08:34 +02:00
Christoph Wurst	85e369cddb	Fix multiline comments ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-08 22:24:54 +02:00
Robin Appelman	01c147a4a5	dont show remote and email options if we have an exact match for local user email ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2020-04-08 16:11:09 +02:00
Azul	62f7e6ba81	tests: fix failing header acceptance test ... The username is listed in a div with class `fullname` now. Signed-off-by: Azul <azul@riseup.net>	2020-04-07 14:57:20 +02:00
Christoph Wurst	1e086064f5	Move legacy classes from PSR0 to PSR4 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2020-04-07 08:48:00 +02:00