mirrors/nextcloud-documentation
3
0
Fork 0
mirror of https://github.com/nextcloud/documentation.git synced 2025-10-26 11:18:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #814 from owncloud/prwf

Browse Source 
add 5 label to pr. closes #697
This commit is contained in:
Morris Jobke 2015-02-04 15:24:54 +01:00
commit e174a7bf53
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
developer_manual/bugtracker/codereviews.rst
View File

@ -22,10 +22,13 @@ reviewed!
How will it work?
-----------------
#. A developer will submit his changes on GitHub via a pull request.
#. A developer will submit his changes on GitHub via a pull request (PR).
`GitHub:help - using pull requests <https://help.GitHub.com/articles/using-pull-requests>`_
#. Within the pull request the developer could already name other developers (using
@GitHubusername) and ask them for review.
#. Using Labels section on the right side, they add *"5 - To review"* label if the patch is
complete. If they have no permission to do that, other developers may add this Label in case
PR author had indicated.
#. Other developers (either named or at free will) have a look at the changes
and are welcome to write comments within the comment field.
#. In case the reviewer is okay with the changes and thinks all his comments and