From 6b2d51d6d1ea95a418a685fa5408567d78306d3d Mon Sep 17 00:00:00 2001 From: dartcafe Date: Sun, 2 Jan 2022 15:44:28 +0100 Subject: [PATCH 1/2] use --node-env instead of NODE_ENV= Signed-off-by: dartcafe --- developer_manual/digging_deeper/npm.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/developer_manual/digging_deeper/npm.rst b/developer_manual/digging_deeper/npm.rst index f98e96d24..7cc8d7dfb 100644 --- a/developer_manual/digging_deeper/npm.rst +++ b/developer_manual/digging_deeper/npm.rst @@ -27,7 +27,7 @@ For apps that use webpack, this might look like this: { "name": "myapp", "scripts": { - "build": "NODE_ENV=production webpack --progress --hide-modules --config webpack.prod.js" + "build": "webpack --node-env production --progress --hide-modules --config webpack.prod.js" }, "devDependencies": { "webpack": "^4.26.1", @@ -53,9 +53,9 @@ This command should be added to ``package.json`` as ``dev`` and ``watch`` scrip { "name": "myapp", "scripts": { - "build": "NODE_ENV=production webpack --progress --hide-modules --config webpack.prod.js", - "dev": "NODE_ENV=development webpack --progress --config webpack.dev.js", - "watch": "NODE_ENV=development webpack --progress --watch --config webpack.dev.js" + "build": "webpack --node-env production --progress --hide-modules --config webpack.prod.js", + "dev": "webpack --node-env development --progress --config webpack.dev.js", + "watch": "webpack --node-env development --progress --watch --config webpack.dev.js" }, "devDependencies": { "webpack": "^4.26.1", From b7f2a7db187c2e292c96035f2ce5182e886aa217 Mon Sep 17 00:00:00 2001 From: dartcafe Date: Sun, 2 Jan 2022 15:46:47 +0100 Subject: [PATCH 2/2] refer to current webpack packages Signed-off-by: dartcafe --- developer_manual/digging_deeper/npm.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/developer_manual/digging_deeper/npm.rst b/developer_manual/digging_deeper/npm.rst index 7cc8d7dfb..949676a53 100644 --- a/developer_manual/digging_deeper/npm.rst +++ b/developer_manual/digging_deeper/npm.rst @@ -30,8 +30,8 @@ For apps that use webpack, this might look like this: "build": "webpack --node-env production --progress --hide-modules --config webpack.prod.js" }, "devDependencies": { - "webpack": "^4.26.1", - "webpack-cli": "^3.1.2", + "webpack": "^5.65.0", + "webpack-cli": "^4.9.1", } } @@ -58,8 +58,8 @@ This command should be added to ``package.json`` as ``dev`` and ``watch`` scrip "watch": "webpack --node-env development --progress --watch --config webpack.dev.js" }, "devDependencies": { - "webpack": "^4.26.1", - "webpack-cli": "^3.1.2", + "webpack": "^5.65.0", + "webpack-cli": "^4.9.1", } }