From a1204451cb4c6e97bddef190e301271a8eb9f1cc Mon Sep 17 00:00:00 2001 From: Bernhard Posselt Date: Mon, 12 Jan 2015 13:44:18 +0100 Subject: [PATCH] fix documentation bugs --- developer_manual/app/changelog.rst | 12 ++++++++++-- developer_manual/app/info.rst | 8 ++++---- developer_manual/bugtracker/codereviews.rst | 5 ++--- 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/developer_manual/app/changelog.rst b/developer_manual/app/changelog.rst index 9e0bd12eb..a7151e6c8 100644 --- a/developer_manual/app/changelog.rst +++ b/developer_manual/app/changelog.rst @@ -23,8 +23,16 @@ Deprecations .. note:: Deprecations of constants and methods with namespaces! -* The following methods have been moved into the **OCP\\Template::** class instead of being namespaced directly: -**OCP\\image_path**, **OCP\\mimetype_icon**, **OCP\\preview_icon**, **OCP\\publicPreview_icon**, **OCP\\human_file_size**, **OCP\\relative_modified_date**, **OCP\\html_select_options**. Removal planned in **9.0** +* The following methods have been moved into the **OCP\\Template::** class instead of being namespaced directly, Removal planned in **9.0**: + + * **OCP\\image_path** + * **OCP\\mimetype_icon** + * **OCP\\preview_icon** + * **OCP\\publicPreview_icon** + * **OCP\\human_file_size** + * **OCP\\relative_modified_date** + * **OCP\\html_select_options** + * **OCP\\simple_file_size** has been deprecated in favour of **OCP\\Template::human_file_size**. Removal planned in **9.0** * The **OCP\\PERMISSION_** and **OCP\\FILENAME_INVALID_CHARS** have been moved to **OCP\\Constants::**. Removal planned in **9.0** * The **OC_GROUP_BACKEND_** and **OC_USER_BACKEND_** have been moved to **OC_Group_Backend::** and **OC_User_Backend::** respectively. Removal planned in **9.0** diff --git a/developer_manual/app/info.rst b/developer_manual/app/info.rst index bf168950d..78c8bd314 100644 --- a/developer_manual/app/info.rst +++ b/developer_manual/app/info.rst @@ -165,16 +165,16 @@ In case no database is specified it is assumed that all databases are supported. command ------- Defines a command line tool to be available. With the attribute 'os' the required operating system for this tool can be -specified. Valid values for the 'os' attribute are as returned by the php function `php_uname http://php.net/manual/en/function.php-uname.php`_. +specified. Valid values for the 'os' attribute are as returned by the php function `php_uname `_. lib --- -Defines a required php extension with required minimum and/or maximum version. The names for the libraries have to match the result as returned by the php function `get_loaded_extensions http://php.net/manual/en/function.get-loaded-extensions.php`_. -The explicit version of an extension is read from `phpversion http://php.net/manual/de/function.phpversion.php`_ - with some exception as to be read up in the code base `https://github.com/owncloud/core/blob/master/lib/private/app/platformrepository.php#L45`_ +Defines a required php extension with required minimum and/or maximum version. The names for the libraries have to match the result as returned by the php function `get_loaded_extensions `_. +The explicit version of an extension is read from `phpversion `_ - with some exception as to be read up in the `code base `_ os -- -Defines the required target operating system the app can run on. Valid values are as returned by the php function `php_uname http://php.net/manual/en/function.php-uname.php`_. +Defines the required target operating system the app can run on. Valid values are as returned by the php function `php_uname `_. owncloud -------- diff --git a/developer_manual/bugtracker/codereviews.rst b/developer_manual/bugtracker/codereviews.rst index d7293e08d..3ec7b1c66 100644 --- a/developer_manual/bugtracker/codereviews.rst +++ b/developer_manual/bugtracker/codereviews.rst @@ -23,12 +23,12 @@ How will it work? ----------------- #. A developer will submit his changes on GitHub via a pull request. - `GitHub:help - using pull requests`_ + `GitHub:help - using pull requests `_ #. Within the pull request the developer could already name other developers (using @GitHubusername) and ask them for review. #. Other developers (either named or at free will) have a look at the changes and are welcome to write comments within the comment field. -#. In case the reviewer is okay with the changes and thinks all his comments and +#. In case the reviewer is okay with the changes and thinks all his comments and suggestions have been take into account a :+1 on the comment will signal a positive review. #. Before a pull request will be merged into master or the corresponding @@ -53,7 +53,6 @@ Questions? Feel free to drop a line on the `mailing list`_ or join us on `IRC`_. .. _core repository: https://GitHub.com/owncloud/core -.. _GitHub: help - using pull requests: https://help.GitHub.com/articles/using-pull-requests .. _continuous integration server: https://ci.owncloud.org/ .. _mailing list: https://mailman.owncloud.org/mailman/listinfo/devel .. _IRC: http://webchat.freenode.net/?channels=owncloud-dev