diff --git a/developer_manual/app/container.rst b/developer_manual/app/container.rst index 277ee01e9..304e1d620 100644 --- a/developer_manual/app/container.rst +++ b/developer_manual/app/container.rst @@ -146,7 +146,7 @@ The container works in the following way: * The **database connection** is returned from the server container * Now **AuthorMapper** has all of its dependencies and the object is returned * **AuthorService** gets the **AuthorMapper** and returns the object -* **AuthorController** gets the **AuthorService** and finally the controller can be ``new``ed and the object is returned +* **AuthorController** gets the **AuthorService** and finally the controller can be instantiated and the object is returned So basically the container is used as a giant factory to build all the classes that are needed for the application. Because it centralizes all the creation of objects (the **new Class()** lines), it is very easy to add new constructor parameters without breaking existing code: only the **__construct** method and the container line where the **new** is being called need to be changed. diff --git a/developer_manual/bugtracker/triaging.rst b/developer_manual/bugtracker/triaging.rst index 9fd6b5dad..5c8f58440 100644 --- a/developer_manual/bugtracker/triaging.rst +++ b/developer_manual/bugtracker/triaging.rst @@ -108,8 +108,6 @@ An important step of bug triaging is trying to reproduce the bugs, this means, u This is needed in order to differentiate random/race condition bugs of reproducible ones (which may be reproduced by developers too; and they can fix them). -To reproduce an issue, please refer to our testing documents: :doc:`../testing/index` - If you can't reproduce an issue in a newer version of Nextcloud, it is most likely fixed and can be closed. Comment that you failed to reproduce the problem, and if the reporter can confirm (or doesn't respond for a long time), you can close the issue. Also, be sure to add what exactly you tested with - the Nextcloud Master or a branch (and if so, when), or did you use a release, and if so - what version? Finalizing and tagging