mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
ec74f8d274
nextcloud-desktop/admin/osx
History
Jyrki Gadinger 5ca272cb49 fix(mac-crafter): use AsyncParsableCommand everywhere 
For some reason using `ParsableCommand` structs as subcommands of an
`AsyncParsableCommand` does not correctly handle all passed CLI
arguments.

The behaviour before this commit was as follows:

```
% mac-crafter create-dmg
Error: Missing expected argument '<app-bundle-path>'
Help:  <app-bundle-path>  Path to the desktop client app bundle.
Usage: mac-crafter create-dmg <app-bundle-path> [--product-path <product-path>] [--build-path <build-path>] [--app-name <app-name>] [--apple-id <apple-id>] [--apple-password <apple-password>] [--apple-team-id <apple-team-id>] [--package-signing-id <package-signing-id>] [--sparkle-package-sign-key <sparkle-package-sign-key>]
  See 'mac-crafter create-dmg --help' for more information.

% mac-crafter create-dmg /tmp/Nextcloud.app
OVERVIEW: Create a DMG for the client.

USAGE: mac-crafter create-dmg <app-bundle-path> [--product-path <product-path>] [--build-path <build-path>] [--app-name <app-name>] [--apple-id <apple-id>] [--apple-password <apple-password>] [--apple-team-id <apple-team-id>] [--package-signing-id <package-signing-id>] [--sparkle-package-sign-key <sparkle-package-sign-key>]

ARGUMENTS:
  <app-bundle-path>       Path to the desktop client app bundle.
[...]
```

After changing every command struct to derive from
`AsyncParsableCommand`:

```
% mac-crafter create-dmg
Error: Missing expected argument '<app-bundle-path>'
Help:  <app-bundle-path>  Path to the desktop client app bundle.
Usage: mac-crafter create-dmg <app-bundle-path> [--product-path <product-path>] [--build-path <build-path>] [--app-name <app-name>] [--apple-id <apple-id>] [--apple-password <apple-password>] [--apple-team-id <apple-team-id>] [--package-signing-id <package-signing-id>] [--sparkle-package-sign-key <sparkle-package-sign-key>]
  See 'mac-crafter create-dmg --help' for more information.

% mac-crafter create-dmg /tmp/Nextcloud.app
Required command "create-dmg" is missing, installing...
[...]
```

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-07-22 09:49:22 +02:00
..
mac-crafter fix(mac-crafter): use AsyncParsableCommand everywhere 2025-07-22 09:49:22 +02:00
sparkle docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
CMakeLists.txt fix(macOS): Enable debugger to attach to process. 2025-07-21 14:11:16 +02:00
create_mac.sh.cmake docs(reuse): Migrate to SPDX header 2025-05-06 09:49:30 +02:00
deny_autoupdate_com.owncloud.desktopclient.plist OS X: Document how to disable the auto updater 2014-02-13 14:11:04 +01:00
deny_autoupdate_com.owncloud.desktopclient.plist.license docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
DMGBackground.png docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
DMGBackground.png.license docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
DS_Store.in Make it buildable as bundle on OSX 2012-04-16 13:03:20 +02:00
DS_Store.in.license docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
gen_sym_files.py docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
installer-background_2x.png Update isntaller background for OSX 2018-11-06 10:39:10 +01:00
installer-background.png Update isntaller background for OSX 2018-11-06 10:39:10 +01:00
installer-background.svg Update isntaller background for OSX 2018-11-06 10:39:10 +01:00
macosx.entitlements.cmake fix(macOS): Enable debugger to attach to process. 2025-07-21 14:11:16 +02:00
macosx.entitlements.cmake.license docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
macosx.pkgproj.cmake fix: move array to correct value in dict 2025-04-07 14:56:42 +02:00
macosx.pkgproj.cmake.license docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
make_universal.py docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
post_install.sh.cmake docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
pre_install.sh.cmake docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
sign_app.sh docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00
sign_dmg.sh docs(reuse): Migrate to SPDX header 2025-05-07 09:28:53 +02:00