nextcloud-desktop/src
Mariusz Wasak dcc33f3417 Fix for #1382 "linux client crashes for no discernable reason"
There in no "return" in
PropagateUploadFileCommon::slotStartUpload in if (prevModtime != _item-
>_modtime) {... }

There is possibility that
PropagateItemJob::done(status, errorString)
maybe called two times from PropagateUploadFileCommon::slotStartUpload
1. in if (prevModtime != _item->_modtime) {... }
2. in if (fileIsStillChanging(*_item)) {..}
if changes in files are frequent the second call is possible.

This two calls has effect in PropagatorCompositeJob::slotSubJobFinished
and job is removed two times in _runningJobs.remove(i);
(the second time with argumetnt -1 (because first call removed job).

This return was removed in commit
efc039863b - by accident I think.

Good simulation is to synchronize firefox profile with frequent page
refresh.

Signed-off-by: Mariusz Wasak <mawasak@gmail.com>
2019-09-18 18:18:12 +02:00
..
3rdparty E2E UI setup poligh 2019-05-11 19:20:19 +02:00
cmd Fix the hiddensync state in the UI + also sync hidden in cmd 2018-09-01 16:30:27 +02:00
common initialize _modtime to prevent undefined usage 2019-09-09 19:23:30 +02:00
crashreporter More fixes for the OSX daily builds 2018-06-21 15:22:53 +02:00
csync Numoerous safe conversions implemented. Added additional Utility::convertSizeToDWORD for windows builds. 2019-09-08 11:33:20 +02:00
gui Merge branch 'master' into ivan/remote-size-retrieved-race-condition 2019-09-16 19:17:00 +02:00
libsync Fix for #1382 "linux client crashes for no discernable reason" 2019-09-18 18:18:12 +02:00
CMakeLists.txt Fixed wrongly formatted args for win32 linker flags resulting in 'unrecognized option' for all of them. Remark: /WL is for VS only, useless (and not necessary for msvc cmd) 2019-09-08 16:09:58 +02:00