mirror of
https://github.com/nextcloud/desktop.git
synced 2025-10-26 11:17:43 +00:00
a313ea6aff
`-2` used to mean "Use global limits", which no longer exist since 3.17.0. As any negative value results in the auto bandwidth limiter to engage, this could result in unexpected slower sync speeds after a client upgrade. Let's just keep handling that value and assume that we want to use unlimited bandwidth. Fixes #8743 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
107 lines
3.8 KiB
C++
107 lines
3.8 KiB
C++
/*
|
|
* SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
|
|
* SPDX-FileCopyrightText: 2017 ownCloud GmbH
|
|
* SPDX-License-Identifier: CC0-1.0
|
|
*
|
|
* This software is in the public domain, furnished "as is", without technical
|
|
* support, and with no warranty, express or implied, as to its usefulness for
|
|
* any purpose.
|
|
*/
|
|
|
|
#include <qglobal.h>
|
|
#include <QTemporaryDir>
|
|
#include <QtTest>
|
|
|
|
#include "common/utility.h"
|
|
#include "folderman.h"
|
|
#include "account.h"
|
|
#include "accountstate.h"
|
|
#include "configfile.h"
|
|
#include "testhelper.h"
|
|
#include "logger.h"
|
|
|
|
using namespace OCC;
|
|
|
|
class TestAccount: public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
private slots:
|
|
void initTestCase()
|
|
{
|
|
OCC::Logger::instance()->setLogFlush(true);
|
|
OCC::Logger::instance()->setLogDebug(true);
|
|
|
|
QStandardPaths::setTestModeEnabled(true);
|
|
}
|
|
|
|
void testAccountDavPath_unitialized_noCrash()
|
|
{
|
|
AccountPtr account = Account::create();
|
|
[[maybe_unused]] const auto davPath = account->davPath();
|
|
}
|
|
|
|
void testAccount_isPublicShareLink_data()
|
|
{
|
|
QTest::addColumn<QString>("url");
|
|
QTest::addColumn<bool>("expectedResult");
|
|
QTest::addColumn<QString>("expectedDavUser");
|
|
|
|
QTest::newRow("plain URL") << "https://example.com" << false << "";
|
|
QTest::newRow("plain URL, trailing slash") << "https://example.com/" << false << "";
|
|
QTest::newRow("share link") << "https://example.com/s/rPZLaTKfWct37Nd" << true << "rPZLaTKfWct37Nd";
|
|
QTest::newRow("share link, trailing slash") << "https://example.com/s/rPZLaTKfWct37Nd/" << false << "";
|
|
QTest::newRow("subpath containing /s/ (looks like share link)") << "https://example.com/s/nextcloud" << true << "nextcloud";
|
|
QTest::newRow("subpath containing /s/, trailing slash") << "https://example.com/s/nextcloud/" << false << "";
|
|
QTest::newRow("subpath containing /s/, share link") << "https://example.com/s/nextcloud/s/rPZLaTKfWct37Nd" << true << "rPZLaTKfWct37Nd";
|
|
QTest::newRow("subpath containing /s/, share link, trailing slash") << "https://example.com/s/nextcloud/s/rPZLaTKfWct37Nd/" << false << "";
|
|
}
|
|
|
|
void testAccount_isPublicShareLink()
|
|
{
|
|
AccountPtr account = Account::create();
|
|
|
|
QFETCH(QString, url);
|
|
QFETCH(bool, expectedResult);
|
|
QFETCH(QString, expectedDavUser);
|
|
|
|
account->setUrl(QUrl{url});
|
|
QCOMPARE(account->isPublicShareLink(), expectedResult);
|
|
QCOMPARE(account->davUser(), expectedDavUser);
|
|
}
|
|
|
|
void testAccount_setLimitSettings_globalNetworkLimitFallback()
|
|
{
|
|
using LimitSetting = Account::AccountNetworkTransferLimitSetting;
|
|
AccountPtr account = Account::create();
|
|
|
|
const auto setLimitSettings = [account](const LimitSetting setting) -> void {
|
|
account->setDownloadLimitSetting(setting);
|
|
account->setUploadLimitSetting(setting);
|
|
};
|
|
|
|
const auto verifyLimitSettings = [account](const LimitSetting expectedSetting) -> void {
|
|
QCOMPARE_EQ(expectedSetting, account->downloadLimitSetting());
|
|
QCOMPARE_EQ(expectedSetting, account->uploadLimitSetting());
|
|
};
|
|
|
|
// the default setting should be NoLimit
|
|
verifyLimitSettings(LimitSetting::NoLimit);
|
|
|
|
// changing it to ManualLimit should succeed
|
|
setLimitSettings(LimitSetting::ManualLimit);
|
|
verifyLimitSettings(LimitSetting::ManualLimit);
|
|
|
|
// changing it to AutoLimit should succeed
|
|
setLimitSettings(LimitSetting::AutoLimit);
|
|
verifyLimitSettings(LimitSetting::AutoLimit);
|
|
|
|
// changing it to LegacyGlobalLimit (-2) should fall back to NoLimit
|
|
setLimitSettings(LimitSetting::LegacyGlobalLimit);
|
|
verifyLimitSettings(LimitSetting::NoLimit);
|
|
}
|
|
};
|
|
|
|
QTEST_APPLESS_MAIN(TestAccount)
|
|
#include "testaccount.moc"
|