Commit Graph

136 Commits

Author SHA1 Message Date
Claudio Cambra
fa33dd61cf Only present proxy password delete error if it is not a "does not exist" error
Prevent error on deletion when the proxy password does not exist

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-08 12:41:03 +08:00
Camila Ayres
b9b9813655
Update config value when serverHasValidSubscription when accounts are added or removed.
To give priority to server susbscriptions and keep listing the right update channels.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
d0f87c3496
Save serverHasValidsubcription in the account.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
bf09295a63
Change the list of update channels when server capabilities change.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
d080261692
Use const auto.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-29 12:40:24 +01:00
Camila Ayres
33cc5a2017
Validate http_user value before assigning it to user in the config file.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-29 12:40:24 +01:00
Claudio Cambra
e3979ea52f Do not apply override server url as account url if this is a multi-server JSON string
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Matthieu Gallien
274feb9587 remove deprecated code only usefull for very old Qt releases
we require Qt > 6.0 so any conditionnal code for older releases can be
deleted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-12 11:14:26 +02:00
Claudio Cambra
37c77d81ec
Use full user id at host with port for proxy password keychain
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:52 +08:00
Claudio Cambra
ef59399804
Use qtkeychain directly in account manager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:52 +08:00
Claudio Cambra
a8c5cbced4
Add logging on error for proxy password saving
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:51 +08:00
Claudio Cambra
70e7bcf9a0
Simplify proxy password keychain keys
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:51 +08:00
Claudio Cambra
01f8199157
Use better keychain chunk job constructors
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:51 +08:00
Claudio Cambra
2d0c069039
Get intended default values for bw limit settings for account when nothing is set
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:51 +08:00
Claudio Cambra
2803690285
KeychainChunk job exec is synchronous, do not bother with signals in account manager use
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:50 +08:00
Claudio Cambra
5db01d4849
Ensure keychain chunk jobs in account manager run as intended
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:50 +08:00
Claudio Cambra
e3b002a52d
Use single-defined constexpr string for proxy password keychain key
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:50 +08:00
Claudio Cambra
770beba692
Store accounts' proxy passwords in keychain
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:50 +08:00
Claudio Cambra
3956612ac6
Save and restore account-specific network settings in account maanger
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:48 +08:00
Camila Ayres
7d27c53b3b
Remove resolved TO DO comment.
Subscription and channel are supposed to be a general setting, not per user.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:41 +02:00
Camila Ayres
7fa0378883
Add user specific setting for server hasValidScriptionValue.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:38 +02:00
Claudio Cambra
1689f7b613 Assert validity of accountstate and its accountptr when adding it
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-06-25 23:01:13 +08:00
Claudio Cambra
74a78242e2 Remove overwrought loadFromSettings method from AccountState
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-06-25 23:01:13 +08:00
Camila Ayres
0ae7695d5c
Fix: remove failure to import legacy account notification.
- It was being displayed even on a fresh install.
- We are already displaying a notification when there are accounts to be
imported and we ask the user on what to do.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-01-25 12:23:37 +01:00
Camila
44e8e4b2e9 Fix crash when clicking on import legacy account dialog 'Skip' button.
- mac OS only: With Qt::WA_DeleteOnClose the dialog was being deleted twice.

Signed-off-by: Camila <hello@camila.codes>
2023-11-07 14:33:48 -03:00
Matthieu Gallien
fcd5a86349 signals/slots need to have fully qualified arguments
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-10-17 09:32:34 +02:00
Matthieu Gallien
d517cbfd68 fix build by making unique_ptr not const if we std::move it
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-09-26 15:40:38 +02:00
Camila
d6eb5c5c7c Address PR comments.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
a23b9f1280 User "1" instead of "one" in thelegacy import dialogs.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
b9fd13695c Fix QMessageBox 'skip' button functionality for importing legacy account.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
0db5e78d6f Improve text and buttons of notification dialogs used during legacy import.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
6f1e1612b1 Only show message with migration status in the end of the process.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
5e1d2a7dac Migrates all legacy accounts.
Signed-off-by: Camila <hello@camila.codes>
2023-09-13 07:18:17 -03:00
Camila
f69dea0a94
Migrate http_user to webflow_user and dav_user.
- Add {} for single line condition, const auto and fix comments.
- Save the legacy account data first in _settingsMap, so the legacy config file
does not get changed in the migration process.
- Legacy dav_user should stay only as dav_user in the new config.
- Compare davUser and prettyName only when new user id needs to be retrieved.

Signed-off-by: Camila <hello@camila.codes>
2023-09-01 15:09:28 +02:00
Claudio Cambra
f260bbf9f4 Remember server colors across restarts, enabling correct color before capabilities fetched
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-08-24 08:34:41 +08:00
Claudio Cambra
c8f8c9cd2c Don't ask user whether to import legacy account configs if forcing legacy import
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 21:23:43 +08:00
Claudio Cambra
e43f627c9f Add forceLegacyImport property to accountmanager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 21:23:43 +08:00
Claudio Cambra
6eb2fd1cc0 Notify result of attempted account import with messagebox
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 21:23:43 +08:00
Claudio Cambra
fba808103c Ask before attempting to import legacy accounts
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 21:23:43 +08:00
Claudio Cambra
0ee850009b Correctly migrate accounts that have possible webflow but not correct authtype in settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-08 22:56:33 +08:00
Claudio Cambra
081871d792 Set discovered legacy config file path during account migration
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-08 22:56:33 +08:00
Claudio Cambra
bdc0ebd527 Restore a specific enum from AccountsManager::restore rather than vague boolean
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-08 22:56:33 +08:00
Claudio Cambra
4da074e4cb Attempt sign in when an account state is added in AccountManager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-08 21:35:48 +08:00
alex-z
90e3a37a20 E2EE. Fix freeze on metadata checksum validation.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-05-08 11:29:16 +02:00
Claudio Cambra
7084310a9f Remove unused AccountState::writeToSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
c496e73200 Correctly parse account server url when migration from legacy config
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
174a486428 Stop checking config to migrate at current path if could not read file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
39914e5166 More concisely clean paths of trailing slash URLs in restore old config migration method of AccountManager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
alex-z
2bd1c272a6 Allow specifying the server force override URL and local sync folder path via command line.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-17 17:27:19 +01:00
Claudio Cambra
14bd744df6 Use std::make_unique rather than manually build unique_ptr for oCSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00