Using `"*"` will result in a different GUID with each invocation of the
linker (`light.exe`), which can break automated installations when a
localised version of the installer was loaded.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Stopping the Windows Explorer process does not always work. Per default
the MSI Restart Manager will display a warning message after a timeout,
and not attempt to restart Explorer afterwards -- resulting in a black
screen if no other window is open.
Setting the property `MSIRMSHUTDOWN` to `1` will force the termination
of the process when the timeout is reached, which finally allows the
Explorer to be restarted.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
The MSIs we distribute perform so-called "major upgrades".
From the Microsoft docs, we learn that...
> A typical major upgrade **removes a previous version** of an
> application and installs a new version.
Indeed that was the case -- the previous version is uninstalled
completely before the new version gets installed. Since we install an
extension that's loaded by explorer, the installer will ask the user to
restart Windows Explorer during the uninstallation of the previous
version (and restarting that might not always work as expected).
There is a way to change this behaviour though, using Wix3's
`MajorUpgrade` element. Through its `Schedule` property it's possible
to define when the removal of the previous version should occur.
The previous value `afterInstallInitialize` is one of two values that
perform a complete uninstall/install sequence. The new value
`afterInstallExecute` will install new files on top of the previous
installation (depending on the `REINSTALLMODE` I guess) and remove
older files that are not present.
In the case of the extensions this means that the .dlls from the
previous installation will not be touched, as long as the version
embedded in the DLL info didn't change. This results in the installer
no longer requesting Windows Explorer to restart, which is a big plus :D
I also changed the REINSTALLMODE to `dmus` to allow downgrades as well.
With this change, the request to restart Windows Explorer should
hopefully happen only once an installation was made using an MSI that
contains this change. Further updates will only request a restart if
the DLL version of these extensions change...
See also:
- https://learn.microsoft.com/en-us/windows/win32/msi/major-upgrades
- https://docs.firegiant.com/wix/schema/wxs/majorupgrade/#attributes:~:text=Schedule
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
shoudl enable replacing files during install happen only when needed
instead of always
will need to take care of migration from older releases
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
building all the translated installers takes about ~1 minute each, so
keep that in mind when adding extra translations ...
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
the base translations come from WixUI itself
There are still some untranslated strings in Nextcloud.wxs, we need to
take care of them at a later point. As a first step this is good
enough.
This commit serves as a proof-of-concept, the languages I used here will
change depending on what we want to support.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
that image was supposed to be usable for cross compilation from Linux to
build a Windows release
probably never worked
not working anymore but creating confusion
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
creating the registry keys via installer for the current user is not
enough to have the feature enabled for all user accounts on a given
machine
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Even though we only create a program shortcut in the Start Menu, try to make administrators lives easier by not diverging feature and option naming.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Removes all Explorer Navigation Pane entries for a given ApplicationName, specified in NavRemove.ini in the working directory.
Also compiles a DLL with the same behaviour that exports:
- RemoveNavigationPaneEntries
Both tool variants are Mutex-protected.
Statically linked, optimized for binary size, no Qt dependencies.
Signed-off-by: Michael Schuster <michael@schuster.ms>
The helper DLL will be utilized by Windows Installer with Custom Actions defined in the NCMsiHelper.wxs WiX fragment.
Exports:
- ExecNsisUninstaller
- RemoveNavigationPaneEntries
Signed-off-by: Michael Schuster <michael@schuster.ms>
The last translation update from Transifex was done in 2017, so the scripts and settings were never used for Nextcloud.
This commit removes the unused scripts and "Auto-generated" comments in the translation files.
Some files have been modified over time either way and MSI will replace NSIS soon.
Signed-off-by: Michael Schuster <michael@schuster.ms>
