mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
18,999 Commits 194 Branches 287 Tags 562 MiB
e30188d8e4
Commit Graph

8941 Commits

Author SHA1 Message Date
Claudio Cambra
e30188d8e4 Handle conversion from input QComboBox index to update channel string more safely 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-08 19:06:58 +08:00
Claudio Cambra
71fde8876e Fix channel string check in general settings' slotUpdateChannelChanged 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-08 19:06:58 +08:00
alex-z
90e3a37a20 E2EE. Fix freeze on metadata checksum validation. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-05-08 11:29:16 +02:00
alex-z
77f59c26d3 Remove some SQL debug logs to unclutter the output. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-05-04 14:42:10 +02:00
alex-z
cda8da3e96 Edit locally. Fix crash on _chekTokenJob pointer deref. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-05-04 10:49:58 +02:00
alex-z
f39a0903c5 Implement missing share settings 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-27 12:54:54 +02:00
alex-z
da6a7d3dac Unlock Office files when they are closed. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-25 12:54:37 +02:00
allexzander
8ef21545f5
Merge pull request #5613 from nextcloud/bugfix/sharees-parse-lookup 
Parse sharees 'lookup' key to include federated sharees.
 2023-04-24 08:37:34 +02:00
xavi-b
5113802daf Fix MacOS UTF-8 normalization issue 
Signed-off-by: xavi-b <developer@xavi-b.fr>
 2023-04-24 00:52:17 +08:00
Claudio Cambra
348c2536ce Remove unneeded setupFinished signal from EditLocallyJob 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-04-23 22:48:41 +08:00
Claudio Cambra
401ecd8e3c Ensure errors are emitted and loading dialog destroyed when fatal errors are met during edit locally 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-04-23 22:48:41 +08:00
Claudio Cambra
e836ff4a12 Provide error when erasing the blacklist error for an item fails during edit locally 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-04-23 22:48:41 +08:00
Claudio Cambra
6431d66aeb Remove unnecessary signalling response to start edit locally, just start it within the job 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-04-23 22:48:41 +08:00
Matthieu Gallien
9c8b624ef7 protect all access to shared data by mutexes 
separate public methods that must lock and private methods that must not
lock

will avoid deadlock or unprotected accesses

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-21 10:32:43 +02:00
Matthieu Gallien
c2d72109b6 protext all access to _logstream with the existing mutex 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-21 10:32:43 +02:00
Claudio Cambra
1f1d9d6dba Ensure we are making all file modifications under mutex protection 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-04-21 10:32:43 +02:00
Claudio Cambra
711359ef43 Ensure we are closing current log file before entering next log file 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-04-21 10:32:43 +02:00
alex-z
3a00c1d43f Edit locally. Elide loading dialog filename label middle. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-20 14:16:07 +02:00
alex-z
6bb0640988 Parse sharees 'lookup' key to include federated sharees. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-18 17:45:42 +02:00
Matthieu Gallien
94869783d3 allow to read v1.2 from buggy v3.8.0 client 
will consider v1.2 stored encryption status in DB to be equivalent to v1
due to bugs in the v3.8.0 release

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-12 15:46:51 +02:00
Matthieu Gallien
7118fc4650 use a better name for encryption status attributes 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-12 15:46:51 +02:00
Matthieu Gallien
619607b054 properly preserve the format of e2ee metadata during DB operations 
before this patch we may put the e2ee version format to v1.2 when it was
not the case

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-12 15:46:51 +02:00
Camila
6a4d6b9c97 Alway add the item at the end of the layout. 
Signed-off-by: Camila <hello@camila.codes>
 2023-04-12 10:16:47 +02:00
Claudio Cambra
eed5ca17bd Enter next log file if the current log file is larger than 512 KB when writing log line 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-04-11 23:10:03 +02:00
Matthieu Gallien
5cb3266f7f fix compilation with clazy and fully-qualified-moc-types checks enabled 
will make all signals and slots be using fully qualified data types

makes code safer

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-11 11:34:00 +02:00
alex-z
54c13a560d Edit locally. Restart current folder sync immediately after file opened. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-11 09:50:51 +02:00
Matthieu Gallien
a852eda937 in case server has no private key, let e2ee init fail 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-07 16:08:23 +02:00
Valdnet
1f8239b13f i18n: Separate words 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2023-04-07 10:35:51 +02:00
Valdnet
8ed69d1e95 i18n: Separate words 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2023-04-07 10:35:51 +02:00
Valdnet
06b2f2b736 i18n: Add dot 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2023-04-07 10:35:51 +02:00
alex-z
a428c17c37 Do not display error status and messages when aborting a sync during hydration request in VFS mode. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-06 22:26:35 +02:00
alex-z
31c3aee447 Fix unit tests SecureFileDrop 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-05 12:21:28 +02:00
Matthieu Gallien
c9cf248e5d
fix compilation 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-04 18:01:26 +02:00
Matthieu Gallien
b0c69481f2
try different permutation to try to recover the broken checksum 
will only accept a checksum that can be computed from proper data

should still be safe

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-04 17:41:17 +02:00
Matthieu Gallien
a76d9fe46d sort encrypted files by their id to compute checksum 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-04 15:06:05 +02:00
Matthieu Gallien
5b1238ddb1
compilation fixes for windows 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 18:06:10 +02:00
Matthieu Gallien
6bf4570b99
compatibility with final file drop implementation 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
e22b130d98
prevent syncing with downgraded metadata format 
should prevent a malicious server admin to make clients fallback to
older vulnerable metadata format

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
593ad6ee91
better track encrypted item status 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
8659df2266
prevent downgrading e2ee metadata format after initial migration 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
b121a127c1
improve logging when receiving metadata for encrypted folder 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
6fb16ce5f4
when uplaoding e2ee metadata add an empty filedrop entry 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
8b10b3a926
optimize the computation of checksum for metadata 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
8ec5518d8d
checksum has to be computer from the encrypted metadataKey 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
7c655cf679
use a getter to query encryption status 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00
Matthieu Gallien
1e018d1e56
display some logs when checksum verification is failed 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00
Matthieu Gallien
ee3c18f9f2
put sane order over #include 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00
Matthieu Gallien
f181b91875
when migrating older metadata, do not check missing checksum 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00
Matthieu Gallien
d1c18ecf2a
when uploading new e2e metadata, adds a checksum 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00
Matthieu Gallien
1b14c127a4
check checksum when getting e2ee metadata 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00