Camila Ayres
e38a9f181a
Only check for external storage permissions when it is a folder.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-05 12:58:36 +02:00
Camila Ayres
0965deaa2f
Remove commented out code.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-05 12:56:52 +02:00
Camila Ayres
9b2780c99c
Improve logs for rename check.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-05 12:56:52 +02:00
Camila Ayres
591808f25e
Check if file is already in database before processing rename.
...
- The rename check was not happening since it was hitting error "Move without permission to rename base file"
- The file was then processed as a new file
- Also check #6535 .
Possible workaround for #6549 .
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-05 12:56:51 +02:00
Camila Ayres
9bd4ef1b83
Translate enterprise channel explanation string.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:41 +02:00
Camila Ayres
bc05dc8a18
Use NEXTCLOUD_DEV to check if client is branded instead of checking for string.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:41 +02:00
Camila Ayres
cdd940f669
Remove const from POD in method declaration.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:41 +02:00
Camila Ayres
7d27c53b3b
Remove resolved TO DO comment.
...
Subscription and channel are supposed to be a general setting, not per user.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:41 +02:00
Camila Ayres
dd5e18e8c5
If the client is branded the default update channel is stable.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:40 +02:00
Camila Ayres
52e15ff92e
Separate the list of valid update channels for enterprise and non-enterprise.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:40 +02:00
Camila Ayres
e51324dc9a
Fix the logic to determine update channels available, default value and what info to show the user.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:40 +02:00
Camila Ayres
0663282b2b
Update desktopEnterpriseChannel value when capabilities change.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:40 +02:00
Camila Ayres
615805dd03
Save desktopEnterpriseChannel value in the config file.
...
The default should be what is returned by defaultUpdateChannel()
when desktopEnterpriseChannel is not available.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:40 +02:00
Camila Ayres
4884fbee87
Add desktopEnterpriseChannel to the capabilities check.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:39 +02:00
Camila Ayres
0274cd912b
Only list enterprise for customers not running branded clients.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:39 +02:00
Camila Ayres
4de91cba23
NextcloudDev is not a branded client.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:39 +02:00
Camila Ayres
aa239cd7bd
Add enterprise explanation to message shown when user changes update channel.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:39 +02:00
Camila Ayres
e8b823670c
Do not show enterprise channel for branded clients.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:39 +02:00
Camila Ayres
ee032827a1
List enterprise update channel when available.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:39 +02:00
Camila Ayres
a4c114e658
Update server hasValidSubscription if capabilities change for account.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:38 +02:00
Camila Ayres
7fa0378883
Add user specific setting for server hasValidScriptionValue.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:38 +02:00
Camila Ayres
e0d7377680
Add general config setting for server hasValidSubscription.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:38 +02:00
Camila Ayres
15d75183c2
Check if server has valid subcription.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-04 10:16:38 +02:00
Camila Ayres
4de3107383
Enable RVO (return value optimization).
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:11 +02:00
Camila Ayres
13b7c539e2
Remove unused updatesegment option from updater query.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:11 +02:00
Camila Ayres
e5c2c8fd96
Use only const auto in obvious pointer.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:11 +02:00
Camila Ayres
f581aa1e4b
Use default in switch.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:11 +02:00
Camila Ayres
364b329d55
Rename var in configfile.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:10 +02:00
Camila Ayres
fbadd55a18
Remove commented out line.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:10 +02:00
Camila Ayres
5f0c74d43d
Improve text displayed when user switches update channel.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:10 +02:00
Camila Ayres
eb8b775f4d
Enforce the update channel based on the current client installed.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:10 +02:00
Camila Ayres
3f9bf0ab9c
Add versionSuffix function to Theme.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:10 +02:00
Camila Ayres
07f31f7b36
Use the value from MIRALL_VERSION_SUFFIX as the default update channel.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:10 +02:00
Camila Ayres
2ac3b6947c
List daily update channel in the general settings view.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:09 +02:00
Camila Ayres
d82608d0aa
Clean up code in GeneralSettings.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:09 +02:00
Camila Ayres
82f27e0e2a
Adds info about daily builds to message shown if user changes update channel.
...
- Also makes the explanation more concise.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:09 +02:00
Camila Ayres
e2f71e6fb3
Modernize ConfigFile::updateChannel and Updater::getQueryParams.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:09 +02:00
Camila Ayres
60174c63d5
Add daily update channel.
...
- Set update channel options list in slotUpdateInfo.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-07-03 16:32:09 +02:00
Matthieu Gallien
c5c8f0f11b
avoid deadlock: cancel hydration requests coming from itself
...
our current infrastructure will cause a deadlock for any hydration
requests coming from desktop files client itself
the main thread is responsible for executing the hydration request but
if the same thread is already blocked waiting for the hydration to
happen, both (open system call and hydration request handling) process
will never be completed and wait for each over in a stuck cycle
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-07-01 16:10:02 +02:00
Matthieu Gallien
79c5791dfe
avoid logs too verbose and with binary data
...
with those logs, hydrating is causing too much log to be written and
after some time (with big fixles), hydration is failing
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-07-01 15:40:24 +02:00
Claudio Cambra
531e01d574
Fix sharePath for virtual paths using suffix vfs mode
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-06-28 18:29:19 +02:00
Camila Ayres
7b9b7bc3b6
Add sync option for nextcloudcmd.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-06-28 18:18:08 +02:00
Camila Ayres
d7c8365b05
Use readable variable names.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-06-28 18:18:08 +02:00
Camila Ayres
b3ff87b73e
Make warning text before deleting all files more clear and concise.
...
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-06-28 18:18:08 +02:00
Camila Ayres
1f88052a8e
Fix #3144 : check for promptDeleteAllFiles config setting before emitting signal to display warning.
...
The signal is not connected to any slot when running nextcloudcmd.
The callback to finish the sync was never being called because the check for the config was done in the slot,
which was never called.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-06-28 18:18:08 +02:00
Claudio Cambra
0757e94b50
Ensure stripping of suffix vfs placeholder file's suffix when issuing delete command to server
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-06-28 18:17:19 +02:00
Claudio Cambra
b00a5934c9
Allow deletion of virtual suffix placeholder files
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-06-28 18:17:19 +02:00
Claudio Cambra
051a225d83
Do not wrap macOS ifdefs in filesystem when parent function already wrapped in ifdef
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-06-28 15:55:18 +08:00
Claudio Cambra
26eab22ca4
Do not re-generate standard string path twice
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-06-28 15:55:18 +08:00
Claudio Cambra
c34edbee82
Ensure we are re-adding same permissions as removed
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-06-28 15:55:18 +08:00