When replacing an OnlineOnly file by another one, the file maintains it
OnlineOnly pin state, but it is converted to a regular file. So, the
dehydration should convert the regular file to a (dehydrated)
placeholder instead of trying to update the (non-existing) placeholder.
Closes#4274
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
F.ex. Folder::slotWatchedPathChanged calls this function on non-
placeholder files to check if the ignored file is already assigned an
Excluded pin state. Note that it is allowed to set the pin state to
Excluded on non-placeholder files.
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.
Closes#5524Closes#5594
Co-authored-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
will fix behavior on windows by properly setting the new temp file just
downloaded have the proper state (read only or read/write) and not the
already existing file that will be replaced by the newly odwnloaded one
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we try to preserve complex existing permissions unless the client is
required to change them significantly
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
make sure that a file locked that would not be modifiable by the
current client is read-only on storage
also make sure we make a file read/write when modification can happen
again
Close#5537
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
force an empty body when we bulk upload empty files
force a "valid" checksum to be computed for empty files as bulk upload
server side expects a checksum even for empty files
Close#5824
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
make sure that we have only two cases:
1) keys are stored on the server and the client
2) keys are stored on the server and not yet on the client
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
those log lines can easily be skipped from info level as they are needed
in very rare occasion
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
the archive output name is used on windows but was never set for 2
libraries
with this they will have a proper name matching other components of the
shared library
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
