for now simple rule to guess if the server has windows naming enforced
if windows naming is enforced, we enforce it for new files
if not, we do not care
for now limited to spaces removal
more to come
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
to ensure compatibility with Widnows, we will remove automatically the
leading space characters in file name of new files or folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
enforce trailing and leading space rules for new files and only for new
files but on all platforms, not only windows
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
it's already styled properly as it's part of Qt Quick Controls, **and**
it allows for a placeholder text!
also changed the logic for displaying the text field a bit ...
Fixes#7847
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
- Display more clear error when adding local sync folder and when selecting remote folder.
- Modernize FolderWizardRemotePath::isComplete().
- Display the local folder path when warning that folder is already being synced.
Signed-off-by: Camila Ayres <hello@camilasan.com>
those tests are now broken and we think they do not bring much value
for now parts of them will be disabled until we get better automated
tests
realized while doing this that the secure drop tests are not independent
of each other
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
will use different validation method for hardware stored certificates
and pure software certificates emited by the nextcloud server
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Test for spaces in usernames and passwords is disabled for now as it's
not supported by current implementation.
Signed-off-by: Fredrik Eriksson <feffe@fulh.ax>
the file being locked may have been changed sinc the client synced it
so the server side file may have a modified etag. In such cases we do
not want to lock the file and would rather sync the nex server changes
before being able to lock the file
that would ensure that on client side the file being locked is matching
teh state of teh file on server side and would prevent inadvertently
overriding server changes
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should ensure comparisons of locale aware text is compared against
locale aware test data
will remove portability issues especially on Windows
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
a folder item must be set read-only if files or sub-folders cannot be
created
a folder item must be set read-write in all other situations
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
orignally added by https://github.com/owncloud/client/pull/6632
most probably a too strong assumption on the behavior of the Nextcloud
server
better check real item metadata like fileid, size or modification time
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
NEW/NEW conflicts could sometime be ignored and replaced by update
metadata instructions
we stop doing this and handle them like any other conflicts
that would cause more download from the server
those conflicts would be solved automatically in case this is not a real
conflict but the client was missing the server reply with the updated
metadata
will enable more changes to improve MOVE detection from server side
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
why one would not update the modification time when modifying a remote
file during automated tests
there is no reason to not update the modification time as this is what
is done by the server
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
- Fix discovery tests for files with invalid names.
- Now leading/trailing spaces trigger an error only on Windows.
Signed-off-by: Camila Ayres <hello@camilasan.com>
seems we have an issue with Windows and QTimer instances used to detect
network timeout
workaround, find cause of https://github.com/nextcloud/desktop/issues/7184
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we rename the top folder and we rename a not direct child that is also
moved to another folder below the original renamed top folder
so
a/b/c
a/b/d/file
will be
e/b/c/f/file
with
a -> e
d-> f
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should ensure we are able to get files or dolders be deleted by sync
engine within read-only folders
would happen as the result of changes on server side being propagated
locally or when using selective sync
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
