take is deprecated in scoped pointer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
f handle
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Use unique_ptr instead of scoped pointer for propagator firstJob
Fixes deprecation warning
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Use unique_ptr for discoveryphase, replace take with release
Fix deprecation warn
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
f unique
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
past versions may have wrongly set the write permissions for other users
(UNIX style permissions)
remove this under the hypothesis that newly created files or folders
gets more restrictive permissions and that past files or folders should
be updated to get the same permissions
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
will log all deletions with the result of the discovery by the sync
enginre
should enable analyze even long time after such a delete occured
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
it seems that there is a possibility for the type detection to report a
folder as being a file
with this change, I am pretty sure that cannot happen any longer
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
some software (at least outlook native software) may fiddle with CfApi
placeholder metadta and set a .msg file to be out of sync state when
opening it
in that case, we will let the sync engine go over it and decide what to
do
it is then possible in that case that we would just put it back in "in
sync" state
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Note that Windows may convert a placeholder file to a regular file when
it is replaced by another file, even if the old and new file (inode,
modified time, file size) are identical.
WIN32_FIND_DATA::dwReserved0 is only initialised in case of
FILE_ATTRIBUTE_REPARSE_POINT is set. This field is not a bit set. Check
corrected to only include all cloud reparse points and not other special
reparse points.
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
the archive output name is used on windows but was never set for 2
libraries
with this they will have a proper name matching other components of the
shared library
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
will consider v1.2 stored encryption status in DB to be equivalent to v1
due to bugs in the v3.8.0 release
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
introduce a new type of conflict for case clash filename conflicts
add proper handling including a new utility class to solve them and a
new dialog for the user to pick a fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
The file might not exist anymore because the user deleted it by hand or
the folder where it was located got unchecked in the selective sync
view. It is a fix for #2632.
Signed-off-by: Camila <hello@camila.codes>
Previously the .sync-exclude.lst file of the sync root directory was
not added to the exclude files, because the current logic did only
recognize .sync-exclude.lst files when their containing directory was
discovered during the discovery phase. Therefore the sync root
.sync-exclude.lst file was never discovered. See also
ExcludedFiles::traversalPatternMatch().
Fix: #3830, #2728
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
cmake distinct runtime and library
on unix dynamic shared libraries are library kind of objects
on windows they are runtime kind of objects
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
