in release builds we would happily try to remove an element from QList
with invalid index (-1) if the job is not found
avoid doing this in release builds and keep teh assert in debug builds
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Extra safeguard to ensure that the usage of
`FileSystem::setFolderPermissions` won't start a new sync run if
FolderWatcher/inotify detects a change in the file metadata...
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
we may not currently properly store certificate hash for encrypted items
and later fails to find which public or private key pairs to use
for now, it is better to remove it and ensure we have a reliable way to
handle certificate migration
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we might forget to run the pending folder deletions when terminating
synchronization
ensure we check if any of them are to be done
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
clean up preprocessor directives for older macOS releases that are not
supported by macOS minimum required release from the Qt 6.8 release we
require
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
- Cancel sync after try with smaller bulk upload batch size also throws error.
- Continue syncing when there is no error.
- Remove file from bulk upload black list only when upload succeeded.
Signed-off-by: Camila <hello@camila.codes>
take is deprecated in scoped pointer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
f handle
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Use unique_ptr instead of scoped pointer for propagator firstJob
Fixes deprecation warning
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Use unique_ptr for discoveryphase, replace take with release
Fix deprecation warn
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
f unique
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
past versions may have wrongly set the write permissions for other users
(UNIX style permissions)
remove this under the hypothesis that newly created files or folders
gets more restrictive permissions and that past files or folders should
be updated to get the same permissions
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
a folder item must be set read-only if files or sub-folders cannot be
created
a folder item must be set read-write in all other situations
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
might be that the server previously supported e2ee and e2ee folders
exist
so we have to fetch the info to properly handle it on client
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
some software (at least outlook native software) may fiddle with CfApi
placeholder metadta and set a .msg file to be out of sync state when
opening it
in that case, we will let the sync engine go over it and decide what to
do
it is then possible in that case that we would just put it back in "in
sync" state
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
acoid modifying some metadata of the placeholder when this placeholder
has just been uploaded to the server (will avoid truncating the
timestamps)
Close#6190
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
