Commit Graph

5617 Commits

Author SHA1 Message Date
Dominik Schmidt
772f3d2dbf Do not run macdeployqt.py from CMake. 2019-01-14 12:21:06 +01:00
Markus Goetz
a3f3546879 Sync: Display theme in debug log 2019-01-11 11:28:53 +01:00
Christian Kamm
7ac09fc4db sqlite: Set exclusive locking_mode to avoid WAL issues #6881
Can be overridden with OWNCLOUD_SQLITE_LOCKING_MODE
2019-01-11 10:59:37 +01:00
Dominik Schmidt
872bb99a58 Fix lookup of system wide settings 2019-01-11 10:36:33 +01:00
Markus Goetz
b05440fd9d qtmacgoodies: Improve our cmake use 2019-01-09 17:51:37 +01:00
Christian Kamm
f0ef500318 Update qtmacgoodies for an OSX crash fix #6930
The updated code in qtmacgoodies uses private headers.
2019-01-09 17:51:37 +01:00
Olivier Goffart
e3c98422d2 sqlite: Update bundled version to 3.26.0
For OS X and Windows.
2018-12-18 12:20:18 +01:00
Olivier Goffart
11c73ae45b SocketApi: make sure to discover the file we want to make virtual
MacOSX's file system watcher does not deliver events for files modified by
our own process.

Issue: #6844
2018-12-17 12:37:11 +01:00
Olivier Goffart
7380e9b963 HttpCredentials: Do not re-enter the event loop
https://sentry.io/owncloud/desktop-win-and-mac/issues/777907931/
mention a crash in OCC::HttpCredentialsGui::showDialog
One possible explaination is that this is caused by re-entring the event loop.
So don't do that.
2018-12-17 12:36:46 +01:00
Olivier Goffart
0440349aa0 Chunking Move: Fix too many starting slashes in the destination header
Commit 6ca724f fixed it for the move case. But the upload MOVE did the same

Issue #6904
2018-12-11 20:57:51 +01:00
Olivier Goffart
5e61d004c9 Gui: do not show the settings when opening a virtual file
Issue #6764
2018-12-11 20:48:29 +01:00
Olivier Goffart
6e4b4e67e0 IgnoreListEditor: increase a bit the size
Should Help for issue #6641
2018-11-29 12:10:59 +01:00
Olivier Goffart
7abb9cd6fa SSLButton: do not hardcode the background color
Reported in https://github.com/nextcloud/desktop/issues/871

(cherry picked from commit ba24ef3fe3)
2018-11-29 12:02:22 +01:00
Olivier Goffart
93d3d0441b Account: Fix crash when deleting an account
We should not have request parented to the account, otherwise we might get
a loop on the deletion order.

Issue #6893
2018-11-26 10:12:03 +01:00
Christian Kamm
46ed5484d1 LockWatcher: Add chrono header 2018-11-12 13:47:28 +01:00
Christian Kamm
4608adb6a6 cjhash: Fix build fix
See 17a4055e8d
2018-11-12 13:45:56 +01:00
Olivier Goffart
17a4055e8d cjhash: use Q_FALLTHROUGH
This fixes the warning
   warning: unknown option after ‘#pragma GCC diagnostic’ kind [-Wpragmas]

Issue #6872
2018-11-09 16:46:30 +01:00
Markus Goetz
dc039e7e11 Crash Reporter: Add more debug menu entries #6823 2018-11-07 18:00:55 +01:00
Markus Goetz
5c98193c63 macOS: Fix Ctrl+L shortcut
From fb053a240b
2018-11-07 17:42:52 +01:00
Olivier Goffart
c674d39576 Fix compiler warning (about unused result) 2018-11-06 16:04:11 +01:00
Christian Kamm
fb053a240b Add Ctrl-L as log window shortcut
F12 is taken on OSX and there's no other way of showing it.
2018-11-06 13:14:41 +01:00
Christian Kamm
ee457742d6 PropagateUpload: Fix for missing make_unique() 2018-11-06 11:01:57 +01:00
Christian Kamm
2bc1baa5e2 Test: Add test for locked file tracking and propagation 2018-11-06 10:03:25 +01:00
Christian Kamm
a9599b4ccc Folder: Treat file unlock similar to external change #6822
For consistent handling of incoming notifications.
2018-11-06 10:03:25 +01:00
Markus Goetz
62252d0012 Theme: Always show copyright 2018-11-04 20:59:16 +01:00
Markus Goetz
4780ae1595 Settings: Bring back version and copyright
For owncloud/enterprise#2941
2018-11-04 19:53:22 +01:00
Christian Kamm
ef9c258081 PropagateUpload: Fix UploadDevice leak #6699 2018-11-01 12:55:42 +01:00
Olivier Goffart
5ef4d3689a Wizard: Manual folder configuration should not create the local folder
Skip the local folder creation when the manual folder radio box is selected

Issue #6853
2018-11-01 12:26:37 +01:00
Dominik Schmidt
1c78de7a3f Make qFatal() trigger the crash reporter on Windows 2018-11-01 11:24:19 +01:00
Olivier Goffart
a97f6fcfb2 Database: future-proof to allow downgrade from future version
The 2.6 client will introduce an index that depends on a custom
function.
This causes insersion onto the metadata database to fail if the database
it opened with older version of the client. (Which will cause the client
to abort)

Delete this index in this version in order to allow downgrade.

In addition, allow to load folder with version '2', but still write
version '1' in the config file

Of course this commit need not to be in the 2.6 release
2018-10-31 11:30:35 +01:00
Christian Kamm
3e7f1a3094 Doc: improve backwardMigrationSettingsKeys 2018-10-31 10:09:25 +01:00
Christian Kamm
7a4792b349 Errors: Include path in discovery error message #6826 2018-10-29 19:56:07 +01:00
Christian Kamm
7519c64e86 Settings: Make FoldersWithPlaceholders group sticky
If virtual files are disabled on a folder it might still have db entries
or local virtual files that would confuse older client versions.
2018-10-29 19:54:21 +01:00
Olivier Goffart
a325c61930 owncloudcmd: Read the server version from the capabilities
Issue: #6846
2018-10-29 15:23:05 +01:00
Olivier Goffart
b1ce2ad58f owncloudcmd: fetch the dav user
This is required to get the new endpoint working when the server
uses ldap or that the dav user is not the same as the login.

Issue #6830
2018-10-26 15:18:09 +02:00
Olivier Goffart
7b0a4d7ebc Sharing: add the shareWithAdditionalInfo string in autocompletion results
Issue #6749
2018-10-25 12:39:01 +02:00
Olivier Goffart
26c0c88c1f Migration from 2.4: fallback to move file by file if directory move failled (#6807)
Migration from 2.4: fallback to move file by file if directory move failed

This can happen if the directory already exist because, say, it was
created by the ownCloud outlook plugin which save its file in the same directory
2018-10-24 15:42:42 +02:00
Olivier Goffart
6ca724fc54 Move: Fix too many starting slashes in the destination header
QDir::cleanPath does not remove starting slashes on windows.
So use account::davUrl which is already cleaned

Issue: #6824
2018-10-24 14:53:11 +02:00
Olivier Goffart
ef99800a94 Wizard: Reset the QSslConfiguration before checking the server
Because a previous call with another demain might have set some
config for another server.

Issue #6832
2018-10-24 12:50:40 +02:00
Olivier Goffart
f11a2a8ed9 Fix compiler warning 2018-10-20 15:13:40 +02:00
Olivier Goffart
e0963ab906 OAuth2: Refresh the token without aborting the sync
OAuth2 access token typically only has a token valid for 1 hour.
Before this patch, when the token was timing out during the sync, the
sync was aborted, and the ConnectionValidator was then requesting a new
token, so the sync can be started over.
If the discovery takes longer than the oauth2 validity, this means that
the sync can never proceed, as it would be always restarted from scratch.

With this patch, we try to transparently renew the OAuth2 token and restart
the jobs that failed because the access token was invalid.

Note that some changes were required in the GETFile job because it handled
the error itself and so it was erroring the jobs before its too late.

Issue #6814
2018-10-19 12:37:11 +02:00
Olivier Goffart
d500cdb86c HttpCredentials: initialize all member inline 2018-10-19 12:37:11 +02:00
Dominik Schmidt
e587ae7c36 Disable autostartCheckBox if autostart is configured system wide 2018-10-19 10:45:13 +02:00
Olivier Goffart
c24e27022a Discovery: Windows: Don't check if a server file name can be encoded
Because on windows, all filename can be encoded: The file system uses
UTF-16, regardless of the locale

Issue: #6810
2018-10-18 12:46:06 +02:00
Olivier Goffart
36ca910d33 Account Settings: fix progress being written in white when there are errors 2018-10-17 15:15:54 +02:00
Christian Kamm
3c068b5058 Virtual files: Wipe selective sync settings when enabled 2018-10-17 09:05:32 +02:00
Christian Kamm
c8b398d9ba Virtual files: Use theme to check for option availability 2018-10-17 09:05:32 +02:00
Olivier Goffart
6ca5facbaf Account Settings: Add a context menu entry to enable or disable virtual files
Issue #6725
2018-10-17 09:05:32 +02:00
Olivier Goffart
eba2f344b7 Upload: Do not error out if the server do not send the X-OC-MTime: accepted header
If the server does not set the mtime, it is not a big problem for the
synchronisation.

The test was used before so we could do a PROPPATCH for server that did not
support this header. But now that all server supports that we don't need to
to the check. (We do not do the PROPPATCH since we got rid of the neon
dependency)

Apparently, it may happen that some backend don't support setting mtime
and this can lead to this error.

https://github.com/owncloud/client/issues/6797
2018-10-15 20:18:30 +02:00
Olivier Goffart
47c7f3f921 OAuth2: Store 'Account::davUser' in the config, and use that user for connecting
We need to use the user id to check if we are connected to the right account.
These might be different from the HTTP Basic Auth login. (LDAP setups)

When the account was configured as an oauth2 account form the wisard, the
http_user was already set correctly to the user id. But when the server is
upgrading from basic auth to oauth2, we need to pick the right login.

Note that Account::davUser() already defaults to the HTTP user when none
is set, so this means the upgrade will be fine if this is not set in the
config.

Issues:
https://github.com/owncloud/oauth2/issues/109
https://github.com/owncloud/enterprise/issues/2781
2018-10-12 12:11:53 +02:00