take is deprecated in scoped pointer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
f handle
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Use unique_ptr instead of scoped pointer for propagator firstJob
Fixes deprecation warning
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Use unique_ptr for discoveryphase, replace take with release
Fix deprecation warn
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
f unique
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
past versions may have wrongly set the write permissions for other users
(UNIX style permissions)
remove this under the hypothesis that newly created files or folders
gets more restrictive permissions and that past files or folders should
be updated to get the same permissions
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
a folder item must be set read-only if files or sub-folders cannot be
created
a folder item must be set read-write in all other situations
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
might be that the server previously supported e2ee and e2ee folders
exist
so we have to fetch the info to properly handle it on client
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
some software (at least outlook native software) may fiddle with CfApi
placeholder metadta and set a .msg file to be out of sync state when
opening it
in that case, we will let the sync engine go over it and decide what to
do
it is then possible in that case that we would just put it back in "in
sync" state
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
acoid modifying some metadata of the placeholder when this placeholder
has just been uploaded to the server (will avoid truncating the
timestamps)
Close#6190
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should prevent a malicious server admin to make clients fallback to
older vulnerable metadata format
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
introduce a new type of conflict for case clash filename conflicts
add proper handling including a new utility class to solve them and a
new dialog for the user to pick a fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
in case some propgation actions ends up with a BlacklistedError, we
would skip the deletions of local folders (even though they have been
deleted from server)
let's not skip them but rather keep track of the error status and
properly report them
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix
this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
