should improve coverage for move to trash feature to ensure this is
working as expected by users
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
when propagating a rename to the child items, we must not make child
items be done from propagator point of view
they will be part of their own propagator item and that will create
issues
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
the sync engine will remove invalid items inside read-only folders
not needed to remove them in tests and rather checks that they were
indeed removed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
would need careful analyze to fix those
until we can get them fixed, better make the other tests be required in
the CI
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
makes our fake server require an md5 custom checksum for bulk upload
until version 32.0.0
starting with 32.0.0 this custom checksum must be empty
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Files with a modification time of less than 0 do usually not make sense
(and afaik the server doesn't accept them either).
--> attempt to update the modification time to _Time.now_ while
propagating
side note: I ran into this because KArchive/Ark(?) didn't consider the
extra time attributes on entries for a certain zip file, so it instead
used the standard time value of each zip entry which was set to <= 1980
for files and < 1970 for directories...
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
clean up preprocessor directives for older macOS releases that are not
supported by macOS minimum required release from the Qt 6.8 release we
require
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
These are informative notifications without any need/possibility to act
on immediately -- if a file is not synced it will be visible from the
shell integration anyway.
An eventual follow-up to this change would be to have a dialogue with an
overview of all files that were ignored (including the entry in the
ignore list that caused a specific file to be ignored).
Closes#6712
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
for now simple rule to guess if the server has windows naming enforced
if windows naming is enforced, we enforce it for new files
if not, we do not care
for now limited to spaces removal
more to come
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
to ensure compatibility with Widnows, we will remove automatically the
leading space characters in file name of new files or folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
enforce trailing and leading space rules for new files and only for new
files but on all platforms, not only windows
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
it's already styled properly as it's part of Qt Quick Controls, **and**
it allows for a placeholder text!
also changed the logic for displaying the text field a bit ...
Fixes#7847
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
- Display more clear error when adding local sync folder and when selecting remote folder.
- Modernize FolderWizardRemotePath::isComplete().
- Display the local folder path when warning that folder is already being synced.
Signed-off-by: Camila Ayres <hello@camilasan.com>
those tests are now broken and we think they do not bring much value
for now parts of them will be disabled until we get better automated
tests
realized while doing this that the secure drop tests are not independent
of each other
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
will use different validation method for hardware stored certificates
and pure software certificates emited by the nextcloud server
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Test for spaces in usernames and passwords is disabled for now as it's
not supported by current implementation.
Signed-off-by: Fredrik Eriksson <feffe@fulh.ax>
the file being locked may have been changed sinc the client synced it
so the server side file may have a modified etag. In such cases we do
not want to lock the file and would rather sync the nex server changes
before being able to lock the file
that would ensure that on client side the file being locked is matching
teh state of teh file on server side and would prevent inadvertently
overriding server changes
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should ensure comparisons of locale aware text is compared against
locale aware test data
will remove portability issues especially on Windows
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
a folder item must be set read-only if files or sub-folders cannot be
created
a folder item must be set read-write in all other situations
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
