Commit Graph

366 Commits

Author SHA1 Message Date
Jyrki Gadinger
e0ef3773c3 implement terms of service check wizard page
this is only shown if the TOS haven't been accepted yet!

for now this only opens the browser, similar to the Flow2Auth page

the `TermsOfServiceCheckWidget` is a combination of the `Flow2Auth` and
the `Flow2AuthWidget` classes -- in the future we ideally display the
required TOS directly in the wizard

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-02-20 10:54:24 +01:00
Matthieu Gallien
0e829edef1 add a wizard page to check terms of service
should enable proper polling while the user check and signs the terms of
service via teh web browser

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-02-20 10:54:24 +01:00
Matthieu Gallien
ea0a3b7545 detect the need to sign the terms of service during login web flow v2
should avoid being blocked by terms_of_service blocking WebDAV access

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2025-02-20 10:54:23 +01:00
Claudio Cambra
55a44fd482 gui/wizard: Display macOS-specific VFS information where relevant in advanced setup page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-02-20 10:43:31 +01:00
Claudio Cambra
e7d6434ff7 gui/wizard: Do not check vfs path availability with macOS File Provider module
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-02-20 10:43:31 +01:00
Claudio Cambra
0b5b0f44e1 gui/wizard: Present virtual files checkbox if using macOS File Provider module
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-02-20 10:43:31 +01:00
Claudio Cambra
6025de2ae4 gui/wizard: When asking about virtual files, do not notify user if using macOS File Provider module
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-02-20 10:43:31 +01:00
Camila Ayres
f62efca6c4 Improve text returned when checking VFS availability.
- Display more clear error when adding local sync folder and when selecting remote folder.
- Modernize FolderWizardRemotePath::isComplete().
- Display the local folder path when warning that folder is already being synced.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-02-11 09:08:26 +01:00
Integral
356e4f9296 refactor: replace QString() with QStringLiteral() for better performance
Signed-off-by: Integral <integral@member.fsf.org>
2025-01-31 15:11:02 +01:00
Ankur Bavisa
ddc4d4fe62 update runwizard introduction screen
Signed-off-by: Ankur Bavisa <Ankur.Bavisa@t-systems.com>
2025-01-13 15:40:35 +01:00
Claudio Cambra
7d9077c9a9 Use unique_ptr over scoped pointer
take is deprecated in scoped pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f handle

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use unique_ptr instead of scoped pointer for propagator firstJob

Fixes deprecation warning

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use unique_ptr for discoveryphase, replace take with release

Fix deprecation warn

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f unique

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Hannah von Reth
47132d3beb Fix crash on missing sync root
Fixes: #9016
2024-12-12 12:15:44 +01:00
Claudio Cambra
6820e1a717 Also emit close signal on window hide (i.e. user close) on macOS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-15 13:36:17 +08:00
Claudio Cambra
1ba6b61e7e Emit a signal on wizard close
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-15 13:36:17 +08:00
Camila Ayres
d080261692
Use const auto.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-29 12:40:24 +01:00
Claudio Cambra
00c11b248a Only display server name in multiple override servers dropdown
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-28 10:13:49 +08:00
Elsie Hupp
0ad55e82c7
Show/Hide Menubar and Dock Icon
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com>
2024-10-17 16:26:28 +08:00
Claudio Cambra
c16b6205f1 Ensure we hide the combo box for multiple override servers by default
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
72fe0d8818 Display server URL in multi-server enforced combo box
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
d84ede3ef2 Do not automatically validate server URL when enforced servers is active but have multiple servers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
0663120f4f Use url method instead of text field contents as url when deciding on error string in setup page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
5c08e45019 If using multi-server override url and forcing it then provide combo box selection url as url in setup page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
6358f00263 Accept combo box selection as completed state in setup page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
1decedd56f Show or hide multi-server overrides or text field depending on type of override url
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
c65b544757 Add combo box to setup page UI
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Matthieu Gallien
7a979c732a properly detect and enable Qt6 WebEngine integration
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-28 11:35:04 +02:00
Matthieu Gallien
156ab805f2 fix authentication using provider page and web page login flow
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-06 18:21:45 +02:00
Claudio Cambra
7a17a51a25 Use QEnterEvent for new enterEvent parameters
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-26 09:05:12 +02:00
Matthieu Gallien
ee245f26c8 replace deprecated QWebEngineProfile::setRequestInterceptor
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-26 09:05:12 +02:00
Matthieu Gallien
249e0eb87d port away from QWidget related margines APIs
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-26 09:05:12 +02:00
Matthieu Gallien
20ee506b71 port away from deprecated API from QFontMetricsF
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-26 09:05:12 +02:00
Matthieu Gallien
d81c20b116 partial fix for compilation with QT_NO_KEYWORDS
need to replace signals by Q_SIGNALS and so on

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-03-27 10:34:22 +01:00
Micke Nordin
6ca4ace09f OwncloudWizard: Move implementation to cpp-file
Signed-off-by: Micke Nordin <kano@sunet.se>
2024-01-19 11:05:18 +01:00
Micke Nordin
42012a0efb Apply suggestions from code review
Formatting fixes

Co-authored-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Micke Nordin <mickenordin@users.noreply.github.com>
2024-01-19 11:05:07 +01:00
Micke Nordin
772d44c66d GUI/LIBSYNC: force login flow V2 with config setting
This patch allows a user to set the config variable:

forceLoginV2=true

This will make the client use the browser login flow instead of the
webview. This is useful for making the user experience equal on
Windows, Linux and Mac. Currently only Macs use the v2 flow and it
was only possible to get this behaviour in the Windows and Linux
clients at build time using a CMAKE flag.

The default behaviour is kept the same, and nothing changes for the
user unless the flag is manually set in the config file. A setter is
included in this patch, although it is not yet used in the GUI.

Signed-off-by: Micke Nordin <kano@sunet.se>
2024-01-19 11:03:36 +01:00
Claudio Cambra
6cf04d660b Remove OAuth authentication method as it is now unused
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-09-19 14:58:17 +08:00
Claudio Cambra
21656cce17
Replace all manual isntancesof adding trailing slash with use of utility method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-08-04 17:40:42 +08:00
Dimitri Papadopoulos
9d830e94f9 Fix typos found by codespell
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
2023-06-21 08:47:13 +02:00
Camila San
3bdbed6294 Use addLayout to insert the VFS option when setting account.
- Maintains the space between the layout items when resizing
the window.
- Also remove qobject_cast.

Signed-off-by: Camila San <hello@camila.codes>
2023-05-09 15:27:24 +00:00
Camila
6a4d6b9c97 Alway add the item at the end of the layout.
Signed-off-by: Camila <hello@camila.codes>
2023-04-12 10:16:47 +02:00
Matthieu Gallien
20422f0247 when local sync folder is overriden, respect this choice
may lead to inadvertant data loss, not sure if that could be an issue

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-31 09:21:48 +02:00
Axel Lender
664e0c18ec Resize WebView widget once the loginpage rendered
When the login dialogue displays the login page itself
the WebView widget did not resize according to
the dimensions of the login page.

Signed-off-by: Axel Lender <lender@b1-systems.de>
2023-03-07 09:55:04 +01:00
Matthieu Gallien
01ecb639ab use new connect syntax
mainly done using clazy and old-style-connect check

close #5426

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-28 09:36:27 +01:00
Matthieu Gallien
079d392d36
move init to default value in class declaration
done via clang-tidy and manual tuning

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
d2f5c6a5c7
initialize many attributes that could have been left without init value
done with clang-tidy

run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Camila
9101e0a7f8 Only accept folder setup page if overrideLocalDir is set.
Fix for #5383.

Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
alex-z
2bd1c272a6 Allow specifying the server force override URL and local sync folder path via command line.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-17 17:27:19 +01:00
Claudio Cambra
0495c6567a Fix interval QPROPERTY missing NOTIFY in slideshow class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-02 17:04:30 +01:00
Claudio Cambra
135cab152b Format some QLabels as plain text
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 17:18:57 +01:00
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-15 09:57:54 +01:00