mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
22,923 Commits 194 Branches 287 Tags 562 MiB
71e4de1503
Commit Graph

103 Commits

Author SHA1 Message Date
Pablo Ariño Muñoz
71e4de1503 Added more std::as_const and replaced types for auto, as well as other suggestions 
Signed-off-by: Pablo Ariño Muñoz <progpabarino@gmail.com>
 2025-02-25 11:54:54 +08:00
Pablo Ariño Muñoz
44f9aacda8 removed redundant qAsConst 
Signed-off-by: Pablo Ariño Muñoz <progpabarino@gmail.com>
 2025-02-25 11:54:54 +08:00
Pablo Ariño Muñoz
fc28fe95bb Replaced foreach with range loops 
Signed-off-by: Pablo Ariño Muñoz <progpabarino@gmail.com>
 2025-02-25 11:54:54 +08:00
Camila Ayres
f62efca6c4 Improve text returned when checking VFS availability. 
- Display more clear error when adding local sync folder and when selecting remote folder.
- Modernize FolderWizardRemotePath::isComplete().
- Display the local folder path when warning that folder is already being synced.

Signed-off-by: Camila Ayres <hello@camilasan.com>
 2025-02-11 09:08:26 +01:00
Claudio Cambra
8425f2e3c5 Replace use of QCheckBox::stateChanged with QCheckBox::checkStateChanged 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-12-20 16:26:57 +01:00
Camila Ayres
d3d7963dc0 All conditions must be true to use virtual files in the selected location. 
Signed-off-by: Camila Ayres <hello@camilasan.com>
 2024-12-12 12:15:44 +01:00
Hannah von Reth
cb05cedd10 Warn if we encounter an unsupported configuration 2024-12-12 12:15:44 +01:00
Hannah von Reth
47132d3beb Fix crash on missing sync root 
Fixes: #9016
 2024-12-12 12:15:44 +01:00
Matthieu Gallien
8b1e3fcd9d
switch folder wizar to modern style to avoid borken windows dark mode 
the QWizard AeroStyle style is broken on windows dark mode, switch to
ModernStyle that is working fine

see upstream Qt bug: https://bugreports.qt.io/browse/QTBUG-123853

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-10-07 15:30:18 +02:00
Matthieu Gallien
284823d147
maintain e2ee state even if the server does not support e2ee 
might be that the server previously supported e2ee and e2ee folders
exist

so we have to fetch the info to properly handle it on client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-06-26 14:47:17 +02:00
Claudio Cambra
7954695783 Add missing QStandardPaths include 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
alex-z
e9a0dbd16c Allow event processing between each XML parser run, to improve GUI performance. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-01-29 18:32:01 +01:00
Claudio Cambra
e6676ac0f0 Move warning yellow palette generation for warn labels to anonymous namespace function 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-09-16 19:29:55 +02:00
Claudio Cambra
8312cda0e4 Constexprify yellow warning colours in FolderWizard 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-09-16 19:29:55 +02:00
Claudio Cambra
3dd48e21f7 Also provide remote path folder wizard page with correct warn colour 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-09-16 19:29:55 +02:00
Claudio Cambra
b32c69584b Ensure background colour for warn label in folder wizard is the correct colour 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-09-16 19:29:55 +02:00
Matthieu Gallien
20422f0247 when local sync folder is overriden, respect this choice 
may lead to inadvertant data loss, not sure if that could be an issue

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 09:21:48 +02:00
Matthieu Gallien
079d392d36
move init to default value in class declaration 
done via clang-tidy and manual tuning

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-06 10:43:05 +01:00
Matthieu Gallien
ecc588c27a avoid possibly crashing static_cast 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-03 10:23:24 +02:00
alex-z
f0b9ecd747 Check folder invalidity reson when deciding to enable or disable the 'Finish' button in a Wizard page. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-10 10:34:34 +02:00
Claudio Cambra
97801a5acb Fix warn colour in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-18 12:08:12 +01:00
Matthieu Gallien
5ab13b2adc add an option to enforce use of virtual files sync folder 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-05 16:56:24 +01:00
Hannah von Reth
d16befd1fd Align MkColJob finish signal with the other jobs 2021-08-23 09:40:27 +02:00
Valdnet
7ebbb499e0 l10n: Replace apostrophe with double quotation 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-07-30 06:21:05 +00:00
allexzander
bbf11d7e7a Temporary! Windows. VFS. Block Virtual Files for partition root sync folders. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-05-11 18:53:35 +03:00
Valdnet
f365ec1e4c Move space in "folderwizard.cpp" 2021-01-25 17:42:38 +00:00
Kevin Ottens
ce5edfdf4d
Stop using e2e()->isFolderEncrypted() in the folder wizard 
We used the same approach than for the FolderStatusModel by getting the
is-encrypted property straight from the LSCOL job.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:23 +01:00
Hannah von Reth
dd3e70b667
VirtualFiles: Ensure the target location supports vfs 
Fixes: #8131
 2020-12-15 10:59:20 +01:00
Hannah von Reth
356192fb1d
Don't show 404 errors when manually creating folder sync pair. 
Fixes: #7724
 2020-12-15 10:59:20 +01:00
Hannah von Reth
1619cd5dcc
Use winvfs by default when adding folder sync connection 
Fixes: #8083
 2020-12-15 10:59:19 +01:00
Hannah von Reth
f1f6257b5d
Windows VFS: Enable Windows VFS by default 2020-12-15 10:59:18 +01:00
Olivier Goffart
b7193e6a0e
Folder Wizard: warn when adding a folder which is the parent of a sync'ed folder 
issue #7741
 2020-12-15 10:59:07 +01:00
Hannah von Reth
fdc3b7c8da
[Wizard] Make vfs dialog blocking 
Calling the callback after the receiver was deleted caused a crash
Fixes: #7709
Fixes: #7711
 2020-12-15 10:59:07 +01:00
Hannah von Reth
afc9cd2f46
OwncloudWizard: Mark vfs as tech preview instead of experimental 2020-12-15 10:58:57 +01:00
Christian Kamm
0eb4065197
Folder: Add remoteFolderTrailingSlash() 
There were cases where the "/" exception wasn't handled correctly
and there'd be extra slashes in generated paths.
 2020-12-15 10:58:39 +01:00
Christian Kamm
fa6f3cd847
vfs: Fix plugin decision in wizards, sanitize loading 2020-12-15 10:58:23 +01:00
Christian Kamm
60de1c9720
virtual files: show option only when branding allows it 2020-12-15 10:58:12 +01:00
Olivier Goffart
3289675b8d
Folder Wizard: Disable the 'choose what to sync' treeview if virtual files are selected 
Don't allow to configure virtual files with a selective sync blacklist
 2020-12-15 10:58:07 +01:00
Christian Kamm
aa6f5f59c4
Rename Placeholders to Virtual Files in code #6531 2020-12-15 10:57:53 +01:00
Christian Kamm
ddeeecd061
Rename "placeholder" feature 2020-12-15 10:57:53 +01:00
Olivier Goffart
3272f3b72b
FolderWizard: fix crash when experimental feature are disabled 
The _placeholderCheckBox only exists if the experimental features are enabled

Found via the crash reporter
https://sentry.io/owncloud/desktop-win-and-mac/issues/556407777/
 2020-12-15 10:57:52 +01:00
Christian Kamm
27c8bce0b9
Wizards: Show placeholder option only if showExperimentalOptions is set 
This config file option will also control other features in the future.
 2020-12-15 10:57:50 +01:00
Christian Kamm
aee8b9f3c5
Wizards: Add placeholder option and warning to account wizard 
Also add the warning dialog to the option in the folder wizard.
 2020-12-15 10:57:50 +01:00
Olivier Goffart
7eeb99ba24
Placeholders: Add an checkbox in the FolderWizard to enable the placeholder feature 2020-12-15 10:57:48 +01:00
Kevin Ottens
0e2af4b502 Enable the modernize-deprecated-headers check on clang-tidy 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-13 14:53:52 +02:00
Kevin Ottens
542d303313 Reduce interaction with e2ee folders when in the wizard 
During the wizard we currently don't have much information about the
encrypted folders. In particular we can only display their mangled names
which is far from ideal for the user to make an informed choice.

That's why in the wizard we now forbid creation of subfolders in e2ee
folders and we also don't display subfolders of e2ee folders.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-07-01 16:58:29 +00:00
Kevin Ottens
a73a1f3927 Use = default for trivial ctors and dtors 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-25 21:33:24 +02:00
Kevin Ottens
712869db9a Use auto to avoiding repeating type names 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-20 03:54:41 +02:00
Kevin Ottens
dea6ebaa35 Use nullptr when appropriate 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-20 02:21:26 +02:00
J-P Nurmi
fb5ff96ed6 GUI: run clang-tidy modernize-use-nullptr 2018-11-11 10:56:22 +01:00