Commit Graph

40 Commits

Author SHA1 Message Date
Claudio Cambra
7dec7b26a0
Move all proxy configuration procedures into account and out of network settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 16:28:15 +08:00
Claudio Cambra
eeb9cc284a
Use application proxy when setting global proxy setting via network settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:58:26 +08:00
Claudio Cambra
5bc6388760
Add a method to set a specific account's folders' network limits as dirty
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:51 +08:00
Claudio Cambra
926c3b6c00
Use an AccountPtr instead of raw pointer in networksettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:51 +08:00
Claudio Cambra
68cff89c8b
Ensure per-account network settings are saved on change
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:51 +08:00
Claudio Cambra
9c856d29d4
Correctly load global proxy setting state on account-specific network settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:50 +08:00
Claudio Cambra
97f31a2965
Save bwlimits for account-specific network configuration
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:50 +08:00
Claudio Cambra
b14b86e370
Clean up networksettings saveProxySettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:50 +08:00
Claudio Cambra
f9b4c76b33
Implement saving proxy settings to account in network settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:49 +08:00
Claudio Cambra
f9d0f435d1
Adapt network settings loadBwLimitSettings for account-specific settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:49 +08:00
Claudio Cambra
fe031a131c
Load in account specific network settings in network settings widget
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:49 +08:00
Claudio Cambra
dd7143611a
Add account member to network settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:48 +08:00
Matthieu Gallien
d3442d137a disable qt apis deprecated before qt 5.12, enable warnings
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-26 09:05:12 +02:00
alex-z
bc91eac2e5 Improve Settings dialog design.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-10-23 12:45:24 +02:00
Matthieu Gallien
b5adbf3ab0 fix instances of: c++11 range-loop might detach Qt container warnings
analyzed via clazy

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 16:02:21 +01:00
alex-z
0ea7e8d3a6 Cmake option to disable proxy
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-02-02 10:02:34 +00:00
Olivier Goffart
b97c0ed8a2
Network Settings: Show a warning that proxy settings do not apply to localhost
Only show this if at least one account is detected to have an url that looks
like localhost, because this could otherwise be confusing

Issue #7169
2020-12-15 10:59:03 +01:00
Kevin Ottens
6e62c8b430 Use the return braced init list pattern
This way we avoid repeating the return type while it is already known.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-27 14:36:07 +02:00
Nicolas Fella
1afda2b875 Fix container detaching
Found by clazy

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2020-03-21 01:24:37 +01:00
Christian Kamm
70b5d54082
Proxy settings: Fix bad behavior with empty host
Fixes f6a075ef54 for #5885

When no host is given it shouldn't just *appear* that there is no
proxy, there actually shouldn't be a proxy set then.
2018-07-02 21:15:30 +02:00
Christian Kamm
e1ab5f3811
Network settings: If no proxy host given, show "no proxy" #5885
What happens internally is that a proxy without a hostname gets treated
as no proxy.
2018-06-06 20:11:09 +02:00
Christian Kamm
86377aa37a Folder: Remove unused 'dirty proxy' setting 2018-01-05 09:44:20 +01:00
Christian Kamm
ab9d6285c6 Proxy: Hostname validation and reconnection on setting change
Where 'validation' currently just means "check whether it's empty".

Code adapted from wiggiBe's original PR #6140
2018-01-04 14:30:24 +01:00
Olivier Goffart
35e4fe061d Port to new signal-slot syntax what cannot be done automatically
Some slot were protected or private but needed to be public.
Some needed a static_cast (can't use qOverload because it is in Qt 5.7)

This is not only a partial change.
2017-09-21 14:05:39 +02:00
Olivier Goffart
ff4213b59f Use the Qt5 connection syntax (automated with clazy)
This is motivated by the fact that QMetaObject::noralizeSignature takes 7.35%
CPU of the LargeSyncBench. (Mostly from ABstractNetworkJob::setupConnections and
PropagateUploadFileV1::startNextChunk). It could be fixed by using normalized
signature in the connection statement, but i tought it was a good oportunity
to modernize the code.

This commit only contains calls that were automatically converted with clazy.
2017-09-21 14:05:39 +02:00
Helmut K. C. Tessarek
709aa27031 remove qt4 code 2017-09-15 07:11:05 +02:00
Jocelyn Turcotte
cf15cbf0b3 Move Utility to a new common static library
Now that csync builds as C++, this will avoid having to implement
functionalities needed by csync mandatorily in csync itself.

This library is built as part of libocsync and symbols exported
through it.
This requires a relicense of Utility as LGPL. All classes moved into
this library from src/libsync will need to be relicensed as well.
2017-09-05 17:25:19 +02:00
Christian Kamm
c8d0f788e0 Apply clang-format 2017-05-17 12:26:27 +02:00
Christian Kamm
db24f60ae3 License: Adjust license of GPLv2 source files to GPLv2+
See #5180
2016-10-25 11:06:54 +02:00
Markus Goetz
6c07f08175 Proxies: Enable ownBrander to force system proxy usage #4458 2016-03-11 16:21:40 +01:00
Olivier Goffart
6a0633083d Network Settings: Adjust the bandwidth limit option with old Qt
- Disable the whole group box
- Add a tooltip explaining why it is disabled
- Make sure it is disabled in the settings in case of upgrade
- Do a runtime check in case the running Qt is greater
2015-10-22 17:57:34 +02:00
Markus Goetz
c8590c4468 Remove legacy propagator and neon
The code was already uneeded/unbuilt on Windows and OS X.
2015-10-20 17:57:43 +02:00
Markus Goetz
afed400ac6 SettingsDialog: Make bigger and more native on OS X
On OS X, the width of the dialog must not change, only its height.
2015-07-20 18:16:33 +02:00
Christian Kamm
2124098f84 System proxy: Ask for credentials if needed.
The proxyAuthenticationRequired() signal now goes to the
ProxyAuthHandler class. That class will try to read the proxy settings
from the keychain or ask the user about them.

We won't ask the user for credentials for explicitly configured proxies.
It also does not change how the credentials for explicitly configured
proxies are stored. (see #261)
2015-07-17 11:54:46 +02:00
Christian Kamm
031d35de03 Network: Fix enabling of proxy auth text fields. 2015-07-16 10:27:15 +02:00
Markus Goetz
ef1e6add4f Settings: Auto download bandwidth limit #1485 2015-06-29 17:43:25 +02:00
Daniel Molkentin
2db17a57d2 Fix header names 2014-11-09 23:25:57 +01:00
Daniel Molkentin
ae85aa33fd Adjust namespaces 2014-11-09 22:34:07 +01:00
Daniel Molkentin
f2eadacf09 Remove "Mirall" from class names 2014-11-09 22:30:29 +01:00
Daniel Molkentin
df3c3bca02 Split into three separate projects: library, gui and cmd 2014-07-11 11:07:31 +02:00