when a build is configured without the network proxy feature, ensure we
do not show any UI related to network proxy settings in the new account
wizard
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
also ensure we properly check the state of the dialog when needed and only when needed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
connect the new UI to real proxy settings and allow modification and
store them when the user has finished setting them up
close#8602
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
If only VFS sync is configured, the sync state would be stuck to
`SyncPrepare` otherwise, unless a file is downloaded/uploaded from the
configured VFS directory.
I think this broke with ee3ae980a8, where
the EnumerationListener that reported the sync states got removed.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Using the short local folder name has some interesting side effects,
such as ending up as being e.g. "C:\MySyncRoot" or "Desktop\MySyncRoot"
due to it just removing the path to the current user's home directory.
IMO using the remote path for the sidebar entry is more logical -- I
don't care where I synced it to locally, I just want to know what my
sync destination is.
To improve future maintenance I moved the generation of the sidebar
display name to a separate method, and added some quick unit tests.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
- only activate VFS for the account if the user chose to do so
- don't display the "VFS is now active" messagebox during account setup
- set VFS enabled in the FileProviderSettingsController, the
enabled/disabled state is set in a .plist file (e.g.
`~/Library/Preferences/com.nextcloud.desktopclient.plist`) ...
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
also use `FileSystem::removeRecursively` to properly handle deletion of
read-only directories/files
There's now an integration test for this feature after all those years
as well ;-)
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
- Migrate vfs mode from config and load cfapi plugin for the folder.
- Move rename logic to Utility class.
Signed-off-by: Camila Ayres <hello@camilasan.com>
Figuring out whether a sync conflict occurred by iterating through the
entire activity list each time a new activity was added is really slow,
even more so when there already are thousands of previous activities.
This was especially noticeable during complete initial full syncs
involving more than ~5000 files.
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
the sharing/activity button was supposed to be hidden, but a later
change forgot to adapt the variable used for querying the file metadata
so it never could determine the e2e-status
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
add a couple more info when receiving a reply to make it easier to link
the reply with the emitteed request
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
