Commit Graph

438 Commits

Author SHA1 Message Date
Matthieu Gallien
240e7fa6b6
ensure we can delete invalid read-only items
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-02-21 16:20:28 +01:00
Camila Ayres
6a81e2babe Check if folder exists before deleting sync db and VFS sync root connection.
Fix for #7860.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-02-20 09:11:19 +01:00
Camila Ayres
93d41ec8ba
blacklist => selectiveSyncList.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-02-18 16:00:21 +01:00
Camila Ayres
69acd45389
fi => excludeItemFileInfo.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-02-18 16:00:21 +01:00
Camila Ayres
a955a83b39
Add {} to single line if.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-02-18 16:00:20 +01:00
Camila Ayres
eb4add9ee6
qCInfo => qCDebug
Reported at #7873.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-02-18 16:00:14 +01:00
Camila Ayres
f62efca6c4 Improve text returned when checking VFS availability.
- Display more clear error when adding local sync folder and when selecting remote folder.
- Modernize FolderWizardRemotePath::isComplete().
- Display the local folder path when warning that folder is already being synced.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2025-02-11 09:08:26 +01:00
Matthieu Gallien
2a52ec33b0 add support to use PKCS#11 harware token to store certifice for e2ee
Close #5685

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-02-07 09:12:29 +01:00
Claudio Cambra
46dc2a71f7 Apply max concurrent chunk uploads retrieved from server capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-23 10:13:51 +08:00
Claudio Cambra
bca2f1db9d Remove overrideServerChunkSize config entry
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-23 10:13:51 +08:00
Claudio Cambra
0f02d70e3c Actually call overrideServerChunkSize
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-23 10:13:51 +08:00
Claudio Cambra
b3ff083c02 Do not apply max capabilities chunk size as min chunk size too
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-23 10:13:51 +08:00
Claudio Cambra
a77f3271bd Fix capsMaxChunkSize comparison
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-23 10:13:51 +08:00
Claudio Cambra
44a599e7ae Remove extraneous parenthesis
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-23 10:13:51 +08:00
Claudio Cambra
93570808d4 Add config entry to override server chunk size
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-23 10:13:51 +08:00
Claudio Cambra
a7d044f9e6 Enforce chunk size provided by server capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-23 10:13:51 +08:00
Claudio Cambra
d7c5435e42 Override config chunk sizing values with max chunk size retrieved from capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2025-01-23 10:13:51 +08:00
Matthieu Gallien
2701a3c9f4 ensure proper read write access to root folder and db files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2025-01-07 08:45:16 +01:00
Claudio Cambra
1009fed86a Replace all uses of qAsConst with std::as_const
Fixes deprecation warnings on Qt 6.8.0

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-12-20 16:26:57 +01:00
Hannah von Reth
47132d3beb Fix crash on missing sync root
Fixes: #9016
2024-12-12 12:15:44 +01:00
Matthieu Gallien
52e78b3ece when locking a file set If-Match header to ensure etag is correct
the file being locked may have been changed sinc the client synced it

so the server side file may have a modified etag. In such cases we do
not want to lock the file and would rather sync the nex server changes
before being able to lock the file

that would ensure that on client side the file being locked is matching
teh state of teh file on server side and would prevent inadvertently
overriding server changes

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-12-09 09:33:49 +01:00
Matthieu Gallien
42cae2c5f1 when updating a virtual file after lock/unlock: avoid setting modtime
will prevent truncating the modification time when changing the lock
state of a file

could be visible when using an office software to open an office file
with automated locking happening after the file gets opened

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-29 09:24:22 +01:00
Matthieu Gallien
8ddf11d960 detect the terms of service app is requiring the user to sign them
will query the sign state for the terms of service and automatically
pause or resume sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-22 15:03:45 +02:00
Matthieu Gallien
08abceda73 improve wordings of confirmation dialog when many files are deleted
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-16 09:11:13 +02:00
Matthieu Gallien
bf2fc44cfc
message should say many not all: would be triggered by 200 files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-01 16:41:56 +02:00
Matthieu Gallien
8faefc6fa2 delete invalid folders and restart sync automatically
users should then notice that the sync errors are gone

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
a118c0ad1e detect remnants read-only folders to delete: try to delete them
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
316af5c13f avoid wrong usage of QStringBuilder via auto type deduction
detected via https://github.com/KDE/clazy/blob/master/docs/checks/README-auto-unexpected-qstringbuilder.md#auto-unexpected-qstringbuilder

also reported by g++ via compile time warnings

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-22 14:53:46 +02:00
Claudio Cambra
480828bbbb
Respect account-specific transfer limits in folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-22 15:37:50 +08:00
alex-z
f70d1c1079
Support Windows .lnk files with VFS Cf API.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-07-10 10:29:21 +02:00
Camila Ayres
b3ff87b73e Make warning text before deleting all files more clear and concise.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-06-28 18:18:08 +02:00
Camila Ayres
1f88052a8e Fix #3144: check for promptDeleteAllFiles config setting before emitting signal to display warning.
The signal is not connected to any slot when running nextcloudcmd.
The callback to finish the sync was never being called because the check for the config was done in the slot,
which was never called.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-06-28 18:18:08 +02:00
Matthieu Gallien
347285b5b3 fix build issue after rebase
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-26 09:05:12 +02:00
Matthieu Gallien
aae9e84438 fix compilation issues after rebase
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-26 09:05:12 +02:00
Matthieu Gallien
e3456847d8 last step
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-26 09:05:12 +02:00
Matthieu Gallien
1f0279e1c1 remove usage of QStringRef due to it being missing in Qt6
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-26 09:05:12 +02:00
Matthieu Gallien
1522d01d5b if a virtual file change but bothing changed: set it as in sync
some software (at least outlook native software) may fiddle with CfApi
placeholder metadta and set a .msg file to be out of sync state when
opening it

in that case, we will let the sync engine go over it and decide what to
do

it is then possible in that case that we would just put it back in "in
sync" state

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-23 18:04:35 +02:00
alex-z
dbde9e3a2b Detect office files for locking on new upload. Notify FolderWatcher.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-04-13 15:46:37 +02:00
alex-z
c0e0b53ee5 Bugfix. E2EE V2. Fix incorrect root e2ee folder path search in local db.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-02-28 15:37:50 +01:00
alex-z
7160c05033 Fix crash when deleting a local sync folder during sync.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-02-23 12:46:17 +01:00
Matthieu Gallien
c254bb01a3
do not check lock type if server API is missing it
will allow automated unlock if the server API is missing the ability to
handle the lock types sent by the client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-02-19 14:53:47 +01:00
Matthieu Gallien
17256d3902
add extra logs to investigate lock type issues
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-02-19 14:53:47 +01:00
alex-z
2eaecb6400 File locking. Manual lock should never be modified without user intervention. Set token lock instead of user lock when locking office files automatically.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-01-18 10:21:09 +01:00
alex-z
e77b52e708 VFS. Properly set Folders/WithPlaceholders in config when switching modes. Refactoring.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-11-20 16:48:18 +01:00
alex-z
727cd797ff Show more informative error message when VFS hydration fails. Display a popup and put an error into activity list. More detailed logs.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-10-20 14:54:42 +02:00
alex-z
3815919aa5 Fix a crash when saving the locked Word document file due to unnecessary spam to the lock state change from folder watcher logic.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-09-05 15:52:04 +02:00
Claudio Cambra
2503ded168
Lock files when relevant lock files found by folder watcher
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-09-01 17:15:45 +02:00
Camila
6f38545e09
Migrate selective sync db list.
- Refactor migration of blacklisted folders.
- Only change selective sync list if needed.

Signed-off-by: Camila <hello@camila.codes>
2023-09-01 15:09:29 +02:00
alex-z
f3db221314 Update Word files VFS placeholders each time they get opened by tracking the 'lock' files
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-09-01 15:04:17 +02:00
Claudio Cambra
2f5c164534 Enforce Chunk V2 API chunk size limits at the sync options level
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-08-31 15:25:00 +02:00