mirrors/nextcloud-desktop
3
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2025-10-26 11:17:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
21,137 Commits 194 Branches 287 Tags 562 MiB
032af80d4d
Commit Graph

249 Commits

Author SHA1 Message Date
Matthieu Gallien
1f0279e1c1 remove usage of QStringRef due to it being missing in Qt6 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
1522d01d5b if a virtual file change but bothing changed: set it as in sync 
some software (at least outlook native software) may fiddle with CfApi
placeholder metadta and set a .msg file to be out of sync state when
opening it

in that case, we will let the sync engine go over it and decide what to
do

it is then possible in that case that we would just put it back in "in
sync" state

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-23 18:04:35 +02:00
alex-z
57f6c7cda2 Also support nested folder scenarios. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-04-23 12:18:12 +02:00
alex-z
d2bfb59d6a Bugfix. Folder invalid char conflict. Do not update parent folder record if it contains conflicted subfolders. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-04-23 12:18:12 +02:00
alex-z
d240ed9d50 Bugfix. Folder case clash conflict. Do not update parent folder record if it contains conflicted subfolers. Also fix crash with local rename. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-04-23 12:18:12 +02:00
Claudio Cambra
42504d0a0f Wrap all use of std::filesystem in ifdefs to fix legacy build for <macOS 10.15 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-28 19:11:57 +08:00
Matthieu Gallien
4844f326c1 newly created folders will be read-only when needed 
Close #6296

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-03-12 23:30:02 +01:00
Matthieu Gallien
e607e9d1fb always store newly created folders in DB even if it is missing 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-03-12 08:45:06 +01:00
alex-z
c0e0b53ee5 Bugfix. E2EE V2. Fix incorrect root e2ee folder path search in local db. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-02-28 15:37:50 +01:00
alex-z
ccf99125b5 Client Status Reporting. Only report statuses listed on the server. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-02-28 14:47:37 +01:00
alex-z
af612525c4 End-to-End Encryption V2. Implemented sharing between users. Automatic migration from 1.0 to 2.0(only for flat folders). Improved secure filedrop. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-01-29 16:13:25 +01:00
alex-z
50d168759f Added error reporting for E2EE issues. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-12-11 18:03:57 +01:00
alex-z
c30e526bc8 Report error Virus Detected. Updated tests. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-12-11 18:03:57 +01:00
alex-z
8e38739d94 Generate client status report records when errors happen. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-12-11 18:03:57 +01:00
alex-z
5b54b13a97 Iteration. Properly process server reply. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-12-11 18:03:57 +01:00
Matthieu Gallien
bf78f008bd
extend log to get information about mtime modifications by the client 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-12-06 10:42:33 +01:00
Matthieu Gallien
b77fc9d4ff
avoid modifying a placeholder (virtual files) when not needed 
acoid modifying some metadata of the placeholder when this placeholder
has just been uploaded to the server (will avoid truncating the
timestamps)

Close #6190

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-12-06 10:13:49 +01:00
alex-z
0f7d29bce6 Ignore upload error items and schedule a new sync in case there are removed items that need to be downsynced. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-09-04 10:02:05 +02:00
Claudio Cambra
2f5c164534 Enforce Chunk V2 API chunk size limits at the sync options level 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-08-31 15:25:00 +02:00
Dimitri Papadopoulos
9d830e94f9 Fix typos found by codespell 
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
 2023-06-21 08:47:13 +02:00
alex-z
bd37b711fe Fix clang compile error. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-06-14 15:01:43 +02:00
allexzander
63470c0e21 Correctly handle errors for unsupported filenames on the server. Allow user to rename those via dialog. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2023-06-14 12:48:56 +02:00
Matthieu Gallien
5372276779 add more metadata to sync errors to allow filtering 
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-07 17:25:44 +02:00
alex-z
90e3a37a20 E2EE. Fix freeze on metadata checksum validation. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-05-08 11:29:16 +02:00
Matthieu Gallien
7118fc4650 use a better name for encryption status attributes 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-12 15:46:51 +02:00
Matthieu Gallien
e22b130d98
prevent syncing with downgraded metadata format 
should prevent a malicious server admin to make clients fallback to
older vulnerable metadata format

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
8659df2266
prevent downgrading e2ee metadata format after initial migration 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:29 +02:00
Matthieu Gallien
7c655cf679
use a getter to query encryption status 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00
alex-z
b6ba1fe0d6 Implement Secure filedrop link share. Move data from 'filedrop' to 'files' when syncing E2EE folders. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-03-02 19:29:11 +01:00
Matthieu Gallien
c0549c5c03
fix issues reported by compiling windows code with clang-tidy 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-22 16:50:20 +01:00
Matthieu Gallien
079d392d36
move init to default value in class declaration 
done via clang-tidy and manual tuning

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-06 10:43:05 +01:00
Matthieu Gallien
602b8db5e2
handle case clash conflicts in a similar way to content conflicts 
introduce a new type of conflict for case clash filename conflicts

add proper handling including a new utility class to solve them and a
new dialog for the user to pick a fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-01-25 16:37:35 +01:00
Matthieu Gallien
be9d7d724f do not use bulk upload for e2ee files 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-12-09 08:57:31 +01:00
Matthieu Gallien
b68754827c case clash should not prevent full propagation 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-30 11:49:35 +01:00
Matthieu Gallien
402d959cae do not skip folder deletion if BlacklistedError during propagation 
in case some propgation actions ends up with a BlacklistedError, we
would skip the deletions of local folders (even though they have been
deleted from server)

let's not skip them but rather keep track of the error status and
properly report them

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-07 18:33:13 +01:00
Matthieu Gallien
ecc588c27a avoid possibly crashing static_cast 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-03 10:23:24 +02:00
Claudio Cambra
6fa2542a10 Categorise file name clash sync file issues as separate FileNameClash enum treated as warning 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 12:10:38 +02:00
allexzander
b40c2dfe01 Revert "Remove behavior changes." 
This reverts commit 84d06ce9906df7bb6d87bf7093dd11fac6a6057a.

Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
d425005a29 Remove behavior changes. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
84cf9c833d Fix regression in the PropagateDirectory::slotSubJobsFinished. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
d7950304ee Do not ignore return values for SyncJournalDB calls in propagator jobs and discovery. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
alex-z
e081f0ba72 Set '_abortRequested' properly within the propagator so the error is not displayed in UI. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-07 13:35:42 +03:00
Matthieu Gallien
8bbf6b68d3 improve logs of OwncloudPropagator::localFileNameClash 
no need to print a line each time we check for a name clash

always print a line when a clash is detected

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-07-20 14:17:49 +02:00
alex-z
bf80efc7ab Fix review comments from Matthieu. Using curent reverse iterator when searching for parent. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-25 15:31:26 +00:00
alex-z
6c690a1b09 Do not remove a folder that has files that were not uploaded yet during propagation. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-25 15:31:26 +00:00
rakekniven
961cea92ca l10n: Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-01-12 15:55:56 +01:00
Valdnet
cedf079762
Remove parenthesis 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-12-17 08:53:35 +01:00
Matthieu Gallien
3e82466d5e ensure any errors after calling FileSystem::getModTime are handled 
be sure that even in release mode no errors when calling getModTime
could be ignored

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-16 15:28:46 +01:00
Matthieu Gallien
41c86d6459 prevent cases where desktop client would store invalid modified time 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
c194605c35 implement bulk upload 
add PutMultiFileJob to send many files at once

use it in BulkPropagatorJob to implement bulk upload feature

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-24 16:17:47 +01:00